{"id":8734,"url":"https://patchwork.libcamera.org/api/patches/8734/?format=json","web_url":"https://patchwork.libcamera.org/patch/8734/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200709132835.112593-20-paul.elder@ideasonboard.com>","date":"2020-07-09T13:28:31","name":"[libcamera-devel,v5,19/23] libcamera: StreamConfiguration: Update stride documentation","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"2b598096b81eb0e63167c41901129ae8ec4c9590","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8734/mbox/","series":[{"id":1093,"url":"https://patchwork.libcamera.org/api/series/1093/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1093","date":"2020-07-09T13:28:12","name":"Clean up formats in v4l2-compat and pipeline handlers","version":5,"mbox":"https://patchwork.libcamera.org/series/1093/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8734/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8734/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03A71BD792\n\tfor ;\n\tThu, 9 Jul 2020 13:29:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C48876124F;\n\tThu, 9 Jul 2020 15:29:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C96C8611BA\n\tfor ;\n\tThu, 9 Jul 2020 15:29:36 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 977099CC;\n\tThu, 9 Jul 2020 15:29:34 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eCOLanQJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594301376;\n\tbh=u9MOtYm3vp3VxRbxe4jjmWJ4cEoRr7b/itCNiX0RisU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=eCOLanQJn5/KQpYZzwxA5IxPt6bhrfcQNE9gCQGY7TpIJjgiLyS6H6uAlMPUjRMk1\n\tqMsWU8n89l/xT5aFTBsHlqj1zHWIEv0GCXwbxn2h8QDbgH1L/0hXYSzdRSkF/3Ngaf\n\t5P2hBpqXEAl3xLUaO6JQYRqGwEszcuQJ2OJM5Y+k=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 9 Jul 2020 22:28:31 +0900","Message-Id":"<20200709132835.112593-20-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200709132835.112593-1-paul.elder@ideasonboard.com>","References":"<20200709132835.112593-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v5 19/23] libcamera: StreamConfiguration:\n\tUpdate stride documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that all the pipeline handlers fill in the stride information at\nvalidation time, update the documentation accordingly.\n\nSigned-off-by: Paul Elder \nReviewed-by: Laurent Pinchart \nReviewed-by: Jacopo Mondi \n\n---\nNo change in v5\n\nNo change in v4\n\nNew in v3\n---\n src/libcamera/stream.cpp | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)","diff":"diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\nindex 6d6e279..d5da834 100644\n--- a/src/libcamera/stream.cpp\n+++ b/src/libcamera/stream.cpp\n@@ -309,11 +309,8 @@ StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n *\n * The stride value reports the number of bytes between the beginning of\n * successive lines in an image buffer for this stream. The value is\n- * valid after successfully configuring the camera with this\n- * configuration with a call to Camera::Configure().\n- *\n- * \\todo Update this value when configuration is validated instead of when\n- * the camera is configured.\n+ * valid after successfully validating the configuration with a call to\n+ * CameraConfiguration::validate().\n */\n \n /**\n","prefixes":["libcamera-devel","v5","19/23"]}