[{"id":11297,"web_url":"https://patchwork.libcamera.org/comment/11297/","msgid":"<20200709191707.GD5868@pendragon.ideasonboard.com>","date":"2020-07-09T19:17:07","subject":"Re: [libcamera-devel] [PATCH v5 14/23] libcamera: raspberrypi: Set\n\tdefault configuration size at validation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\n(CC'ing Naush)\n\nThank you for the patch.\n\nOn Thu, Jul 09, 2020 at 10:28:26PM +0900, Paul Elder wrote:\n> If a native format is not found, a default NV12 format is set. However,\n> this does not set a default configuration size, sometimes resulting in a\n> 0x0 size. Fix this by setting a default configuration size.\n> \n> Signed-off-by: Paul Elder \n> \n> ---\n> New in v5, split from \"libcamera: raspberrypi: Fill stride and frameSize\n> at config validation\"\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index a08ad6a..5f00500 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -500,6 +500,9 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n> \t\tif (fmts.find(V4L2PixelFormat::fromPixelFormat(cfgPixFmt, false)) == fmts.end()) {\n> \t\t\t/* If we cannot find a native format, use a default one. */\n> \t\t\tcfgPixFmt = formats::NV12;\n> +\t\t\tcfg.size.width = 1920;\n> +\t\t\tcfg.size.height = 1080;\n> +\n\nIs this the right fix ? Someone could pass an unsupported pixel format\nwith a valid size, or the other way around, a valid pixel format with a\nnull size. It seems to me that you should clamp the size based on the\nsensor resolution and the scaler capabilities.\n\n> \t\t\tstatus = Adjusted;\n> \t\t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B49C6BD790\n\tfor ;\n\tThu, 9 Jul 2020 19:17:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4747161253;\n\tThu, 9 Jul 2020 21:17:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CA1B46123A\n\tfor ;\n\tThu, 9 Jul 2020 21:17:14 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EE6E256E;\n\tThu, 9 Jul 2020 21:17:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MoKheg91\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594322234;\n\tbh=boKmqPrdHzOy++wvTvmBxYoOa+J3qTbKD171TiLqECs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MoKheg91Cw3y7puipGO/Km65ba8R0ixax44gk2u3iRlLdDhULekpS8eaUpnPnLV69\n\tBTdB8DYw6zkawsAaUxM+BhMDdQYRk5xJDZknWR+K+ldsbkzDcz8MYW+5fxAxuxC/3s\n\tSaDIXnzGd1Ma/+96OSS6YTbFDVBP9R/DtHwJhlhw=","Date":"Thu, 9 Jul 2020 22:17:07 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"<20200709191707.GD5868@pendragon.ideasonboard.com>","References":"<20200709132835.112593-1-paul.elder@ideasonboard.com>\n\t<20200709132835.112593-15-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200709132835.112593-15-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v5 14/23] libcamera: raspberrypi: Set\n\tdefault configuration size at validation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]