{"id":8729,"url":"https://patchwork.libcamera.org/api/patches/8729/?format=json","web_url":"https://patchwork.libcamera.org/patch/8729/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200709132835.112593-15-paul.elder@ideasonboard.com>","date":"2020-07-09T13:28:26","name":"[libcamera-devel,v5,14/23] libcamera: raspberrypi: Set default configuration size at validation","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"33c66761373715dda4747611c1241206296f88a0","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8729/mbox/","series":[{"id":1093,"url":"https://patchwork.libcamera.org/api/series/1093/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1093","date":"2020-07-09T13:28:12","name":"Clean up formats in v4l2-compat and pipeline handlers","version":5,"mbox":"https://patchwork.libcamera.org/series/1093/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8729/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8729/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0AAACBD792\n\tfor ;\n\tThu, 9 Jul 2020 13:29:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CC1DD61214;\n\tThu, 9 Jul 2020 15:29:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 34B2F61184\n\tfor ;\n\tThu, 9 Jul 2020 15:29:24 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7D59B56E;\n\tThu, 9 Jul 2020 15:29:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ReSsM0Yl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594301362;\n\tbh=EMXNuZEE6bh/6i3wipPc7HOgWZjVkxvGkxqN/EFzbMI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ReSsM0Ylm4uG9oLx3GqWuNCp59kRrgWPsXfAgqzJDOo25NLlmo+mKTjdL0J8Xca3D\n\tH9q//9MSm9B04t/LRbXR+CkF+sBNCSbhpLxxa2/oMEKqSExRp/ximfQSquqw5xArcs\n\toOBbE0PXwj/agCEyOxX+j8pXpuq0HpN2mKjqbaBU=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 9 Jul 2020 22:28:26 +0900","Message-Id":"<20200709132835.112593-15-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200709132835.112593-1-paul.elder@ideasonboard.com>","References":"<20200709132835.112593-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v5 14/23] libcamera: raspberrypi: Set\n\tdefault configuration size at validation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"If a native format is not found, a default NV12 format is set. However,\nthis does not set a default configuration size, sometimes resulting in a\n0x0 size. Fix this by setting a default configuration size.\n\nSigned-off-by: Paul Elder \n\n---\nNew in v5, split from \"libcamera: raspberrypi: Fill stride and frameSize\nat config validation\"\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex a08ad6a..5f00500 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -500,6 +500,9 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n \t\tif (fmts.find(V4L2PixelFormat::fromPixelFormat(cfgPixFmt, false)) == fmts.end()) {\n \t\t\t/* If we cannot find a native format, use a default one. */\n \t\t\tcfgPixFmt = formats::NV12;\n+\t\t\tcfg.size.width = 1920;\n+\t\t\tcfg.size.height = 1080;\n+\n \t\t\tstatus = Adjusted;\n \t\t}\n \n","prefixes":["libcamera-devel","v5","14/23"]}