{"id":8727,"url":"https://patchwork.libcamera.org/api/patches/8727/?format=json","web_url":"https://patchwork.libcamera.org/patch/8727/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200709132835.112593-13-paul.elder@ideasonboard.com>","date":"2020-07-09T13:28:24","name":"[libcamera-devel,v5,12/23] libcamera: ipu3: Fill stride and frameSize at config validation","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"db212c7426ca4c3a4472e92226d6a90f0ccd5f70","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8727/mbox/","series":[{"id":1093,"url":"https://patchwork.libcamera.org/api/series/1093/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1093","date":"2020-07-09T13:28:12","name":"Clean up formats in v4l2-compat and pipeline handlers","version":5,"mbox":"https://patchwork.libcamera.org/series/1093/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8727/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8727/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2C9BFBD792\n\tfor ;\n\tThu, 9 Jul 2020 13:29:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EF5ED61221;\n\tThu, 9 Jul 2020 15:29:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 13B7361184\n\tfor ;\n\tThu, 9 Jul 2020 15:29:19 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 33DA1525;\n\tThu, 9 Jul 2020 15:29:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ozBd2D5b\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594301358;\n\tbh=WJQYWIR9dO09qEADGTKWs1L3C0eGUVRmmPPR/vrM8bo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ozBd2D5bb2X68P0JucNyoptP2BV7BMxjyb7Oyanf85WLpp5z18uR+6qOVMkn1EbX0\n\tM0qAuMnchMLxOoAZgMOKc1oeCH3CW+cM7YvRbv+M+kMnCcDzCZyRodYoUou2M3fWCP\n\t4WXgLxRTWZlMQc3CZ/10D+L4CsWlfxSloLM0B0+g=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 9 Jul 2020 22:28:24 +0900","Message-Id":"<20200709132835.112593-13-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200709132835.112593-1-paul.elder@ideasonboard.com>","References":"<20200709132835.112593-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v5 12/23] libcamera: ipu3: Fill stride and\n\tframeSize at config validation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Fill the stride and frameSize fields of the StreamConfiguration at\nconfiguration validation time instead of at camera configuration time.\nThis allows applications to get the stride when trying a configuration\nwithout modifying the active configuration of the camera.\n\nSigned-off-by: Paul Elder \nReviewed-by: Laurent Pinchart \n\n---\nChanges in v5:\n- simplify code\n\nChanges in v4:\n- fix stride and frameSize calculation\n- mention motivation in commit message\n\nNew in v3\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 14 ++++++--------\n 1 file changed, 6 insertions(+), 8 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex af51fb2..eb00eec 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -278,6 +278,12 @@ CameraConfiguration::Status IPU3CameraConfiguration::validate()\n \t\t\t\t<< cfg.toString();\n \t\t\tstatus = Adjusted;\n \t\t}\n+\n+\t\tconst PixelFormatInfo &info = PixelFormatInfo::info(cfg.pixelFormat);\n+\t\tbool packedRaw = info.colourEncoding == PixelFormatInfo::ColourEncodingRAW;\n+\n+\t\tcfg.stride = info.stride(cfg.size.width, 0, packedRaw ? 64 : 1);\n+\t\tcfg.frameSize = info.frameSize(cfg.size, packedRaw ? 64 : 1);\n \t}\n \n \treturn status;\n@@ -495,21 +501,13 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n \t\t\tif (ret)\n \t\t\t\treturn ret;\n \n-\t\t\tcfg.stride = outputFormat.planes[0].bpl;\n \t\t\toutActive = true;\n \t\t} else if (stream == vfStream) {\n \t\t\tret = imgu->configureViewfinder(cfg, &outputFormat);\n \t\t\tif (ret)\n \t\t\t\treturn ret;\n \n-\t\t\tcfg.stride = outputFormat.planes[0].bpl;\n \t\t\tvfActive = true;\n-\t\t} else {\n-\t\t\t/*\n-\t\t\t * The RAW stream is configured as part of the CIO2 and\n-\t\t\t * no configuration is needed for the ImgU.\n-\t\t\t */\n-\t\t\tcfg.stride = cio2Format.planes[0].bpl;\n \t\t}\n \t}\n \n","prefixes":["libcamera-devel","v5","12/23"]}