[{"id":11293,"web_url":"https://patchwork.libcamera.org/comment/11293/","msgid":"<5b85836f-65be-442d-e7f3-fad797a9eaef@ideasonboard.com>","date":"2020-07-09T14:42:22","subject":"Re: [libcamera-devel] [PATCH v5 03/23] libcamera:\n\tStreamConfiguration: Add frameSize field","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Paul,\n\nOn 09/07/2020 14:28, Paul Elder wrote:\n> In addition to the stride field, we want the pipeline handler to be able\n> to declare the frame size for the configuration. Add a frameSize field\n> to StreamConfiguration for this purpose.\n> \n> Signed-off-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \n> \n> ---\n> No change in v5\n> \n> No change in v4\n> \n> New in v3\n> ---\n> include/libcamera/stream.h | 1 +\n> src/libcamera/stream.cpp | 17 ++++++++++++++---\n> 2 files changed, 15 insertions(+), 3 deletions(-)\n> \n> diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\n> index 1a68bd2..f502b35 100644\n> --- a/include/libcamera/stream.h\n> +++ b/include/libcamera/stream.h\n> @@ -43,6 +43,7 @@ struct StreamConfiguration {\n> \tPixelFormat pixelFormat;\n> \tSize size;\n> \tunsigned int stride;\n> +\tunsigned int frameSize;\n> \n> \tunsigned int bufferCount;\n> \n> diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> index 6df5882..6d6e279 100644\n> --- a/src/libcamera/stream.cpp\n> +++ b/src/libcamera/stream.cpp\n> @@ -279,7 +279,8 @@ SizeRange StreamFormats::range(const PixelFormat &pixelformat) const\n> * handlers provide StreamFormats.\n> */\n> StreamConfiguration::StreamConfiguration()\n> -\t: pixelFormat(0), stride(0), bufferCount(0), stream_(nullptr)\n> +\t: pixelFormat(0), stride(0), frameSize(0), bufferCount(0),\n> +\t stream_(nullptr)\n> {\n> }\n> \n> @@ -287,8 +288,8 @@ StreamConfiguration::StreamConfiguration()\n> * \\brief Construct a configuration with stream formats\n> */\n> StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n> -\t: pixelFormat(0), stride(0), bufferCount(0), stream_(nullptr),\n> -\t formats_(formats)\n> +\t: pixelFormat(0), stride(0), frameSize(0), bufferCount(0),\n> +\t stream_(nullptr), formats_(formats)\n> {\n> }\n> \n> @@ -315,6 +316,16 @@ StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n> * the camera is configured.\n> */\n> \n> +/**\n> + * \\var StreamConfiguration::frameSize\n> + * \\brief Frame size for the stream, in bytes\n> + *\n> + * The frameSize value reports the number of bytes necessary to contain one\n> + * frame of an image buffer for this stream. The value is valid after\n> + * successfully validating the configuration with a call to\n> + * CameraConfiguration::validate().\n\nHow will we handle multi-planar formats? Will this always be the total\nof all planes? Should we state if this total includes bytes required for\nall image planes explicitly?\n\nIn fact, will there be a planeSize function too?\n\nStill, that can be later either way.\n\nReviewed-by: Kieran Bingham \n\n\nThough, should this be squashed with \"libcamera: PixelFormatInfo: Add\nfunctions stride and frameSize\" ? Otherwise this value becomes available\nat this point but always zero.\n\nIt's only used first in that patch, so I'd at least put this patch\ndirectly before so that the closely-related patches are adjacent.\n\n\n\n> + */\n> +\n> /**\n> * \\var StreamConfiguration::bufferCount\n> * \\brief Requested number of buffers to allocate for the stream\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 144B8BD790\n\tfor ;\n\tThu, 9 Jul 2020 14:42:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 831BE612E6;\n\tThu, 9 Jul 2020 16:42:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F09DF611BA\n\tfor ;\n\tThu, 9 Jul 2020 16:42:25 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5BFE7525;\n\tThu, 9 Jul 2020 16:42:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vf44Eezv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594305745;\n\tbh=kt5GS3I3VQpZzt0igi218vsaFi9ojrgr1MNboasNIxw=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=vf44EezvRnymeQfnBFre1Bzo9j+a16OkIIjgPspXcQPx1lO9VT7opRl9SbCWJsApF\n\twvQJPlT+HXEiaWPAN7TPS9qJ8UnMU1qwzOc521iTNy40Q0Vm9jOKjRKQh5VdZf1iTH\n\tYWW+takVd5+3Q3+ZY+eNTToVxyhXyvBXcqIdW5Do=","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200709132835.112593-1-paul.elder@ideasonboard.com>\n\t<20200709132835.112593-4-paul.elder@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<5b85836f-65be-442d-e7f3-fad797a9eaef@ideasonboard.com>","Date":"Thu, 9 Jul 2020 15:42:22 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.8.0","MIME-Version":"1.0","In-Reply-To":"<20200709132835.112593-4-paul.elder@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v5 03/23] libcamera:\n\tStreamConfiguration: Add frameSize field","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11301,"web_url":"https://patchwork.libcamera.org/comment/11301/","msgid":"<20200710052352.GF66701@pyrite.rasen.tech>","date":"2020-07-10T05:23:52","subject":"Re: [libcamera-devel] [PATCH v5 03/23] libcamera:\n\tStreamConfiguration: Add frameSize field","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Thu, Jul 09, 2020 at 03:42:22PM +0100, Kieran Bingham wrote:\n> Hi Paul,\n> \n> On 09/07/2020 14:28, Paul Elder wrote:\n> > In addition to the stride field, we want the pipeline handler to be able\n> > to declare the frame size for the configuration. Add a frameSize field\n> > to StreamConfiguration for this purpose.\n> > \n> > Signed-off-by: Paul Elder \n> > Reviewed-by: Laurent Pinchart \n> > \n> > ---\n> > No change in v5\n> > \n> > No change in v4\n> > \n> > New in v3\n> > ---\n> > include/libcamera/stream.h | 1 +\n> > src/libcamera/stream.cpp | 17 ++++++++++++++---\n> > 2 files changed, 15 insertions(+), 3 deletions(-)\n> > \n> > diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\n> > index 1a68bd2..f502b35 100644\n> > --- a/include/libcamera/stream.h\n> > +++ b/include/libcamera/stream.h\n> > @@ -43,6 +43,7 @@ struct StreamConfiguration {\n> > \tPixelFormat pixelFormat;\n> > \tSize size;\n> > \tunsigned int stride;\n> > +\tunsigned int frameSize;\n> > \n> > \tunsigned int bufferCount;\n> > \n> > diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> > index 6df5882..6d6e279 100644\n> > --- a/src/libcamera/stream.cpp\n> > +++ b/src/libcamera/stream.cpp\n> > @@ -279,7 +279,8 @@ SizeRange StreamFormats::range(const PixelFormat &pixelformat) const\n> > * handlers provide StreamFormats.\n> > */\n> > StreamConfiguration::StreamConfiguration()\n> > -\t: pixelFormat(0), stride(0), bufferCount(0), stream_(nullptr)\n> > +\t: pixelFormat(0), stride(0), frameSize(0), bufferCount(0),\n> > +\t stream_(nullptr)\n> > {\n> > }\n> > \n> > @@ -287,8 +288,8 @@ StreamConfiguration::StreamConfiguration()\n> > * \\brief Construct a configuration with stream formats\n> > */\n> > StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n> > -\t: pixelFormat(0), stride(0), bufferCount(0), stream_(nullptr),\n> > -\t formats_(formats)\n> > +\t: pixelFormat(0), stride(0), frameSize(0), bufferCount(0),\n> > +\t stream_(nullptr), formats_(formats)\n> > {\n> > }\n> > \n> > @@ -315,6 +316,16 @@ StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n> > * the camera is configured.\n> > */\n> > \n> > +/**\n> > + * \\var StreamConfiguration::frameSize\n> > + * \\brief Frame size for the stream, in bytes\n> > + *\n> > + * The frameSize value reports the number of bytes necessary to contain one\n> > + * frame of an image buffer for this stream. The value is valid after\n> > + * successfully validating the configuration with a call to\n> > + * CameraConfiguration::validate().\n> \n> How will we handle multi-planar formats? Will this always be the total\n> of all planes?\n\nYeah, this is the total of all planes.\n\n> Should we state if this total includes bytes required for\n> all image planes explicitly?\n\nI'll add it for clarity.\n\n> In fact, will there be a planeSize function too?\n\nThere doesn't seem to be demand for it at the moment. It's not that\ndifficult for pipeline handlers to do height * stride(format, plane\nindex).\n\n> Still, that can be later either way.\n> \n> Reviewed-by: Kieran Bingham \n> \n> \n> Though, should this be squashed with \"libcamera: PixelFormatInfo: Add\n> functions stride and frameSize\" ? Otherwise this value becomes available\n> at this point but always zero.\n\nEven if it's squashed, the values will be zero until the pipeline\nhandlers fill it, so I think it's fine not to.\n\n> It's only used first in that patch, so I'd at least put this patch\n> directly before so that the closely-related patches are adjacent.\n\nBut this would be good, yes.\n\n> > + */\n> > +\n> > /**\n> > * \\var StreamConfiguration::bufferCount\n> > * \\brief Requested number of buffers to allocate for the stream\n> > \n\n\nThanks,\n\nPaul","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2B29ABD790\n\tfor ;\n\tFri, 10 Jul 2020 05:24:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8FCCC61370;\n\tFri, 10 Jul 2020 07:24:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F7A261167\n\tfor ;\n\tFri, 10 Jul 2020 07:24:01 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6AED02C0;\n\tFri, 10 Jul 2020 07:23:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HVESeHA2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594358640;\n\tbh=G6zC3QQ3xjHmmJWnJ0EY0xQjP6L/k2XB+9q4QvE7ELQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HVESeHA2++Th+3Z49xjTk0UWHQWVp0TGBzA0XwP6C56SCk670dGKVvSKJdXz3Hbtk\n\tJzyU9oc/ybwn0fYEWJdenAmfxDNvLtZ/Eh/1geEgj/gpFMIOLlL+LKHYSfIqZgJQiT\n\tzvhkD8Oru5sKV/iHvjMAXXKslSgr23YeSmMg6Dnk=","Date":"Fri, 10 Jul 2020 14:23:52 +0900","From":"paul.elder@ideasonboard.com","To":"Kieran Bingham ","Message-ID":"<20200710052352.GF66701@pyrite.rasen.tech>","References":"<20200709132835.112593-1-paul.elder@ideasonboard.com>\n\t<20200709132835.112593-4-paul.elder@ideasonboard.com>\n\t<5b85836f-65be-442d-e7f3-fad797a9eaef@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<5b85836f-65be-442d-e7f3-fad797a9eaef@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v5 03/23] libcamera:\n\tStreamConfiguration: Add frameSize field","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]