[{"id":11292,"web_url":"https://patchwork.libcamera.org/comment/11292/","msgid":"<20200709140850.GT3875643@oden.dyn.berto.se>","date":"2020-07-09T14:08:50","subject":"Re: [libcamera-devel] [PATCH v2 20/20] libcamera: ipu3: imgu:\n\tRename configureInput()","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your patch.\n\nOn 2020-07-09 10:41:28 +0200, Jacopo Mondi wrote:\n> The ImgUDevice::configureInput() function does not only configure the\n> input format but applies rectangles to the IF, BDS and GDC components.\n> \n> Rename it to ImgUDevice::configure().\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/ipu3/imgu.cpp | 3 +--\n> src/libcamera/pipeline/ipu3/imgu.h | 2 +-\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> 3 files changed, 3 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\n> index 69bcc4f30962..a9fd2f6d2aa6 100644\n> --- a/src/libcamera/pipeline/ipu3/imgu.cpp\n> +++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n> @@ -445,8 +445,7 @@ ImgUDevice::PipeConfig ImgUDevice::calculatePipeConfig(Pipe *pipe)\n> * \\param[in] inputFormat The format to be applied to ImgU input\n> * \\return 0 on success or a negative error code otherwise\n> */\n> -int ImgUDevice::configureInput(const PipeConfig &pipeConfig,\n> -\t\t\t V4L2DeviceFormat *inputFormat)\n> +int ImgUDevice::configure(const PipeConfig &pipeConfig, V4L2DeviceFormat *inputFormat)\n> {\n> \t/* Configure the ImgU input video device with the requested sizes. */\n> \tint ret = input_->setFormat(inputFormat);\n> diff --git a/src/libcamera/pipeline/ipu3/imgu.h b/src/libcamera/pipeline/ipu3/imgu.h\n> index 6193c84bf35d..16525c8dc6d1 100644\n> --- a/src/libcamera/pipeline/ipu3/imgu.h\n> +++ b/src/libcamera/pipeline/ipu3/imgu.h\n> @@ -45,7 +45,7 @@ public:\n> \n> \tPipeConfig calculatePipeConfig(Pipe *pipe);\n> \n> -\tint configureInput(const PipeConfig &pipeConfig, V4L2DeviceFormat *inputFormat);\n> +\tint configure(const PipeConfig &pipeConfig, V4L2DeviceFormat *inputFormat);\n> \n> \tint configureOutput(const StreamConfiguration &cfg,\n> \t\t\t V4L2DeviceFormat *outputFormat)\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index d33aa7aee5e5..eb4c72b90f3a 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -445,7 +445,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n> \tif (ret)\n> \t\treturn ret;\n> \n> -\tret = imgu->configureInput(config->imguConfig(), &cio2Format);\n> +\tret = imgu->configure(config->imguConfig(), &cio2Format);\n> \tif (ret)\n> \t\treturn ret;\n> \n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D35EFBD792\n\tfor ;\n\tThu, 9 Jul 2020 14:08:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A5FA5612EA;\n\tThu, 9 Jul 2020 16:08:53 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E499611B2\n\tfor ;\n\tThu, 9 Jul 2020 16:08:52 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id e8so2579234ljb.0\n\tfor ;\n\tThu, 09 Jul 2020 07:08:52 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id d2sm847026ljg.6.2020.07.09.07.08.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 09 Jul 2020 07:08:50 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"x9HMDL3v\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=KwskH2rad66+xAqnRhGJG2Bv3vWCu47EEzkljYaU1qg=;\n\tb=x9HMDL3vOWuW7q0+ANEAxhBAj8iSEUNNPNrCdlcwdveT9Ko9rrI8R3zTIKL3uT4Leb\n\tX5t+etdBEAZ1+ySz5tmfTl6z66TIJhC09VrK568oP+auyYOWZ7itHmThP7WRtiCyteQi\n\ty0LQ1E8MuTNI6vgeBq3h91qOic6gBDPlF29Pj7QPv/UPzyZRWoBV6Z41ERBfPxypHCsk\n\tusTgXnBHSEqxePG6rPdWhWo9+kVEip9PPVOSZYHvNDQPe9TwwdwYJ6gcdef/9brgRta9\n\tJhBrMZ/tcVfqfxLeNl3SkfRhcBUz5y2DVGHHT3ovBQtmjO5e5XS+C5GXTtIkM7RuOMOo\n\t+6QQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=KwskH2rad66+xAqnRhGJG2Bv3vWCu47EEzkljYaU1qg=;\n\tb=P5RP/zJZwBZ0gil9gcffrbUR0uCRVEykWfHlXr6wAqhJGqgo8zIqhHVyNaqgUkHx6z\n\tlmPVCda7Q56rUFPzegpbhK4QEXkoaIURAbOVlCySDN1OoncMBBzSXO5sPH8H5SYsVi4q\n\tCLqS0H/qjMSI6TB7Z8Aijad9fQU3mMlV4V/QEVyNa5WY4Z56jgRkgGgwBwFGMhGhvK5d\n\t575SLvpBP0tPCKP+fZ6v7egXq8zKChz05KW8wS9JSzroFXryW23Zg4sczUDDgrUjJKhm\n\t1555i1VE/Bn77TPXxX946kiTQ8VkNblROg4tvsSO16KFT6eOe+FJpac82E8sksXwrcgA\n\to6cA==","X-Gm-Message-State":"AOAM530P/R7JLuuDkZrISfVtd35tJ83OE+XjYxwuQuyouLwoB7VAIgy1\n\tz7l8h8HkXc1O8WuoqV3AXWWZUk7oD0s=","X-Google-Smtp-Source":"ABdhPJxXVOAoYUqM1qkwcP4gEH4mBQicJaFBKUXgpKKipYVAmAT7zBG7/bSXU+AGK0Pv/m88RL4Rug==","X-Received":"by 2002:a05:651c:50d:: with SMTP id\n\to13mr39062369ljp.181.1594303731446; \n\tThu, 09 Jul 2020 07:08:51 -0700 (PDT)","Date":"Thu, 9 Jul 2020 16:08:50 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200709140850.GT3875643@oden.dyn.berto.se>","References":"<20200709084128.5316-1-jacopo@jmondi.org>\n\t<20200709084128.5316-21-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200709084128.5316-21-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 20/20] libcamera: ipu3: imgu:\n\tRename configureInput()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11334,"web_url":"https://patchwork.libcamera.org/comment/11334/","msgid":"<20200710124944.GA26198@pendragon.ideasonboard.com>","date":"2020-07-10T12:49:44","subject":"Re: [libcamera-devel] [PATCH v2 20/20] libcamera: ipu3: imgu:\n\tRename configureInput()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Thu, Jul 09, 2020 at 10:41:28AM +0200, Jacopo Mondi wrote:\n> The ImgUDevice::configureInput() function does not only configure the\n> input format but applies rectangles to the IF, BDS and GDC components.\n> \n> Rename it to ImgUDevice::configure().\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/ipu3/imgu.cpp | 3 +--\n> src/libcamera/pipeline/ipu3/imgu.h | 2 +-\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> 3 files changed, 3 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\n> index 69bcc4f30962..a9fd2f6d2aa6 100644\n> --- a/src/libcamera/pipeline/ipu3/imgu.cpp\n> +++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n> @@ -445,8 +445,7 @@ ImgUDevice::PipeConfig ImgUDevice::calculatePipeConfig(Pipe *pipe)\n> * \\param[in] inputFormat The format to be applied to ImgU input\n> * \\return 0 on success or a negative error code otherwise\n> */\n> -int ImgUDevice::configureInput(const PipeConfig &pipeConfig,\n> -\t\t\t V4L2DeviceFormat *inputFormat)\n> +int ImgUDevice::configure(const PipeConfig &pipeConfig, V4L2DeviceFormat *inputFormat)\n\nThe documentation still mentions \"Configure the ImgU unit input\".\n\nReviewed-by: Laurent Pinchart \n\n> {\n> \t/* Configure the ImgU input video device with the requested sizes. */\n> \tint ret = input_->setFormat(inputFormat);\n> diff --git a/src/libcamera/pipeline/ipu3/imgu.h b/src/libcamera/pipeline/ipu3/imgu.h\n> index 6193c84bf35d..16525c8dc6d1 100644\n> --- a/src/libcamera/pipeline/ipu3/imgu.h\n> +++ b/src/libcamera/pipeline/ipu3/imgu.h\n> @@ -45,7 +45,7 @@ public:\n> \n> \tPipeConfig calculatePipeConfig(Pipe *pipe);\n> \n> -\tint configureInput(const PipeConfig &pipeConfig, V4L2DeviceFormat *inputFormat);\n> +\tint configure(const PipeConfig &pipeConfig, V4L2DeviceFormat *inputFormat);\n> \n> \tint configureOutput(const StreamConfiguration &cfg,\n> \t\t\t V4L2DeviceFormat *outputFormat)\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index d33aa7aee5e5..eb4c72b90f3a 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -445,7 +445,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n> \tif (ret)\n> \t\treturn ret;\n> \n> -\tret = imgu->configureInput(config->imguConfig(), &cio2Format);\n> +\tret = imgu->configure(config->imguConfig(), &cio2Format);\n> \tif (ret)\n> \t\treturn ret;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6CEB5BD792\n\tfor ;\n\tFri, 10 Jul 2020 12:49:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 097FD613C7;\n\tFri, 10 Jul 2020 14:49:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F1BCE613AF\n\tfor ;\n\tFri, 10 Jul 2020 14:49:51 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6E2C82C0;\n\tFri, 10 Jul 2020 14:49:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pLd/RX85\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594385391;\n\tbh=h9AKb40c5K4DyuCnzJLaZOulrN1eY1FmKkGqDt6FFn0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pLd/RX856E24p5oDKD2sdbFPkDF+53iEJ2aDJcRyKZM+NGnvd8bMmr7WvMVxDTCRV\n\tNTpzxldPkEBKuxq6+WoHRN/jJT9IuwGBqr2W9/VtjEjgha6N+E+CrOTOSPAARt+Zb+\n\tZMI+ac6VlbQdply9uPCgi5IhDj6ty9ndxi4yANQw=","Date":"Fri, 10 Jul 2020 15:49:44 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20200710124944.GA26198@pendragon.ideasonboard.com>","References":"<20200709084128.5316-1-jacopo@jmondi.org>\n\t<20200709084128.5316-21-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200709084128.5316-21-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 20/20] libcamera: ipu3: imgu:\n\tRename configureInput()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]