[{"id":11325,"web_url":"https://patchwork.libcamera.org/comment/11325/","msgid":"<20200710121215.GQ5964@pendragon.ideasonboard.com>","date":"2020-07-10T12:12:15","subject":"Re: [libcamera-devel] [PATCH v2 15/20] libcamera: ipu3: Remove\n\tcamera_ from IPU3CameraConfiguration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Thu, Jul 09, 2020 at 10:41:23AM +0200, Jacopo Mondi wrote:\n> The IPU3CameraConfiguration::camera_ shared pointer is not used.\n> Remove it.\n> \n> Reviewed-by: Niklas Söderlund \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 14 +++-----------\n> 1 file changed, 3 insertions(+), 11 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 1c6627e561c4..9a6e71514c90 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -61,19 +61,13 @@ public:\n> class IPU3CameraConfiguration : public CameraConfiguration\n> {\n> public:\n> -\tIPU3CameraConfiguration(Camera *camera, IPU3CameraData *data);\n> +\tIPU3CameraConfiguration(IPU3CameraData *data);\n> \n> \tStatus validate() override;\n> \n> \tconst StreamConfiguration &cio2Format() const { return cio2Configuration_; };\n> \n> private:\n> -\t/*\n> -\t * The IPU3CameraData instance is guaranteed to be valid as long as the\n> -\t * corresponding Camera instance is valid. In order to borrow a\n> -\t * reference to the camera data, store a new reference to the camera.\n> -\t */\n> -\tstd::shared_ptr camera_;\n> \tIPU3CameraData *data_;\n> \n> \tStreamConfiguration cio2Configuration_;\n> @@ -123,11 +117,9 @@ private:\n> \tMediaDevice *imguMediaDev_;\n> };\n> \n> -IPU3CameraConfiguration::IPU3CameraConfiguration(Camera *camera,\n> -\t\t\t\t\t\t IPU3CameraData *data)\n> +IPU3CameraConfiguration::IPU3CameraConfiguration(IPU3CameraData *data)\n> \t: CameraConfiguration()\n> {\n> -\tcamera_ = camera->shared_from_this();\n> \tdata_ = data;\n> }\n> \n> @@ -289,7 +281,7 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n> \t\t\t\t\t\t\t\tconst StreamRoles &roles)\n> {\n> \tIPU3CameraData *data = cameraData(camera);\n> -\tIPU3CameraConfiguration *config = new IPU3CameraConfiguration(camera, data);\n> +\tIPU3CameraConfiguration *config = new IPU3CameraConfiguration(data);\n> \n> \tif (roles.empty())\n> \t\treturn config;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 817B2BD790\n\tfor ;\n\tFri, 10 Jul 2020 12:12:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4EE5E611BA;\n\tFri, 10 Jul 2020 14:12:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DFC496118A\n\tfor ;\n\tFri, 10 Jul 2020 14:12:21 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6FAA92C0;\n\tFri, 10 Jul 2020 14:12:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"M0e7H16T\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594383141;\n\tbh=YLjxKjJay1wN0YV31ezDU66MpTePlEFV3NWqdakbA5I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=M0e7H16T9NAy+hfgV6apS0vzdQlxYKS8zqp2FvNNZHB//XT/D2yRI+23V09Uet0uH\n\tJSAxESRBLRaGM2JhekQXbPi8Km55rQOnsaibkgmMmvbEr4ykiYmIu3XVwJrG4pv4hn\n\tFhWiNXcUCZ1VIcxzL/+AVsgKEU0y8GnFt0XkHBJE=","Date":"Fri, 10 Jul 2020 15:12:15 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20200710121215.GQ5964@pendragon.ideasonboard.com>","References":"<20200709084128.5316-1-jacopo@jmondi.org>\n\t<20200709084128.5316-16-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200709084128.5316-16-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 15/20] libcamera: ipu3: Remove\n\tcamera_ from IPU3CameraConfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]