[{"id":11286,"web_url":"https://patchwork.libcamera.org/comment/11286/","msgid":"<20200709134254.GN3875643@oden.dyn.berto.se>","date":"2020-07-09T13:42:54","subject":"Re: [libcamera-devel] [PATCH v2 11/20] libcamera: ipu3: Adjust full\n\tframe picture to 32 pixels","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-07-09 10:41:19 +0200, Jacopo Mondi wrote:\n> To respect the same constraint introduced in validate() that the maximum\n> ImgU output size shall be at least 32 pixels smaller than the full frame\n> size, adjust the sizes assigned to the StillCapture role in\n> generateConfiguration().\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 8 ++++++--\n> 1 file changed, 6 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 18f4a02cc270..d07f1a7b5ae8 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -320,10 +320,14 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n> \t\t\t/*\n> \t\t\t * Use the sensor resolution aligned to the ImgU\n> \t\t\t * output constraints.\n> +\t\t\t *\n> +\t\t\t * \\todo Give 32 pixels from the sensor frame size\n> +\t\t\t * for the IF and BDS rectangles to scale. See\n> +\t\t\t * the todo note for te same operation in validate().\n\ns/te/the/\n\nIs this a todo? Don't this change introduce the 32 pixels \"taking\"?\n\n> \t\t\t */\n> -\t\t\tsize.width = std::min(sensorResolution.width,\n> +\t\t\tsize.width = std::min(sensorResolution.width - 32,\n> \t\t\t\t\t IPU3_OUTPUT_MAX_WIDTH);\n> -\t\t\tsize.height = std::min(sensorResolution.height,\n> +\t\t\tsize.height = std::min(sensorResolution.height - 32,\n> \t\t\t\t\t IPU3_OUTPUT_MAX_HEIGHT);\n> \t\t\tsize.width &= ~IPU3_OUTPUT_WIDTH_ALIGN;\n> \t\t\tsize.height &= ~IPU3_OUTPUT_HEIGHT_ALIGN;\n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 40FCFBD790\n\tfor ;\n\tThu, 9 Jul 2020 13:42:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CB5DD612D9;\n\tThu, 9 Jul 2020 15:42:56 +0200 (CEST)","from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C59E8603AE\n\tfor ;\n\tThu, 9 Jul 2020 15:42:55 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id d17so2450216ljl.3\n\tfor ;\n\tThu, 09 Jul 2020 06:42:55 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tv20sm937368lfr.74.2020.07.09.06.42.54\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 09 Jul 2020 06:42:54 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"I9FjW/nG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=Mx1cdxs2rDmqwKNLQqMd1ni6hz5yjRYMjTzJwccquNo=;\n\tb=I9FjW/nG5QMhex0/V1g0LjBSYT3j75lKhIODS/68tToyYsmnYO/+YixLQU5B9qJ90o\n\tFiwXEBl5ot5tjkUc7oMxj0MrXfwfOCCRA1G1cY4MQg2f5QaBRNqDV5Zu9qCEG1GU4218\n\t1JWmYheCNvatoend3TX0BptHQndWJl32ncs1rUdbtJjDOmDZLYNcROIpMw5yIqAcSh1v\n\tliOHFMRf3JloczW66EtD2W3pXeC+B3oKL5ugz2Q4vZSQqdWH6zU2+JIvDvS5EYD63MdN\n\tiCJEAh/xB336sN+Wb4WQ3udu2CE5psycl6m6xBxGGWGziMNePhCQ70ekt1uUBhllRUsN\n\tasRQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=Mx1cdxs2rDmqwKNLQqMd1ni6hz5yjRYMjTzJwccquNo=;\n\tb=rWhJKDWLOymxX1qzNGhLYAz4UGYq5CyB/yLxcNx5/72Ry7xj3dzJ5AGpk0Nmufyo0R\n\t/jh7bxEqYpgcwO1j0lWO3JuBGGV4/mDhxe3mCSNaZ1s6JOqtOU28GW+t3T6LKIFKUM31\n\thLouE8SZr49OsFW6XgehvUUydRe2La++Z2h69zAKhrbpMgk0X/cqhyjWlvE6Z8m0nkGK\n\tpEW7mYYusdYAc2emoWtFmW9PYuk4S/wmtT+rxh8F9jP+wvF74YHGzZzeMLxbhWT3zvu9\n\tAOLQ+VCVU2cOAGmdeKilKypiu2k6xnAwzGnvsg4couwH1ln/kQ6xpJD0Hg0REvDblwno\n\t0HWQ==","X-Gm-Message-State":"AOAM5323hY2B9DO+DxLpx9yvttpaKqQ2Jv0a7A2zmAbzYBjLUQIOhoKF\n\tdcZfTmgR4dJLBvS6mq3RIRxSdQ==","X-Google-Smtp-Source":"ABdhPJy0wAaw4iO/cXsWs5RGBZgaFVy9ygDSR6XCgFMAAAY2Y+J6WrYrricC6eOQMg3JyV0tRBQITQ==","X-Received":"by 2002:a2e:3202:: with SMTP id\n\ty2mr36212301ljy.465.1594302175141; \n\tThu, 09 Jul 2020 06:42:55 -0700 (PDT)","Date":"Thu, 9 Jul 2020 15:42:54 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200709134254.GN3875643@oden.dyn.berto.se>","References":"<20200709084128.5316-1-jacopo@jmondi.org>\n\t<20200709084128.5316-12-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200709084128.5316-12-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 11/20] libcamera: ipu3: Adjust full\n\tframe picture to 32 pixels","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11308,"web_url":"https://patchwork.libcamera.org/comment/11308/","msgid":"<20200710071516.hkvhqzda3idvsnio@uno.localdomain>","date":"2020-07-10T07:15:16","subject":"Re: [libcamera-devel] [PATCH v2 11/20] libcamera: ipu3: Adjust full\n\tframe picture to 32 pixels","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Thu, Jul 09, 2020 at 03:42:54PM +0200, Niklas Söderlund wrote:\n> Hi Jacopo,\n>\n> Thanks for your work.\n>\n> On 2020-07-09 10:41:19 +0200, Jacopo Mondi wrote:\n> > To respect the same constraint introduced in validate() that the maximum\n> > ImgU output size shall be at least 32 pixels smaller than the full frame\n> > size, adjust the sizes assigned to the StillCapture role in\n> > generateConfiguration().\n> >\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/libcamera/pipeline/ipu3/ipu3.cpp | 8 ++++++--\n> > 1 file changed, 6 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > index 18f4a02cc270..d07f1a7b5ae8 100644\n> > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > @@ -320,10 +320,14 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n> > \t\t\t/*\n> > \t\t\t * Use the sensor resolution aligned to the ImgU\n> > \t\t\t * output constraints.\n> > +\t\t\t *\n> > +\t\t\t * \\todo Give 32 pixels from the sensor frame size\n> > +\t\t\t * for the IF and BDS rectangles to scale. See\n> > +\t\t\t * the todo note for te same operation in validate().\n>\n> s/te/the/\n>\n> Is this a todo? Don't this change introduce the 32 pixels \"taking\"?\n>\n\nI would have used a FIXME, but I wanted this collected by Doxygen, as\nwe used \\todo to mark this kind of items, right ?\n\n> > \t\t\t */\n> > -\t\t\tsize.width = std::min(sensorResolution.width,\n> > +\t\t\tsize.width = std::min(sensorResolution.width - 32,\n> > \t\t\t\t\t IPU3_OUTPUT_MAX_WIDTH);\n> > -\t\t\tsize.height = std::min(sensorResolution.height,\n> > +\t\t\tsize.height = std::min(sensorResolution.height - 32,\n> > \t\t\t\t\t IPU3_OUTPUT_MAX_HEIGHT);\n> > \t\t\tsize.width &= ~IPU3_OUTPUT_WIDTH_ALIGN;\n> > \t\t\tsize.height &= ~IPU3_OUTPUT_HEIGHT_ALIGN;\n> > --\n> > 2.27.0\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards,\n> Niklas Söderlund","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C07FCBD792\n\tfor ;\n\tFri, 10 Jul 2020 07:11:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9747F613A9;\n\tFri, 10 Jul 2020 09:11:44 +0200 (CEST)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6213661167\n\tfor ;\n\tFri, 10 Jul 2020 09:11:43 +0200 (CEST)","from uno.localdomain (host-95-245-128-189.retail.telecomitalia.it\n\t[95.245.128.189]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id A47381BF213;\n\tFri, 10 Jul 2020 07:11:42 +0000 (UTC)"],"X-Originating-IP":"95.245.128.189","Date":"Fri, 10 Jul 2020 09:15:16 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200710071516.hkvhqzda3idvsnio@uno.localdomain>","References":"<20200709084128.5316-1-jacopo@jmondi.org>\n\t<20200709084128.5316-12-jacopo@jmondi.org>\n\t<20200709134254.GN3875643@oden.dyn.berto.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200709134254.GN3875643@oden.dyn.berto.se>","Subject":"Re: [libcamera-devel] [PATCH v2 11/20] libcamera: ipu3: Adjust full\n\tframe picture to 32 pixels","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11321,"web_url":"https://patchwork.libcamera.org/comment/11321/","msgid":"<20200710114920.GK5964@pendragon.ideasonboard.com>","date":"2020-07-10T11:49:20","subject":"Re: [libcamera-devel] [PATCH v2 11/20] libcamera: ipu3: Adjust full\n\tframe picture to 32 pixels","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Fri, Jul 10, 2020 at 09:15:16AM +0200, Jacopo Mondi wrote:\n> On Thu, Jul 09, 2020 at 03:42:54PM +0200, Niklas Söderlund wrote:\n> > On 2020-07-09 10:41:19 +0200, Jacopo Mondi wrote:\n> > > To respect the same constraint introduced in validate() that the maximum\n> > > ImgU output size shall be at least 32 pixels smaller than the full frame\n> > > size, adjust the sizes assigned to the StillCapture role in\n> > > generateConfiguration().\n> > >\n> > > Signed-off-by: Jacopo Mondi \n> > > ---\n> > > src/libcamera/pipeline/ipu3/ipu3.cpp | 8 ++++++--\n> > > 1 file changed, 6 insertions(+), 2 deletions(-)\n> > >\n> > > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > > index 18f4a02cc270..d07f1a7b5ae8 100644\n> > > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > > @@ -320,10 +320,14 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n> > > \t\t\t/*\n> > > \t\t\t * Use the sensor resolution aligned to the ImgU\n> > > \t\t\t * output constraints.\n> > > +\t\t\t *\n> > > +\t\t\t * \\todo Give 32 pixels from the sensor frame size\n> > > +\t\t\t * for the IF and BDS rectangles to scale. See\n> > > +\t\t\t * the todo note for te same operation in validate().\n> >\n> > s/te/the/\n> >\n> > Is this a todo? Don't this change introduce the 32 pixels \"taking\"?\n> \n> I would have used a FIXME, but I wanted this collected by Doxygen, as\n> we used \\todo to mark this kind of items, right ?\n\nMaybe\n\n\t\t\t * Give 32 pixels from the sensor frame size for the IF\n\t\t\t * and BDS rectangles to scale.\n\t\t\t *\n\t\t\t * \\todo This suffers from the same issue as described\n\t\t\t * in validate().\n\n\nReviewed-by: Laurent Pinchart \n\n> > > \t\t\t */\n> > > -\t\t\tsize.width = std::min(sensorResolution.width,\n> > > +\t\t\tsize.width = std::min(sensorResolution.width - 32,\n> > > \t\t\t\t\t IPU3_OUTPUT_MAX_WIDTH);\n> > > -\t\t\tsize.height = std::min(sensorResolution.height,\n> > > +\t\t\tsize.height = std::min(sensorResolution.height - 32,\n> > > \t\t\t\t\t IPU3_OUTPUT_MAX_HEIGHT);\n> > > \t\t\tsize.width &= ~IPU3_OUTPUT_WIDTH_ALIGN;\n> > > \t\t\tsize.height &= ~IPU3_OUTPUT_HEIGHT_ALIGN;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9424ABD790\n\tfor ;\n\tFri, 10 Jul 2020 11:49:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 053E8613BD;\n\tFri, 10 Jul 2020 13:49:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E45656118A\n\tfor ;\n\tFri, 10 Jul 2020 13:49:26 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 62F842C0;\n\tFri, 10 Jul 2020 13:49:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gPio/7ZP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594381766;\n\tbh=Lg2gm5H5Qvw9yqPRjpNFn4yyFRTxbE8TnQT17NNl3Eo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gPio/7ZPybbR3/2CmT+BI4LsV2qX1B9SYJJiY3L30xXsB20xL0i5w76FdyIqUZhKN\n\te4+5eBtHQxdnVW2LfeGMOrNQbgZMsPAw6Yf8lh6y26KI24oQsgtd+0lo1BdPDdcGZI\n\t6zMGb2iaHizVHyQiz754oROdRbeefWmGV1hZKREk=","Date":"Fri, 10 Jul 2020 14:49:20 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20200710114920.GK5964@pendragon.ideasonboard.com>","References":"<20200709084128.5316-1-jacopo@jmondi.org>\n\t<20200709084128.5316-12-jacopo@jmondi.org>\n\t<20200709134254.GN3875643@oden.dyn.berto.se>\n\t<20200710071516.hkvhqzda3idvsnio@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200710071516.hkvhqzda3idvsnio@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH v2 11/20] libcamera: ipu3: Adjust full\n\tframe picture to 32 pixels","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]