[{"id":11282,"web_url":"https://patchwork.libcamera.org/comment/11282/","msgid":"<20200709131650.GJ3875643@oden.dyn.berto.se>","date":"2020-07-09T13:16:50","subject":"Re: [libcamera-devel] [PATCH v2 07/20] libcamera: ipu3: Remove\n\tinitialization of Size","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-07-09 10:41:15 +0200, Jacopo Mondi wrote:\n> The Size struct constructor defaults the width and height to 0.\n> Remove the empty braced-list initialization as it is not required.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index d27acb405a1d..05e10ebb1a7d 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -245,7 +245,7 @@ CameraConfiguration::Status IPU3CameraConfiguration::validate()\n> \t * only. If no resolution is requested for any stream, or if no sensor\n> \t * resolution is large enough, pick the largest one.\n> \t */\n> -\tSize size = {};\n> +\tSize size;\n> \n> \tfor (const StreamConfiguration &cfg : config_) {\n> \t\tif (cfg.size.width > size.width)\n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12FDBBD790\n\tfor ;\n\tThu, 9 Jul 2020 13:16:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A1E14611B2;\n\tThu, 9 Jul 2020 15:16:53 +0200 (CEST)","from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7172161184\n\tfor ;\n\tThu, 9 Jul 2020 15:16:52 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id j11so2333042ljo.7\n\tfor ;\n\tThu, 09 Jul 2020 06:16:52 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id m9sm928050lfb.5.2020.07.09.06.16.51\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 09 Jul 2020 06:16:51 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"jH8TRwAn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=BpOGNz1B7l5fTwMXfyT0Mbpk3UfRfYY0qZMT5tnKCgE=;\n\tb=jH8TRwAnnd0zSzqE9+sEpmXC0w96dxu02v751E/emEQGgqKHDfSW0BLVo2R2SCkulR\n\tLyukZ0nDVWM3v8dlaLQluILggxnRXEe8c/biAtfnFw4es1MIMZQ3LRDdXz87Ym3kTrV4\n\tFAIVszzVTKqRjuqQ6xvyxXb6gdkcCpZCv6RFs7vEkysK3D3aKY87PH76gBJwYogczOx/\n\tRdkKZHNhW0snDzcaSp3qifR7b3VkL/cHZT8zSAB31ZRDtIbXbLrHEyaKrnDc1kHFt2cG\n\t1+0aX96twze0uzcVdKeBAldhLbykhY8ZOa/d9lzYbK2Y0yEAy3k1nKVsbvMaNAoMIFt5\n\t8wJQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=BpOGNz1B7l5fTwMXfyT0Mbpk3UfRfYY0qZMT5tnKCgE=;\n\tb=NajQpTbQHvkDYJ1qex59rjFXYs7dOqELqtrl8Afxo5Gkco1vSOij+YCgHXpnGcM8y2\n\t76/lrWmhpzDff7ZvU317i/EMpzCqtIsatu8dQdHNh5zAr1mSrHc5REx/RSR/eUWPmHMr\n\tyvfCDUvW2Hnv5vMGysef72lkO9sGHKpAZY6nc2nEZxMKi4+dCN5uC+aE6vM2uRrTMzvL\n\tokXq3yWt0+eLDeNpTQiHqgDsqKJqVAApxWS1Duu34BZxlrrByC3wqTZcdiQpLtUY4Q+b\n\t++3KiigoMj6+1M6gBboH48aVE2pQnyDSy/yT4gwIkP909Jw/+csymaQihGhmUKgdxw8/\n\to4ow==","X-Gm-Message-State":"AOAM530lMrnfquf1GKlQoIyXISdaB1FVyq5nmZfP3B2YI9CHVqCKSIko\n\t1bTjFID+/RdGFuGzZLw0U+SW2Q==","X-Google-Smtp-Source":"ABdhPJya+aYLE/KC5KvkI3oA3gkUPKzoR5VGfDkXmDk4F9QSEbLT9o7ZQCDIb+DatMuHseN+vQY+Ow==","X-Received":"by 2002:a2e:7f06:: with SMTP id\n\ta6mr27969943ljd.446.1594300611824; \n\tThu, 09 Jul 2020 06:16:51 -0700 (PDT)","Date":"Thu, 9 Jul 2020 15:16:50 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200709131650.GJ3875643@oden.dyn.berto.se>","References":"<20200709084128.5316-1-jacopo@jmondi.org>\n\t<20200709084128.5316-8-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200709084128.5316-8-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 07/20] libcamera: ipu3: Remove\n\tinitialization of Size","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11314,"web_url":"https://patchwork.libcamera.org/comment/11314/","msgid":"<20200710083645.GE5964@pendragon.ideasonboard.com>","date":"2020-07-10T08:36:45","subject":"Re: [libcamera-devel] [PATCH v2 07/20] libcamera: ipu3: Remove\n\tinitialization of Size","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Thu, Jul 09, 2020 at 10:41:15AM +0200, Jacopo Mondi wrote:\n> The Size struct constructor defaults the width and height to 0.\n> Remove the empty braced-list initialization as it is not required.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index d27acb405a1d..05e10ebb1a7d 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -245,7 +245,7 @@ CameraConfiguration::Status IPU3CameraConfiguration::validate()\n> \t * only. If no resolution is requested for any stream, or if no sensor\n> \t * resolution is large enough, pick the largest one.\n> \t */\n> -\tSize size = {};\n> +\tSize size;\n> \n> \tfor (const StreamConfiguration &cfg : config_) {\n> \t\tif (cfg.size.width > size.width)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ECD8ABD792\n\tfor ;\n\tFri, 10 Jul 2020 08:36:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 785AB613B3;\n\tFri, 10 Jul 2020 10:36:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 10F5761396\n\tfor ;\n\tFri, 10 Jul 2020 10:36:52 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 58AA22C0;\n\tFri, 10 Jul 2020 10:36:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Wmfspc9J\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594370211;\n\tbh=WvSoYyIw13FxqPb6TpTiNRaP9bWj0NFnG4oJciGb6VU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Wmfspc9JDg1zIkQ7lERrNHMtcCePCvqywDiMSfx8KLecJkvSany8hQTKowz4bm0LD\n\tILbn8KDbOmrqQkcpAejj9vAjAU8dqF8drU2XRhCgnRJxH5tTC8DAulypxffywwYK6H\n\t/ZacF/CibJ36AsLIPpG4VQQlj+t2nsSeQNurDQmI=","Date":"Fri, 10 Jul 2020 11:36:45 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20200710083645.GE5964@pendragon.ideasonboard.com>","References":"<20200709084128.5316-1-jacopo@jmondi.org>\n\t<20200709084128.5316-8-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200709084128.5316-8-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 07/20] libcamera: ipu3: Remove\n\tinitialization of Size","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]