[{"id":11313,"web_url":"https://patchwork.libcamera.org/comment/11313/","msgid":"<20200710083430.GD5964@pendragon.ideasonboard.com>","date":"2020-07-10T08:34:30","subject":"Re: [libcamera-devel] [PATCH v2 05/20] libcamera: ipu3: Do not\n\toverwrite StreamConfiguration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Thu, Jul 09, 2020 at 10:41:13AM +0200, Jacopo Mondi wrote:\n> The validate function overwrites the generated StreamConfiguration with\n> the one reported by the CIO2 unit when inspecting the RAW stream\n> configuration.\n> \n> As we prepare to add StreamFormats to the IPU3 StreamConfiguration,\n> assigning to the CIO2 generated configuration would delete the\n> StreamFormats.\n> \n> Fix this by updating relevant fields only in order to keep the\n> assigned StreamFormats.\n> \n> Reviewed-by: Niklas Söderlund \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\nThe fact that it's too easy to make this mistake calls for a better API,\nbut that's not for this patch series.\n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index e62a5d5b3517..978a6e58c72f 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -269,7 +269,9 @@ CameraConfiguration::Status IPU3CameraConfiguration::validate()\n> \t\tconst Stream *stream = streams_[i];\n> \n> \t\tif (stream == &data_->rawStream_) {\n> -\t\t\tcfg = cio2Configuration_;\n> +\t\t\tcfg.size = cio2Configuration_.size;\n> +\t\t\tcfg.pixelFormat = cio2Configuration_.pixelFormat;\n> +\t\t\tcfg.bufferCount = cio2Configuration_.bufferCount;\n> \t\t} else {\n> \t\t\tbool scale = stream == &data_->vfStream_;\n> \t\t\tadjustStream(config_[i], scale);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 57AFCBD790\n\tfor ;\n\tFri, 10 Jul 2020 08:34:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DAFE9613B3;\n\tFri, 10 Jul 2020 10:34:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4431E61396\n\tfor ;\n\tFri, 10 Jul 2020 10:34:37 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B1F602C0;\n\tFri, 10 Jul 2020 10:34:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OTM+3UJ2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594370076;\n\tbh=UNZ500zSZnLAMjenmhcc9Gf+UHCF9noMAHrvrCO2nIs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OTM+3UJ2T5Vl8V5vl7EZalSLqpivd0Hk051DXuB4Ux4gMqphfzW/5DPvFPHtxgh+a\n\tQUlpY56COb647f9MN3rINqUtmmfqK6NY6VkWyWrQKrKrhPqv6CUNTtYfuWKw2p4Nwc\n\tqrraQv+uCJVA1zBTApWWZyJLoRWyfwxxFt9s/g1E=","Date":"Fri, 10 Jul 2020 11:34:30 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20200710083430.GD5964@pendragon.ideasonboard.com>","References":"<20200709084128.5316-1-jacopo@jmondi.org>\n\t<20200709084128.5316-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200709084128.5316-6-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 05/20] libcamera: ipu3: Do not\n\toverwrite StreamConfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]