[{"id":11280,"web_url":"https://patchwork.libcamera.org/comment/11280/","msgid":"<20200709130250.GH3875643@oden.dyn.berto.se>","date":"2020-07-09T13:02:50","subject":"Re: [libcamera-devel] [PATCH v2 03/20] libcamera: ipu3: Make sure\n\tthe config is valid","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your patch.\n\nOn 2020-07-09 10:41:11 +0200, Jacopo Mondi wrote:\n> Inspect the return status of validate() in the IPU3 pipeline handler\n> generateConfigurtion() implementation. If the generated configuration is\n> not valid, return a an empty configuration to the application.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 85d21b4db046..e62a5d5b3517 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -357,7 +357,8 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n> \t\tconfig->addConfiguration(cfg);\n> \t}\n> \n> -\tconfig->validate();\n> +\tif (CameraConfiguration::Invalid == config->validate())\n\nnit: This style where the value comes first in an if-statement does not \nseem to match the rest of the file.\n\nReviewed-by: Niklas Söderlund \n\n> +\t\treturn {};\n> \n> \treturn config;\n> }\n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6357CBD790\n\tfor ;\n\tThu, 9 Jul 2020 13:02:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EE31E611B2;\n\tThu, 9 Jul 2020 15:02:53 +0200 (CEST)","from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 65EF961020\n\tfor ;\n\tThu, 9 Jul 2020 15:02:52 +0200 (CEST)","by mail-lf1-x141.google.com with SMTP id g2so1105609lfb.0\n\tfor ;\n\tThu, 09 Jul 2020 06:02:52 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id m9sm914855lfb.5.2020.07.09.06.02.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 09 Jul 2020 06:02:50 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"FSr6P0S6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=8Dd7ZQVSAZHKuor+iJ+YX6abP70Cdz9Oj6WDhIYhun4=;\n\tb=FSr6P0S6U/wg09C3w5w0u3Dc/GZNBfwvk4kfWoT4uq+hkvs/oSO2+fgPgIMP+6BFi6\n\tQERlor9l5KtnwHz0kFWYcDbuDiLTCVHqIYEBlwIanTdpZXf8yS/Hh5ZPkh3u9O3dJbuv\n\tduWSxPcPhlRCHHcXDr5jBRTTafTCRd89Rr0ED+0geouIKOdBpdnhtKiaYULrgB1qnPLn\n\tQguQTmckcXV57D6q6+t/7L0Poe9JRMrfx5NqFD2knUOipSgtPWAjgD0rP63lJRbJOCNq\n\tLvIrjpbiL0d6VVW8VL3d6PLZ6i1qUuFoZA9eyYb8zFziQLyM5zLbu9CfZ6A+3JleBfHt\n\tzlOQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=8Dd7ZQVSAZHKuor+iJ+YX6abP70Cdz9Oj6WDhIYhun4=;\n\tb=kWqdEKtGy5DlrRmll/zitXwGOCc1dHIbPtJ+miKBa/+vplUQo8SH06QKNHYiBlsbRv\n\thBJwbIWuHWgP1G04+K1dbrOLRYy/sBHkf8i7MbMrU+zr3KLsnjBfPnTKSQdW2YzqgOxr\n\t8ecQELafoCMl7qLYH5TepUH4Kdewgw3dUrNU1mTTvwAEeU1ePXa6jW6yFXFDi3nDq5pT\n\tSablRipGg8+5Igee13et8CtjCSLkpWkeSeHiywPj3BvHq6Fl8HuDmgyKqIoTtbZuFdJV\n\toreur37xCgUmp/JVrpGQ/LBxX61tcTAjP99EeHh0GZLtn3oXnrWCimqAkNPFN5m8n7Bp\n\tsQdw==","X-Gm-Message-State":"AOAM5325GAX5IgtNas1j1zs1+AncpPOySCbWsM7MZxartguCQ7yHhCk0\n\tEXQewqN7ZlP7atMyb8Do42+ApgGa2ug=","X-Google-Smtp-Source":"ABdhPJw0gQBaOmDVyqx413Er1RumiAuQp/A4glLGk9nmNm/i7dmxFWGolfjhRUk/+dWEHfxg+HFpTQ==","X-Received":"by 2002:ac2:569c:: with SMTP id\n\t28mr39294646lfr.195.1594299771717; \n\tThu, 09 Jul 2020 06:02:51 -0700 (PDT)","Date":"Thu, 9 Jul 2020 15:02:50 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200709130250.GH3875643@oden.dyn.berto.se>","References":"<20200709084128.5316-1-jacopo@jmondi.org>\n\t<20200709084128.5316-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200709084128.5316-4-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 03/20] libcamera: ipu3: Make sure\n\tthe config is valid","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11303,"web_url":"https://patchwork.libcamera.org/comment/11303/","msgid":"<20200710065945.k6lukpuobk2mboux@uno.localdomain>","date":"2020-07-10T06:59:45","subject":"Re: [libcamera-devel] [PATCH v2 03/20] libcamera: ipu3: Make sure\n\tthe config is valid","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Thu, Jul 09, 2020 at 03:02:50PM +0200, Niklas Söderlund wrote:\n> Hi Jacopo,\n>\n> Thanks for your patch.\n>\n> On 2020-07-09 10:41:11 +0200, Jacopo Mondi wrote:\n> > Inspect the return status of validate() in the IPU3 pipeline handler\n> > generateConfigurtion() implementation. If the generated configuration is\n> > not valid, return a an empty configuration to the application.\n> >\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/libcamera/pipeline/ipu3/ipu3.cpp | 3 ++-\n> > 1 file changed, 2 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > index 85d21b4db046..e62a5d5b3517 100644\n> > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > @@ -357,7 +357,8 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n> > \t\tconfig->addConfiguration(cfg);\n> > \t}\n> >\n> > -\tconfig->validate();\n> > +\tif (CameraConfiguration::Invalid == config->validate())\n>\n> nit: This style where the value comes first in an if-statement does not\n> seem to match the rest of the file.\n\nNot sure why, but this looked nicer to me, but I can change it back.\n\nThanks\n j\n\n>\n> Reviewed-by: Niklas Söderlund \n>\n> > +\t\treturn {};\n> >\n> > \treturn config;\n> > }\n> > --\n> > 2.27.0\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards,\n> Niklas Söderlund","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4BD64BD790\n\tfor ;\n\tFri, 10 Jul 2020 06:56:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 28E0E61396;\n\tFri, 10 Jul 2020 08:56:13 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0599661214\n\tfor ;\n\tFri, 10 Jul 2020 08:56:12 +0200 (CEST)","from uno.localdomain (host-95-245-128-189.retail.telecomitalia.it\n\t[95.245.128.189]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 3BD8EE0007;\n\tFri, 10 Jul 2020 06:56:10 +0000 (UTC)"],"X-Originating-IP":"95.245.128.189","Date":"Fri, 10 Jul 2020 08:59:45 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200710065945.k6lukpuobk2mboux@uno.localdomain>","References":"<20200709084128.5316-1-jacopo@jmondi.org>\n\t<20200709084128.5316-4-jacopo@jmondi.org>\n\t<20200709130250.GH3875643@oden.dyn.berto.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200709130250.GH3875643@oden.dyn.berto.se>","Subject":"Re: [libcamera-devel] [PATCH v2 03/20] libcamera: ipu3: Make sure\n\tthe config is valid","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11312,"web_url":"https://patchwork.libcamera.org/comment/11312/","msgid":"<20200710082949.GC5964@pendragon.ideasonboard.com>","date":"2020-07-10T08:29:49","subject":"Re: [libcamera-devel] [PATCH v2 03/20] libcamera: ipu3: Make sure\n\tthe config is valid","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Fri, Jul 10, 2020 at 08:59:45AM +0200, Jacopo Mondi wrote:\n> On Thu, Jul 09, 2020 at 03:02:50PM +0200, Niklas Söderlund wrote:\n> > On 2020-07-09 10:41:11 +0200, Jacopo Mondi wrote:\n> > > Inspect the return status of validate() in the IPU3 pipeline handler\n> > > generateConfigurtion() implementation. If the generated configuration is\n\ns/generateConfigurtion/generateConfiguration/\n\n> > > not valid, return a an empty configuration to the application.\n\ns/a an/an/\n\n> > >\n> > > Signed-off-by: Jacopo Mondi \n> > > ---\n> > > src/libcamera/pipeline/ipu3/ipu3.cpp | 3 ++-\n> > > 1 file changed, 2 insertions(+), 1 deletion(-)\n> > >\n> > > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > > index 85d21b4db046..e62a5d5b3517 100644\n> > > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > > @@ -357,7 +357,8 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n> > > \t\tconfig->addConfiguration(cfg);\n> > > \t}\n> > >\n> > > -\tconfig->validate();\n> > > +\tif (CameraConfiguration::Invalid == config->validate())\n> >\n> > nit: This style where the value comes first in an if-statement does not\n> > seem to match the rest of the file.\n> \n> Not sure why, but this looked nicer to me, but I can change it back.\n\nI agree with Niklas, we usually do it the other way around.\n\nReviewed-by: Laurent Pinchart \n\n> > Reviewed-by: Niklas Söderlund \n> >\n> > > +\t\treturn {};\n> > >\n> > > \treturn config;\n> > > }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 99674BD792\n\tfor ;\n\tFri, 10 Jul 2020 08:29:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 30ED5613B3;\n\tFri, 10 Jul 2020 10:29:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F6E761396\n\tfor ;\n\tFri, 10 Jul 2020 10:29:56 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BC44D2C0;\n\tFri, 10 Jul 2020 10:29:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HbTNZ2IW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594369795;\n\tbh=3jOZBqV9iwACkiIWtT0yKmWT4oDzgRA+RccMOSEVV+Q=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HbTNZ2IWZokJj6R/me3Yp0LerYl0MSVDWlHB+uSaAdvq3aaXiJ9KQpT7W3Jff8xpe\n\tTVyJVB1GbM/Z2iQFXy9atrnzUtqR7iCBWcUJznl31X3r3tXqWV5HLyN1Q8GGiXCuub\n\tbACIpiHWmdWN1uY8YN7quqlJ4QVeTD7yPpFnAazM=","Date":"Fri, 10 Jul 2020 11:29:49 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20200710082949.GC5964@pendragon.ideasonboard.com>","References":"<20200709084128.5316-1-jacopo@jmondi.org>\n\t<20200709084128.5316-4-jacopo@jmondi.org>\n\t<20200709130250.GH3875643@oden.dyn.berto.se>\n\t<20200710065945.k6lukpuobk2mboux@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200710065945.k6lukpuobk2mboux@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH v2 03/20] libcamera: ipu3: Make sure\n\tthe config is valid","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]