[{"id":11254,"web_url":"https://patchwork.libcamera.org/comment/11254/","msgid":"<20200708153211.GK20298@pendragon.ideasonboard.com>","date":"2020-07-08T15:32:11","subject":"Re: [libcamera-devel] [PATCH v4 21/21] v4l2: v4l2_camera: Fix\n\tstream selection for buffer operations","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Jul 08, 2020 at 10:44:17PM +0900, Paul Elder wrote:\n> The buffer operations in V4L2Camera were getting the stream from the\n> wrong place. Fix it.\n> \n> Signed-off-by: Paul Elder \n\nGood catch.\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> New in v4\n> ---\n> src/v4l2/v4l2_camera.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp\n> index 9f81c97..61bca07 100644\n> --- a/src/v4l2/v4l2_camera.cpp\n> +++ b/src/v4l2/v4l2_camera.cpp\n> @@ -160,7 +160,7 @@ int V4L2Camera::validateConfiguration(const PixelFormat &pixelFormat,\n> \n> int V4L2Camera::allocBuffers(unsigned int count)\n> {\n> -\tStream *stream = *camera_->streams().begin();\n> +\tStream *stream = config_->at(0).stream();\n> \n> \treturn bufferAllocator_->allocate(stream);\n> }\n> @@ -169,13 +169,13 @@ void V4L2Camera::freeBuffers()\n> {\n> \tpendingRequests_.clear();\n> \n> -\tStream *stream = *camera_->streams().begin();\n> +\tStream *stream = config_->at(0).stream();\n> \tbufferAllocator_->free(stream);\n> }\n> \n> FileDescriptor V4L2Camera::getBufferFd(unsigned int index)\n> {\n> -\tStream *stream = *camera_->streams().begin();\n> +\tStream *stream = config_->at(0).stream();\n> \tconst std::vector> &buffers =\n> \t\tbufferAllocator_->buffers(stream);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E98CBD790\n\tfor ;\n\tWed, 8 Jul 2020 15:32:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1BFCA6115B;\n\tWed, 8 Jul 2020 17:32:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E7506113A\n\tfor ;\n\tWed, 8 Jul 2020 17:32:19 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5F18E543;\n\tWed, 8 Jul 2020 17:32:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mxRRIUBG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594222338;\n\tbh=KPfw8tYlRlzLJOOQz+MuC6Zi5gnOxAzJcKT+MWxeUu4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mxRRIUBGRnZU/VCrd5P5qiIlKOrigA7XUmI6gFH6/GpF2uW1HlzsjTvDpobv6Kol/\n\to31TKGZmm4pbP9rKL4p8TIsrq3cQtDeIQIs6dw3IBimL6rugyS2WODz3kxPGrB0Ulr\n\tMpKIS+Ayo/eo1mMfGyjGDehhjg3fa//WzxsweAnE=","Date":"Wed, 8 Jul 2020 18:32:11 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"<20200708153211.GK20298@pendragon.ideasonboard.com>","References":"<20200708134417.67747-1-paul.elder@ideasonboard.com>\n\t<20200708134417.67747-22-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200708134417.67747-22-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 21/21] v4l2: v4l2_camera: Fix\n\tstream selection for buffer operations","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11270,"web_url":"https://patchwork.libcamera.org/comment/11270/","msgid":"<20200708214428.l3rwvcn3yz2ijpax@uno.localdomain>","date":"2020-07-08T21:44:28","subject":"Re: [libcamera-devel] [PATCH v4 21/21] v4l2: v4l2_camera: Fix\n\tstream selection for buffer operations","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Wed, Jul 08, 2020 at 10:44:17PM +0900, Paul Elder wrote:\n> The buffer operations in V4L2Camera were getting the stream from the\n> wrong place. Fix it.\n\nI wonder what is the use case for applications to get the stream list,\ninstead of going through the configuration. As this patch shows, that\npart of the API is slippery...\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> Signed-off-by: Paul Elder \n>\n> ---\n> New in v4\n> ---\n> src/v4l2/v4l2_camera.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp\n> index 9f81c97..61bca07 100644\n> --- a/src/v4l2/v4l2_camera.cpp\n> +++ b/src/v4l2/v4l2_camera.cpp\n> @@ -160,7 +160,7 @@ int V4L2Camera::validateConfiguration(const PixelFormat &pixelFormat,\n>\n> int V4L2Camera::allocBuffers(unsigned int count)\n> {\n> -\tStream *stream = *camera_->streams().begin();\n> +\tStream *stream = config_->at(0).stream();\n>\n> \treturn bufferAllocator_->allocate(stream);\n> }\n> @@ -169,13 +169,13 @@ void V4L2Camera::freeBuffers()\n> {\n> \tpendingRequests_.clear();\n>\n> -\tStream *stream = *camera_->streams().begin();\n> +\tStream *stream = config_->at(0).stream();\n> \tbufferAllocator_->free(stream);\n> }\n>\n> FileDescriptor V4L2Camera::getBufferFd(unsigned int index)\n> {\n> -\tStream *stream = *camera_->streams().begin();\n> +\tStream *stream = config_->at(0).stream();\n> \tconst std::vector> &buffers =\n> \t\tbufferAllocator_->buffers(stream);\n>\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 671DABD792\n\tfor ;\n\tWed, 8 Jul 2020 21:40:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 10A1861178;\n\tWed, 8 Jul 2020 23:40:56 +0200 (CEST)","from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D925961163\n\tfor ;\n\tWed, 8 Jul 2020 23:40:54 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 46DE6FF807;\n\tWed, 8 Jul 2020 21:40:54 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Wed, 8 Jul 2020 23:44:28 +0200","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20200708214428.l3rwvcn3yz2ijpax@uno.localdomain>","References":"<20200708134417.67747-1-paul.elder@ideasonboard.com>\n\t<20200708134417.67747-22-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200708134417.67747-22-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 21/21] v4l2: v4l2_camera: Fix\n\tstream selection for buffer operations","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]