{"id":8690,"url":"https://patchwork.libcamera.org/api/patches/8690/?format=json","web_url":"https://patchwork.libcamera.org/patch/8690/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200708134417.67747-22-paul.elder@ideasonboard.com>","date":"2020-07-08T13:44:17","name":"[libcamera-devel,v4,21/21] v4l2: v4l2_camera: Fix stream selection for buffer operations","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4a74addb7dd462db9d80d4a8c9b12147fda925e6","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8690/mbox/","series":[{"id":1090,"url":"https://patchwork.libcamera.org/api/series/1090/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1090","date":"2020-07-08T13:43:56","name":"Clean up formats in v4l2-compat and pipeline handlers","version":4,"mbox":"https://patchwork.libcamera.org/series/1090/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8690/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8690/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB4E0BD792\n\tfor ;\n\tWed, 8 Jul 2020 13:45:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A92246114B;\n\tWed, 8 Jul 2020 15:45:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F9BD6112A\n\tfor ;\n\tWed, 8 Jul 2020 15:45:14 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C26E451B;\n\tWed, 8 Jul 2020 15:45:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bbXoQ940\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594215914;\n\tbh=Y76cWm3jS1CcVT5hmHf3EU49LfWYrefHwqbT9EFavXE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=bbXoQ940NX/2XLO4c6GVLsACrp6s/otVVxEGK9QJzvkyz2cl0TmwFAn4fpfCNyjG4\n\toS+NFCcaPduXfYy+gCzKWq3+xgTSzHNEzt0sonkh5Aq7Xa8ImHYDfeBhj4mGESAUjw\n\trhqk6zXfywKgrvMh3DU28bXfdEtXBmrvaAR3jf4M=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 8 Jul 2020 22:44:17 +0900","Message-Id":"<20200708134417.67747-22-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200708134417.67747-1-paul.elder@ideasonboard.com>","References":"<20200708134417.67747-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 21/21] v4l2: v4l2_camera: Fix stream\n\tselection for buffer operations","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The buffer operations in V4L2Camera were getting the stream from the\nwrong place. Fix it.\n\nSigned-off-by: Paul Elder \n\n---\nNew in v4\n---\n src/v4l2/v4l2_camera.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp\nindex 9f81c97..61bca07 100644\n--- a/src/v4l2/v4l2_camera.cpp\n+++ b/src/v4l2/v4l2_camera.cpp\n@@ -160,7 +160,7 @@ int V4L2Camera::validateConfiguration(const PixelFormat &pixelFormat,\n \n int V4L2Camera::allocBuffers(unsigned int count)\n {\n-\tStream *stream = *camera_->streams().begin();\n+\tStream *stream = config_->at(0).stream();\n \n \treturn bufferAllocator_->allocate(stream);\n }\n@@ -169,13 +169,13 @@ void V4L2Camera::freeBuffers()\n {\n \tpendingRequests_.clear();\n \n-\tStream *stream = *camera_->streams().begin();\n+\tStream *stream = config_->at(0).stream();\n \tbufferAllocator_->free(stream);\n }\n \n FileDescriptor V4L2Camera::getBufferFd(unsigned int index)\n {\n-\tStream *stream = *camera_->streams().begin();\n+\tStream *stream = config_->at(0).stream();\n \tconst std::vector> &buffers =\n \t\tbufferAllocator_->buffers(stream);\n \n","prefixes":["libcamera-devel","v4","21/21"]}