[{"id":11269,"web_url":"https://patchwork.libcamera.org/comment/11269/","msgid":"<20200708214126.cpc76sv76zsbrvqt@uno.localdomain>","date":"2020-07-08T21:41:26","subject":"Re: [libcamera-devel] [PATCH v4 20/21] libcamera:\n\tStreamConfiguration: Update stride documentation","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Wed, Jul 08, 2020 at 10:44:16PM +0900, Paul Elder wrote:\n> Now that all the pipeline handlers fill in the stride information at\n> validation time, update the documentation accordingly.\n>\n> Signed-off-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> ---\n> No change in v4\n>\n> New in v3\n> ---\n> src/libcamera/stream.cpp | 7 ++-----\n> 1 file changed, 2 insertions(+), 5 deletions(-)\n>\n> diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> index 6d6e279..d5da834 100644\n> --- a/src/libcamera/stream.cpp\n> +++ b/src/libcamera/stream.cpp\n> @@ -309,11 +309,8 @@ StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n> *\n> * The stride value reports the number of bytes between the beginning of\n> * successive lines in an image buffer for this stream. The value is\n> - * valid after successfully configuring the camera with this\n> - * configuration with a call to Camera::Configure().\n> - *\n> - * \\todo Update this value when configuration is validated instead of when\n> - * the camera is configured.\n> + * valid after successfully validating the configuration with a call to\n> + * CameraConfiguration::validate().\n> */\n>\n> /**\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CAB6BBD790\n\tfor ;\n\tWed, 8 Jul 2020 21:37:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A549B61178;\n\tWed, 8 Jul 2020 23:37:53 +0200 (CEST)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9933261163\n\tfor ;\n\tWed, 8 Jul 2020 23:37:52 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 105B8240004;\n\tWed, 8 Jul 2020 21:37:51 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Wed, 8 Jul 2020 23:41:26 +0200","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20200708214126.cpc76sv76zsbrvqt@uno.localdomain>","References":"<20200708134417.67747-1-paul.elder@ideasonboard.com>\n\t<20200708134417.67747-21-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200708134417.67747-21-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 20/21] libcamera:\n\tStreamConfiguration: Update stride documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]