[{"id":11253,"web_url":"https://patchwork.libcamera.org/comment/11253/","msgid":"<20200708153041.GJ20298@pendragon.ideasonboard.com>","date":"2020-07-08T15:30:41","subject":"Re: [libcamera-devel] [PATCH v4 19/21] libcamera: vimc: Fill stride\n\tand frameSize at config validation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Jul 08, 2020 at 10:44:15PM +0900, Paul Elder wrote:\n> Fill the stride and frameSize fields of the StreamConfiguration at\n> configuration validation time instead of at camera configuration time.\n> This allows applications to get the stride when trying a configuration\n> without modifying the active configuration of the camera.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> Changes in v4:\n> - mention motivation in commit message\n> - get stride and frameSize from tryFormat on capture video node\n> \n> New in v3\n> ---\n> src/libcamera/pipeline/vimc/vimc.cpp | 23 ++++++++++++++++++-----\n> 1 file changed, 18 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> index b653066..a6f457c 100644\n> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> @@ -72,9 +72,12 @@ public:\n> class VimcCameraConfiguration : public CameraConfiguration\n> {\n> public:\n> -\tVimcCameraConfiguration();\n> +\tVimcCameraConfiguration(VimcCameraData *data);\n> \n> \tStatus validate() override;\n> +\n> +private:\n> +\tVimcCameraData *data_;\n> };\n> \n> class PipelineHandlerVimc : public PipelineHandler\n> @@ -115,8 +118,8 @@ static const std::map pixelformats{\n> \n> } /* namespace */\n> \n> -VimcCameraConfiguration::VimcCameraConfiguration()\n> -\t: CameraConfiguration()\n> +VimcCameraConfiguration::VimcCameraConfiguration(VimcCameraData *data)\n> +\t: CameraConfiguration(), data_(data)\n> {\n> }\n> \n> @@ -160,6 +163,17 @@ CameraConfiguration::Status VimcCameraConfiguration::validate()\n> \n> \tcfg.bufferCount = 4;\n> \n> +\tV4L2DeviceFormat format = {};\n> +\tformat.fourcc = data_->video_->toV4L2PixelFormat(cfg.pixelFormat);\n> +\tformat.size = cfg.size;\n> +\n> +\tint ret = data_->video_->tryFormat(&format);\n> +\tif (ret)\n> +\t\treturn Invalid;\n> +\n> +\tcfg.stride = format.planes[0].bpl;\n> +\tcfg.frameSize = format.planes[0].size;\n> +\n> \treturn status;\n> }\n> \n> @@ -171,8 +185,8 @@ PipelineHandlerVimc::PipelineHandlerVimc(CameraManager *manager)\n> CameraConfiguration *PipelineHandlerVimc::generateConfiguration(Camera *camera,\n> \tconst StreamRoles &roles)\n> {\n> -\tCameraConfiguration *config = new VimcCameraConfiguration();\n> \tVimcCameraData *data = cameraData(camera);\n> +\tCameraConfiguration *config = new VimcCameraConfiguration(data);\n> \n> \tif (roles.empty())\n> \t\treturn config;\n> @@ -282,7 +296,6 @@ int PipelineHandlerVimc::configure(Camera *camera, CameraConfiguration *config)\n> \t\treturn ret;\n> \n> \tcfg.setStream(&data->stream_);\n> -\tcfg.stride = format.planes[0].bpl;\n> \n> \treturn 0;\n> }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 96BB0BD790\n\tfor ;\n\tWed, 8 Jul 2020 15:30:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 695AA61158;\n\tWed, 8 Jul 2020 17:30:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 483E1603AA\n\tfor ;\n\tWed, 8 Jul 2020 17:30:49 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 741E4543;\n\tWed, 8 Jul 2020 17:30:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"q0vXzRFF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594222249;\n\tbh=BxMngEE0ENkyHNHpzqk/C6/W1BIzrB0TF0mHVXes2tg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=q0vXzRFF/tAUANYFHLL+BRW6/cKsMg6Mu2YgdhRK79cUSm5KGsr7ivXmDM253rHX8\n\tR+vy2rfcWva7EgunUkZvYjkGKBWQwyyM31t5xD1wqQuz9Ls0fIY6dFyquZEBvrthbt\n\tYwtw/t9R5duDElzLlCW7t5IyXmgR6sMfYm+scvB4=","Date":"Wed, 8 Jul 2020 18:30:41 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"<20200708153041.GJ20298@pendragon.ideasonboard.com>","References":"<20200708134417.67747-1-paul.elder@ideasonboard.com>\n\t<20200708134417.67747-20-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200708134417.67747-20-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 19/21] libcamera: vimc: Fill stride\n\tand frameSize at config validation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11268,"web_url":"https://patchwork.libcamera.org/comment/11268/","msgid":"<20200708214057.wbxhicxynqaqr5ca@uno.localdomain>","date":"2020-07-08T21:40:57","subject":"Re: [libcamera-devel] [PATCH v4 19/21] libcamera: vimc: Fill stride\n\tand frameSize at config validation","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Wed, Jul 08, 2020 at 10:44:15PM +0900, Paul Elder wrote:\n> Fill the stride and frameSize fields of the StreamConfiguration at\n> configuration validation time instead of at camera configuration time.\n> This allows applications to get the stride when trying a configuration\n> without modifying the active configuration of the camera.\n>\n> Signed-off-by: Paul Elder \n>\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> Changes in v4:\n> - mention motivation in commit message\n> - get stride and frameSize from tryFormat on capture video node\n>\n> New in v3\n> ---\n> src/libcamera/pipeline/vimc/vimc.cpp | 23 ++++++++++++++++++-----\n> 1 file changed, 18 insertions(+), 5 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> index b653066..a6f457c 100644\n> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> @@ -72,9 +72,12 @@ public:\n> class VimcCameraConfiguration : public CameraConfiguration\n> {\n> public:\n> -\tVimcCameraConfiguration();\n> +\tVimcCameraConfiguration(VimcCameraData *data);\n>\n> \tStatus validate() override;\n> +\n> +private:\n> +\tVimcCameraData *data_;\n> };\n>\n> class PipelineHandlerVimc : public PipelineHandler\n> @@ -115,8 +118,8 @@ static const std::map pixelformats{\n>\n> } /* namespace */\n>\n> -VimcCameraConfiguration::VimcCameraConfiguration()\n> -\t: CameraConfiguration()\n> +VimcCameraConfiguration::VimcCameraConfiguration(VimcCameraData *data)\n> +\t: CameraConfiguration(), data_(data)\n> {\n> }\n>\n> @@ -160,6 +163,17 @@ CameraConfiguration::Status VimcCameraConfiguration::validate()\n>\n> \tcfg.bufferCount = 4;\n>\n> +\tV4L2DeviceFormat format = {};\n> +\tformat.fourcc = data_->video_->toV4L2PixelFormat(cfg.pixelFormat);\n> +\tformat.size = cfg.size;\n> +\n> +\tint ret = data_->video_->tryFormat(&format);\n> +\tif (ret)\n> +\t\treturn Invalid;\n> +\n> +\tcfg.stride = format.planes[0].bpl;\n> +\tcfg.frameSize = format.planes[0].size;\n> +\n> \treturn status;\n> }\n>\n> @@ -171,8 +185,8 @@ PipelineHandlerVimc::PipelineHandlerVimc(CameraManager *manager)\n> CameraConfiguration *PipelineHandlerVimc::generateConfiguration(Camera *camera,\n> \tconst StreamRoles &roles)\n> {\n> -\tCameraConfiguration *config = new VimcCameraConfiguration();\n> \tVimcCameraData *data = cameraData(camera);\n> +\tCameraConfiguration *config = new VimcCameraConfiguration(data);\n>\n> \tif (roles.empty())\n> \t\treturn config;\n> @@ -282,7 +296,6 @@ int PipelineHandlerVimc::configure(Camera *camera, CameraConfiguration *config)\n> \t\treturn ret;\n>\n> \tcfg.setStream(&data->stream_);\n> -\tcfg.stride = format.planes[0].bpl;\n>\n> \treturn 0;\n> }\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9DEB1BD790\n\tfor ;\n\tWed, 8 Jul 2020 21:37:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 79EC161167;\n\tWed, 8 Jul 2020 23:37:25 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB71D61163\n\tfor ;\n\tWed, 8 Jul 2020 23:37:23 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 676641C0002;\n\tWed, 8 Jul 2020 21:37:23 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Wed, 8 Jul 2020 23:40:57 +0200","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20200708214057.wbxhicxynqaqr5ca@uno.localdomain>","References":"<20200708134417.67747-1-paul.elder@ideasonboard.com>\n\t<20200708134417.67747-20-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200708134417.67747-20-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 19/21] libcamera: vimc: Fill stride\n\tand frameSize at config validation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]