[{"id":11252,"web_url":"https://patchwork.libcamera.org/comment/11252/","msgid":"<20200708152936.GI20298@pendragon.ideasonboard.com>","date":"2020-07-08T15:29:36","subject":"Re: [libcamera-devel] [PATCH v4 18/21] libcamera: uvcvideo: Fill\n\tstride and frameSize at config validation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Jul 08, 2020 at 10:44:14PM +0900, Paul Elder wrote:\n> Fill the stride and frameSize fields of the StreamConfiguration at\n> configuration validation time instead of at camera configuration time.\n> This allows applications to get the stride when trying a configuration\n> without modifying the active configuration of the camera.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> Changes in v4:\n> - return error if tryFormat fails\n> - pass UVCCameraData to UVCCameraConfiguration, instead of\n> V4l2VideoDevice\n> - mention motivation in commit message\n> \n> New in v3\n> ---\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 23 +++++++++++++++-----\n> 1 file changed, 18 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index 9db69dd..47f383d 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -53,9 +53,12 @@ public:\n> class UVCCameraConfiguration : public CameraConfiguration\n> {\n> public:\n> -\tUVCCameraConfiguration();\n> +\tUVCCameraConfiguration(UVCCameraData *data);\n> \n> \tStatus validate() override;\n> +\n> +private:\n> +\tUVCCameraData *data_;\n> };\n> \n> class PipelineHandlerUVC : public PipelineHandler\n> @@ -89,8 +92,8 @@ private:\n> \t}\n> };\n> \n> -UVCCameraConfiguration::UVCCameraConfiguration()\n> -\t: CameraConfiguration()\n> +UVCCameraConfiguration::UVCCameraConfiguration(UVCCameraData *data)\n> +\t: CameraConfiguration(), data_(data)\n> {\n> }\n> \n> @@ -141,6 +144,17 @@ CameraConfiguration::Status UVCCameraConfiguration::validate()\n> \n> \tcfg.bufferCount = 4;\n> \n> +\tV4L2DeviceFormat format = {};\n> +\tformat.fourcc = data_->video_->toV4L2PixelFormat(cfg.pixelFormat);\n> +\tformat.size = cfg.size;\n> +\n> +\tint ret = data_->video_->tryFormat(&format);\n> +\tif (ret)\n> +\t\treturn Invalid;\n> +\n> +\tcfg.stride = format.planes[0].bpl;\n> +\tcfg.frameSize = format.planes[0].size;\n> +\n> \treturn status;\n> }\n> \n> @@ -153,7 +167,7 @@ CameraConfiguration *PipelineHandlerUVC::generateConfiguration(Camera *camera,\n> \tconst StreamRoles &roles)\n> {\n> \tUVCCameraData *data = cameraData(camera);\n> -\tCameraConfiguration *config = new UVCCameraConfiguration();\n> +\tCameraConfiguration *config = new UVCCameraConfiguration(data);\n> \n> \tif (roles.empty())\n> \t\treturn config;\n> @@ -200,7 +214,6 @@ int PipelineHandlerUVC::configure(Camera *camera, CameraConfiguration *config)\n> \t\treturn -EINVAL;\n> \n> \tcfg.setStream(&data->stream_);\n> -\tcfg.stride = format.planes[0].bpl;\n> \n> \treturn 0;\n> }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 83C97BD792\n\tfor ;\n\tWed, 8 Jul 2020 15:29:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0033B61159;\n\tWed, 8 Jul 2020 17:29:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C3C4603AA\n\tfor ;\n\tWed, 8 Jul 2020 17:29:44 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5D141543;\n\tWed, 8 Jul 2020 17:29:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"v0Avu3Ha\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594222183;\n\tbh=Peuzl9ykIK5af02QaTu4D1CEf6McRYz3Ft4IUrZ/4UY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=v0Avu3HaGuNUvusxq0t8quw0g5u8iH5F+M9z5gyqWhUNffspqcXvyOKdBwgJm8YUQ\n\tacb4LDWDwidUzBRTV2MIePvkxfXG8PMJXcDt0pcT0yzxw0gxnbUlipCo3a4g8pGWQ7\n\tYanQL9WQTSLL/cKGluj87FDHd0w1PCVd9w1odU2g=","Date":"Wed, 8 Jul 2020 18:29:36 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"<20200708152936.GI20298@pendragon.ideasonboard.com>","References":"<20200708134417.67747-1-paul.elder@ideasonboard.com>\n\t<20200708134417.67747-19-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200708134417.67747-19-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 18/21] libcamera: uvcvideo: Fill\n\tstride and frameSize at config validation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11266,"web_url":"https://patchwork.libcamera.org/comment/11266/","msgid":"<20200708213609.wg3rylq2eeuixjtt@uno.localdomain>","date":"2020-07-08T21:36:09","subject":"Re: [libcamera-devel] [PATCH v4 18/21] libcamera: uvcvideo: Fill\n\tstride and frameSize at config validation","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Wed, Jul 08, 2020 at 10:44:14PM +0900, Paul Elder wrote:\n> Fill the stride and frameSize fields of the StreamConfiguration at\n> configuration validation time instead of at camera configuration time.\n> This allows applications to get the stride when trying a configuration\n> without modifying the active configuration of the camera.\n>\n> Signed-off-by: Paul Elder \n>\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> Changes in v4:\n> - return error if tryFormat fails\n> - pass UVCCameraData to UVCCameraConfiguration, instead of\n> V4l2VideoDevice\n> - mention motivation in commit message\n>\n> New in v3\n> ---\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 23 +++++++++++++++-----\n> 1 file changed, 18 insertions(+), 5 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index 9db69dd..47f383d 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -53,9 +53,12 @@ public:\n> class UVCCameraConfiguration : public CameraConfiguration\n> {\n> public:\n> -\tUVCCameraConfiguration();\n> +\tUVCCameraConfiguration(UVCCameraData *data);\n>\n> \tStatus validate() override;\n> +\n> +private:\n> +\tUVCCameraData *data_;\n> };\n>\n> class PipelineHandlerUVC : public PipelineHandler\n> @@ -89,8 +92,8 @@ private:\n> \t}\n> };\n>\n> -UVCCameraConfiguration::UVCCameraConfiguration()\n> -\t: CameraConfiguration()\n> +UVCCameraConfiguration::UVCCameraConfiguration(UVCCameraData *data)\n> +\t: CameraConfiguration(), data_(data)\n> {\n> }\n>\n> @@ -141,6 +144,17 @@ CameraConfiguration::Status UVCCameraConfiguration::validate()\n>\n> \tcfg.bufferCount = 4;\n>\n> +\tV4L2DeviceFormat format = {};\n> +\tformat.fourcc = data_->video_->toV4L2PixelFormat(cfg.pixelFormat);\n> +\tformat.size = cfg.size;\n> +\n> +\tint ret = data_->video_->tryFormat(&format);\n> +\tif (ret)\n> +\t\treturn Invalid;\n> +\n> +\tcfg.stride = format.planes[0].bpl;\n> +\tcfg.frameSize = format.planes[0].size;\n> +\n> \treturn status;\n> }\n>\n> @@ -153,7 +167,7 @@ CameraConfiguration *PipelineHandlerUVC::generateConfiguration(Camera *camera,\n> \tconst StreamRoles &roles)\n> {\n> \tUVCCameraData *data = cameraData(camera);\n> -\tCameraConfiguration *config = new UVCCameraConfiguration();\n> +\tCameraConfiguration *config = new UVCCameraConfiguration(data);\n>\n> \tif (roles.empty())\n> \t\treturn config;\n> @@ -200,7 +214,6 @@ int PipelineHandlerUVC::configure(Camera *camera, CameraConfiguration *config)\n> \t\treturn -EINVAL;\n>\n> \tcfg.setStream(&data->stream_);\n> -\tcfg.stride = format.planes[0].bpl;\n>\n> \treturn 0;\n> }\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B72B4BD792\n\tfor ;\n\tWed, 8 Jul 2020 21:32:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9205A6116D;\n\tWed, 8 Jul 2020 23:32:37 +0200 (CEST)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0588361163\n\tfor ;\n\tWed, 8 Jul 2020 23:32:36 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 7608D200004;\n\tWed, 8 Jul 2020 21:32:35 +0000 (UTC)"],"Date":"Wed, 8 Jul 2020 23:36:09 +0200","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20200708213609.wg3rylq2eeuixjtt@uno.localdomain>","References":"<20200708134417.67747-1-paul.elder@ideasonboard.com>\n\t<20200708134417.67747-19-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200708134417.67747-19-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 18/21] libcamera: uvcvideo: Fill\n\tstride and frameSize at config validation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]