[{"id":11248,"web_url":"https://patchwork.libcamera.org/comment/11248/","msgid":"<20200708150436.GE20298@pendragon.ideasonboard.com>","date":"2020-07-08T15:04:36","subject":"Re: [libcamera-devel] [PATCH v4 14/21] libcamera: ipu3: Fill stride\n\tand frameSize at config validation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Jul 08, 2020 at 10:44:10PM +0900, Paul Elder wrote:\n> Fill the stride and frameSize fields of the StreamConfiguration at\n> configuration validation time instead of at camera configuration time.\n> This allows applications to get the stride when trying a configuration\n> without modifying the active configuration of the camera.\n> \n> Signed-off-by: Paul Elder \n> \n> ---\n> Changes in v4:\n> - fix stride and frameSize calculation\n> - mention motivation in commit message\n> \n> New in v3\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 23 +++++++++++++++--------\n> 1 file changed, 15 insertions(+), 8 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 00559ce..4a2d924 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -278,6 +278,21 @@ CameraConfiguration::Status IPU3CameraConfiguration::validate()\n> \t\t\t\t<< cfg.toString();\n> \t\t\tstatus = Adjusted;\n> \t\t}\n> +\n> +\t\tconst PixelFormatInfo &info = PixelFormatInfo::info(cfg.pixelFormat);\n> +\t\tbool packedRaw = info.packed &&\n> +\t\t\t\t info.colourEncoding == PixelFormatInfo::ColourEncodingRAW;\n> +\n> +\t\tif (packedRaw) {\n\nI think you can write\n\n\t\tif (info.colourEncoding == PixelFormatInfo::ColourEncodingRAW) {\n\nas we can't support other raw formats than the IPU3 packed formats.\n\n> +\t\t\tcfg.stride = info.stride(cfg.size.width, 0, 64);\n> +\t\t\tcfg.frameSize = cfg.stride * cfg.size.height;\n> +\t\t} else {\n> +\t\t\tcfg.stride = info.stride(cfg.size.width, 0);\n> +\t\t\tstd::array strides;\n> +\t\t\tfor (unsigned int j = 0; j < 3; j++)\n> +\t\t\t\tstrides[i] = info.stride(cfg.size.width, i, packedRaw ? 64 : 0);\n\npackedRaw is always false here.\n\n> +\t\t\tcfg.frameSize = info.frameSize(cfg.size, strides);\n\nI think you can thus just write\n\n\t\t\tcfg.stride = info.stride(cfg.size.width, 0);\n\t\t\tcfg.frameSize = info.frameSize(cfg.size);\n\nReviewed-by: Laurent Pinchart \n\n> +\t\t}\n> \t}\n> \n> \treturn status;\n> @@ -495,21 +510,13 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n> \t\t\tif (ret)\n> \t\t\t\treturn ret;\n> \n> -\t\t\tcfg.stride = outputFormat.planes[0].bpl;\n> \t\t\toutActive = true;\n> \t\t} else if (stream == vfStream) {\n> \t\t\tret = imgu->configureViewfinder(cfg, &outputFormat);\n> \t\t\tif (ret)\n> \t\t\t\treturn ret;\n> \n> -\t\t\tcfg.stride = outputFormat.planes[0].bpl;\n> \t\t\tvfActive = true;\n> -\t\t} else {\n> -\t\t\t/*\n> -\t\t\t * The RAW stream is configured as part of the CIO2 and\n> -\t\t\t * no configuration is needed for the ImgU.\n> -\t\t\t */\n> -\t\t\tcfg.stride = cio2Format.planes[0].bpl;\n> \t\t}\n> \t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2DAC2BD790\n\tfor ;\n\tWed, 8 Jul 2020 15:04:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B386861138;\n\tWed, 8 Jul 2020 17:04:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 14834610F4\n\tfor ;\n\tWed, 8 Jul 2020 17:04:43 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 81E0C543;\n\tWed, 8 Jul 2020 17:04:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"d7Hvtaz2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594220682;\n\tbh=euMxq0Sn+umyBTV6MsmnReNyiy6VmRjImWvL75KHldo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=d7Hvtaz2qEqAMvemnpOaoNQcCRAj1schBfig/5f7PzsPFYADudQGdLCvEmMuMTed2\n\tcrjXKU0cfGVp4m1NVV8MOMuOILlIpdiFCyPJsFED0N9mXG3unaVVELjvwm3rw9X1rE\n\tsAv2QizZM53sqM230y2favNrDljJBXn+Uk+A+OrU=","Date":"Wed, 8 Jul 2020 18:04:36 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"<20200708150436.GE20298@pendragon.ideasonboard.com>","References":"<20200708134417.67747-1-paul.elder@ideasonboard.com>\n\t<20200708134417.67747-15-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200708134417.67747-15-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 14/21] libcamera: ipu3: Fill stride\n\tand frameSize at config validation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11263,"web_url":"https://patchwork.libcamera.org/comment/11263/","msgid":"<20200708212829.lwbt2iaosk4bsiga@uno.localdomain>","date":"2020-07-08T21:28:29","subject":"Re: [libcamera-devel] [PATCH v4 14/21] libcamera: ipu3: Fill stride\n\tand frameSize at config validation","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Wed, Jul 08, 2020 at 10:44:10PM +0900, Paul Elder wrote:\n> Fill the stride and frameSize fields of the StreamConfiguration at\n> configuration validation time instead of at camera configuration time.\n> This allows applications to get the stride when trying a configuration\n> without modifying the active configuration of the camera.\n>\n> Signed-off-by: Paul Elder \n>\n> ---\n> Changes in v4:\n> - fix stride and frameSize calculation\n> - mention motivation in commit message\n>\n> New in v3\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 23 +++++++++++++++--------\n> 1 file changed, 15 insertions(+), 8 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 00559ce..4a2d924 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -278,6 +278,21 @@ CameraConfiguration::Status IPU3CameraConfiguration::validate()\n> \t\t\t\t<< cfg.toString();\n> \t\t\tstatus = Adjusted;\n> \t\t}\n> +\n> +\t\tconst PixelFormatInfo &info = PixelFormatInfo::info(cfg.pixelFormat);\n> +\t\tbool packedRaw = info.packed &&\n> +\t\t\t\t info.colourEncoding == PixelFormatInfo::ColourEncodingRAW;\n> +\n> +\t\tif (packedRaw) {\n> +\t\t\tcfg.stride = info.stride(cfg.size.width, 0, 64);\n> +\t\t\tcfg.frameSize = cfg.stride * cfg.size.height;\n> +\t\t} else {\n> +\t\t\tcfg.stride = info.stride(cfg.size.width, 0);\n> +\t\t\tstd::array strides;\n> +\t\t\tfor (unsigned int j = 0; j < 3; j++)\n> +\t\t\t\tstrides[i] = info.stride(cfg.size.width, i, packedRaw ? 64 : 0);\n\nNow that I see how PixelFormatInfo::frameSize() is used, I wonder if\nalign shouldn't be defaulted there and strides always calculated there, if\nother pipeline handles too have to calculate it with the sole purpose\nof providing it to that function.\n\n> +\t\t\tcfg.frameSize = info.frameSize(cfg.size, strides);\n> +\t\t}\n> \t}\n>\n> \treturn status;\n> @@ -495,21 +510,13 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n> \t\t\tif (ret)\n> \t\t\t\treturn ret;\n>\n> -\t\t\tcfg.stride = outputFormat.planes[0].bpl;\n> \t\t\toutActive = true;\n> \t\t} else if (stream == vfStream) {\n> \t\t\tret = imgu->configureViewfinder(cfg, &outputFormat);\n> \t\t\tif (ret)\n> \t\t\t\treturn ret;\n>\n> -\t\t\tcfg.stride = outputFormat.planes[0].bpl;\n> \t\t\tvfActive = true;\n> -\t\t} else {\n> -\t\t\t/*\n> -\t\t\t * The RAW stream is configured as part of the CIO2 and\n> -\t\t\t * no configuration is needed for the ImgU.\n> -\t\t\t */\n> -\t\t\tcfg.stride = cio2Format.planes[0].bpl;\n> \t\t}\n> \t}\n>\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5560EBD792\n\tfor ;\n\tWed, 8 Jul 2020 21:24:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB4466116D;\n\tWed, 8 Jul 2020 23:24:57 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 64F7761163\n\tfor ;\n\tWed, 8 Jul 2020 23:24:56 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id AE0E0E0006;\n\tWed, 8 Jul 2020 21:24:55 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Wed, 8 Jul 2020 23:28:29 +0200","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20200708212829.lwbt2iaosk4bsiga@uno.localdomain>","References":"<20200708134417.67747-1-paul.elder@ideasonboard.com>\n\t<20200708134417.67747-15-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200708134417.67747-15-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 14/21] libcamera: ipu3: Fill stride\n\tand frameSize at config validation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]