[{"id":11262,"web_url":"https://patchwork.libcamera.org/comment/11262/","msgid":"<20200708212256.y6mqpbnxwwoowb7t@uno.localdomain>","date":"2020-07-08T21:22:56","subject":"Re: [libcamera-devel] [PATCH v4 13/21] libcamera: pipeline:\n\tuvcvideo: Filter out unsupported formats","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"On Wed, Jul 08, 2020 at 10:44:09PM +0900, Paul Elder wrote:\n> Unsupported formats should not be added to the configuration when\n> generating the configuration. Filter them out.\n>\n> Signed-off-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \n>\n> ---\n> Cosmetic change in v4\n>\n> No change in v3\n> ---\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 13 +++++--------\n> 1 file changed, 5 insertions(+), 8 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index 80a0e77..9db69dd 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -161,14 +161,11 @@ CameraConfiguration *PipelineHandlerUVC::generateConfiguration(Camera *camera,\n> \tstd::map> v4l2Formats =\n> \t\tdata->video_->formats();\n> \tstd::map> deviceFormats;\n> -\tstd::transform(v4l2Formats.begin(), v4l2Formats.end(),\n> -\t\t std::inserter(deviceFormats, deviceFormats.begin()),\n> -\t\t [&](const decltype(v4l2Formats)::value_type &format) {\n> -\t\t\t return decltype(deviceFormats)::value_type{\n> -\t\t\t\t format.first.toPixelFormat(),\n> -\t\t\t\t format.second\n> -\t\t\t };\n> -\t\t });\n> +\tfor (const auto &format : v4l2Formats) {\n> +\t\tPixelFormat pixelFormat = format.first.toPixelFormat();\n> +\t\tif (pixelFormat.isValid())\n> +\t\t\tdeviceFormats[pixelFormat] = format.second;\n> +\t}\n\nI'm not able to get to like std::transform and friends, so I'm happy to\nsee it being replaced with a more readable loop here and in the\nprevious one\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> \tStreamFormats formats(deviceFormats);\n> \tStreamConfiguration cfg(formats);\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C3E3BBD790\n\tfor ;\n\tWed, 8 Jul 2020 21:19:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 560926116D;\n\tWed, 8 Jul 2020 23:19:24 +0200 (CEST)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 992D561163\n\tfor ;\n\tWed, 8 Jul 2020 23:19:23 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id DAF4B200002;\n\tWed, 8 Jul 2020 21:19:22 +0000 (UTC)"],"Date":"Wed, 8 Jul 2020 23:22:56 +0200","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20200708212256.y6mqpbnxwwoowb7t@uno.localdomain>","References":"<20200708134417.67747-1-paul.elder@ideasonboard.com>\n\t<20200708134417.67747-14-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200708134417.67747-14-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 13/21] libcamera: pipeline:\n\tuvcvideo: Filter out unsupported formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]