[{"id":11236,"web_url":"https://patchwork.libcamera.org/comment/11236/","msgid":"<20200707185110.GC3875643@oden.dyn.berto.se>","date":"2020-07-07T18:51:10","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: ipa_proxy: Allow stop()\n\ton a stopped IPA","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2020-07-06 16:49:19 +0300, Laurent Pinchart wrote:\n> To make error handling easier in callers, allow the stop() function to\n> be called when the proxy is already stopped, or not started yet.\n> \n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> Changes since v1:\n> \n> - Rewrite documentation\n> ---\n> include/libcamera/internal/ipa_proxy.h | 2 ++\n> src/libcamera/ipa_proxy.cpp | 10 ++++++++++\n> src/libcamera/proxy/ipa_proxy_thread.cpp | 3 +++\n> 3 files changed, 15 insertions(+)\n> \n> diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\n> index aec8f04ffc15..b429ce5a68a3 100644\n> --- a/include/libcamera/internal/ipa_proxy.h\n> +++ b/include/libcamera/internal/ipa_proxy.h\n> @@ -27,6 +27,8 @@ public:\n> \n> \tstd::string configurationFile(const std::string &file) const;\n> \n> +\tvoid stop() override = 0;\n> +\n> protected:\n> \tstd::string resolvePath(const std::string &file) const;\n> \n> diff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp\n> index 23be24ad9bf1..ff4d7fd18cda 100644\n> --- a/src/libcamera/ipa_proxy.cpp\n> +++ b/src/libcamera/ipa_proxy.cpp\n> @@ -145,6 +145,16 @@ std::string IPAProxy::configurationFile(const std::string &name) const\n> \treturn std::string();\n> }\n> \n> +/**\n> + * \\fn IPAProxy::stop()\n> + * \\brief Stop the IPA proxy\n> + *\n> + * This function stops the IPA and releases all the resources acquired by the\n> + * proxy in start(). Calling stop() when the IPA proxy hasn't been started or\n> + * has already been stopped is valid, the proxy shall treat this as a no-op and\n> + * shall not forward the call to the IPA.\n> + */\n> +\n> /**\n> * \\brief Find a valid full path for a proxy worker for a given executable name\n> * \\param[in] file File name of proxy worker executable\n> diff --git a/src/libcamera/proxy/ipa_proxy_thread.cpp b/src/libcamera/proxy/ipa_proxy_thread.cpp\n> index aa403e22f297..eead2883708d 100644\n> --- a/src/libcamera/proxy/ipa_proxy_thread.cpp\n> +++ b/src/libcamera/proxy/ipa_proxy_thread.cpp\n> @@ -121,6 +121,9 @@ int IPAProxyThread::start()\n> \n> void IPAProxyThread::stop()\n> {\n> +\tif (!running_)\n> +\t\treturn;\n> +\n> \trunning_ = false;\n> \n> \tproxy_.invokeMethod(&ThreadProxy::stop, ConnectionTypeBlocking);\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B8C59BD790\n\tfor ;\n\tTue, 7 Jul 2020 18:51:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3DDAD60DFA;\n\tTue, 7 Jul 2020 20:51:13 +0200 (CEST)","from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DE22B60DFA\n\tfor ;\n\tTue, 7 Jul 2020 20:51:11 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id h19so51225011ljg.13\n\tfor ;\n\tTue, 07 Jul 2020 11:51:11 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\t81sm9832665lfj.24.2020.07.07.11.51.10\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 07 Jul 2020 11:51:10 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"dhv/GtOX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=yYvFJ2ea/v4Wd1KxDmP8SQ/eiDEuO7PUGCmbPFGOlu0=;\n\tb=dhv/GtOXoL+tiJIy3xiFOJ7J3S2Wbn6Pi0iG5CqlQ0Ez8z/fej/ZIonMolOUbqXXLN\n\treS4igQ2MHEITftjjvX7dylkCKZyOBBIyiTT9TZv+isMMM3LfizZ8q3AEiZNYz0+oj+L\n\tdWDa+9TxX1ylDgxmvYqHrknYhTztimIRebXXcXmdVkzTLvoDY54O7uDIgEpwIeMw/48j\n\tM7SQN4wDzfcMBim2CzXd1kGx9+2khVFiLq0UsNGqCyoei+8xf/OCGq6/C2LKpdaVOH7c\n\tTBPMxOLInRIYultYyrCy9re/ccSBaaiYMQXuGwv+ZONkxrc72tox2da37FjT/BkYWtW2\n\tHXqg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=yYvFJ2ea/v4Wd1KxDmP8SQ/eiDEuO7PUGCmbPFGOlu0=;\n\tb=Z82Sek5DPYfUAyQzz1QLvBVr6wAsqvMTBl3ABoGsm270dXgo91G1agLGDVNaYndTzP\n\tkSytPvOg1ci9oEaM3t/75k/HI9pEvqnjAFKnWQKomZRRKOYSwaMBNj5riiPoVkOFAJ36\n\tSSG3/YcS4Oa6Vq/2ju24Ryfx8IFLU5Pm0SkzJq1lMkzzpVc8IlgOLg9oDOy1/AxlID0q\n\tF0tNtWWcq4Eq9vgSl+diLkklpQXLh2glJv7dHUIA/o/uEWd1v2kU4VcTNF+fbtfm2Y80\n\tknkvKhDMG53+nd73L7TV+9mCnZygDyOIfWiRUdjkW0PBAXEtSxWkfLCpu5RrDoVwACMc\n\tiY2Q==","X-Gm-Message-State":"AOAM533ubOhGQNJ8+ZKRSfRQ8GwA/o6avWaIdE3T2ivSgQrBhxRJ6Tt+\n\t9aonE/77v4vl0o4lHpspISwLdQ==","X-Google-Smtp-Source":"ABdhPJzNfj3CmjZMMYrbiX6wbotnklGJW8ozxcJsAdElbUb0eTQrhXEgyn19IAXp/NjbsooafrH4Rw==","X-Received":"by 2002:a2e:3e15:: with SMTP id l21mr9244262lja.43.1594147871138;\n\tTue, 07 Jul 2020 11:51:11 -0700 (PDT)","Date":"Tue, 7 Jul 2020 20:51:10 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20200707185110.GC3875643@oden.dyn.berto.se>","References":"<20200706134919.19224-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200706134919.19224-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: ipa_proxy: Allow stop()\n\ton a stopped IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]