[{"id":11220,"web_url":"https://patchwork.libcamera.org/comment/11220/","msgid":"<20200706141652.GB19803@pendragon.ideasonboard.com>","date":"2020-07-06T14:16:52","subject":"Re: [libcamera-devel] [PATCH v2 1/3] libcamera: controls: Add focus\n\tFigure of Merit (FoM) control","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Mon, Jul 06, 2020 at 09:56:23AM +0100, Naushir Patuck wrote:\n> Provide a control to allow the IPA to return a FoM to indicate how\n> in-focus a scene is. Note, this is not to be used as a means to\n> implement a focus algorithm by the application, rather an indication of\n> how in-focus a scene is.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Laurent Pinchart \n\nWill push to master after running tests.\n\n> ---\n> src/libcamera/control_ids.yaml | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n> \n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index 8c3e4c72..988b5016 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -251,4 +251,15 @@ controls:\n> higher than anyone could reasonably want. Negative values are\n> not allowed. Note also that sharpening is not applied to raw\n> streams.\n> +\n> + - FocusFoM:\n> + type: int32_t\n> + description: |\n> + Reports a Figure of Merit (FoM) to indicate how in-focus the frame is.\n> + A larger FocusFoM value indicates a more in-focus frame. This control\n> + depends on the IPA to gather ISP statistics from the defined focus\n> + region, and combine them in a suitable way to generate a FocusFoM value.\n> + In this respect, it is not necessarily aimed at providing a way to\n> + implement a focus algorithm by the application, rather an indication of\n> + how in-focus a frame is.\n> ...","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6690EBD790\n\tfor ;\n\tMon, 6 Jul 2020 14:16:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F274D603AB;\n\tMon, 6 Jul 2020 16:16:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 998BB603AA\n\tfor ;\n\tMon, 6 Jul 2020 16:16:57 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 124E097E;\n\tMon, 6 Jul 2020 16:16:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fpEDOGzH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594045017;\n\tbh=sYPS3YBLaQV8IW0G9NTYgfOUKrxXQm9n3zeSCPI/X6c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fpEDOGzHs7ZiS7p0iF+Kmp/GL3fFOwzpmvCiB3YoBG7T/eebV7Znaz+SkxunoUbvX\n\tkwSgBNeymfdNAeRAEiEYml+D6vsZg5a+x4bK/i8znwAoTmGxp/mTuSc5LTRPbLr6AF\n\tptjsLd+Oy/ycS406nJXRnXA6FtekfTL3LK/B3ymM=","Date":"Mon, 6 Jul 2020 17:16:52 +0300","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"<20200706141652.GB19803@pendragon.ideasonboard.com>","References":"<20200706085625.1625432-1-naush@raspberrypi.com>\n\t<20200706085625.1625432-2-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200706085625.1625432-2-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] libcamera: controls: Add focus\n\tFigure of Merit (FoM) control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]