[{"id":11185,"web_url":"https://patchwork.libcamera.org/comment/11185/","msgid":"<20200704220354.GL10773@pendragon.ideasonboard.com>","date":"2020-07-04T22:03:54","subject":"Re: [libcamera-devel] [PATCH v3 22/22] libcamera:\n\tStreamConfiguration: Update stride documentation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Sat, Jul 04, 2020 at 10:31:40PM +0900, Paul Elder wrote:\n> Now that all the pipeline handlers fill in the stride information at\n> validation time, update the documentation accordingly.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> New in v3\n> ---\n> src/libcamera/stream.cpp | 7 ++-----\n> 1 file changed, 2 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> index 6d6e279..d5da834 100644\n> --- a/src/libcamera/stream.cpp\n> +++ b/src/libcamera/stream.cpp\n> @@ -309,11 +309,8 @@ StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n> *\n> * The stride value reports the number of bytes between the beginning of\n> * successive lines in an image buffer for this stream. The value is\n> - * valid after successfully configuring the camera with this\n> - * configuration with a call to Camera::Configure().\n> - *\n> - * \\todo Update this value when configuration is validated instead of when\n> - * the camera is configured.\n> + * valid after successfully validating the configuration with a call to\n> + * CameraConfiguration::validate().\n> */\n> \n> /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 73F85BD790\n\tfor ;\n\tSat, 4 Jul 2020 22:04:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 38EC060C50;\n\tSun, 5 Jul 2020 00:04:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 82350609A9\n\tfor ;\n\tSun, 5 Jul 2020 00:03:58 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 19127296;\n\tSun, 5 Jul 2020 00:03:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"suirtrZl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593900238;\n\tbh=rc3MMTdFcUt1jHnEJm+/AQXpotkFXZF/9e/G8z4e/5A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=suirtrZl85p+FGW0o8nLm+5lcW89QN9MfyDEGe9qcyf+H/siifTtiussWWik2JhAf\n\tKUAyUy8IFLZhTw+x6/6vo2mAIxe89+FtQHCbJDwhgt9FWuwnRw816d/wRAYp+Vuqua\n\tzArVqmccXbbd6veQryZUjw1SU7iKKv/C2LMh95bc=","Date":"Sun, 5 Jul 2020 01:03:54 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"<20200704220354.GL10773@pendragon.ideasonboard.com>","References":"<20200704133140.1738660-1-paul.elder@ideasonboard.com>\n\t<20200704133140.1738660-23-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200704133140.1738660-23-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 22/22] libcamera:\n\tStreamConfiguration: Update stride documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]