{"id":8643,"url":"https://patchwork.libcamera.org/api/patches/8643/?format=json","web_url":"https://patchwork.libcamera.org/patch/8643/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200704133140.1738660-23-paul.elder@ideasonboard.com>","date":"2020-07-04T13:31:40","name":"[libcamera-devel,v3,22/22] libcamera: StreamConfiguration: Update stride documentation","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"2b598096b81eb0e63167c41901129ae8ec4c9590","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8643/mbox/","series":[{"id":1083,"url":"https://patchwork.libcamera.org/api/series/1083/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1083","date":"2020-07-04T13:31:18","name":"Clean up formats in v4l2-compat and pipeline handlers","version":3,"mbox":"https://patchwork.libcamera.org/series/1083/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8643/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8643/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 24E25BD792\n\tfor ;\n\tSat, 4 Jul 2020 13:32:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E852260E46;\n\tSat, 4 Jul 2020 15:32:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9EBAD60E0D\n\tfor ;\n\tSat, 4 Jul 2020 15:32:38 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BD4E755B;\n\tSat, 4 Jul 2020 15:32:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UtNdTbEt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593869558;\n\tbh=tGIcqovcY8qr5/NY/oPydHaLaREuLqQHTwvVnMeZ2DU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=UtNdTbEtdLTFs+lqX8FWlMLf1iTq8HU8/ia/9hXQQRHPN16fSyG7jFVTsq9dc/iSa\n\tVvlXOF/SkBFkqtM2OPS1QfN647BwPCD/caClH0gLl5isDoNV/OnLjSScM75HNxXcW8\n\tlg6B5e+RUL86p4BZV4rxlJvN+A3EeJzndBtKUE0k=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 4 Jul 2020 22:31:40 +0900","Message-Id":"<20200704133140.1738660-23-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200704133140.1738660-1-paul.elder@ideasonboard.com>","References":"<20200704133140.1738660-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 22/22] libcamera: StreamConfiguration:\n\tUpdate stride documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that all the pipeline handlers fill in the stride information at\nvalidation time, update the documentation accordingly.\n\nSigned-off-by: Paul Elder \n\n---\nNew in v3\n---\n src/libcamera/stream.cpp | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)","diff":"diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\nindex 6d6e279..d5da834 100644\n--- a/src/libcamera/stream.cpp\n+++ b/src/libcamera/stream.cpp\n@@ -309,11 +309,8 @@ StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n *\n * The stride value reports the number of bytes between the beginning of\n * successive lines in an image buffer for this stream. The value is\n- * valid after successfully configuring the camera with this\n- * configuration with a call to Camera::Configure().\n- *\n- * \\todo Update this value when configuration is validated instead of when\n- * the camera is configured.\n+ * valid after successfully validating the configuration with a call to\n+ * CameraConfiguration::validate().\n */\n \n /**\n","prefixes":["libcamera-devel","v3","22/22"]}