[{"id":11184,"web_url":"https://patchwork.libcamera.org/comment/11184/","msgid":"<20200704220212.GK10773@pendragon.ideasonboard.com>","date":"2020-07-04T22:02:12","subject":"Re: [libcamera-devel] [PATCH v3 21/22] libcamera: vimc: Fill stride\n\tand frameSize at config validation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Sat, Jul 04, 2020 at 10:31:39PM +0900, Paul Elder wrote:\n> Fill the stride and frameSize fields of the StreamConfiguration at\n> configuration validation time instead of at camera configuration time.\n> \n> Signed-off-by: Paul Elder \n> \n> ---\n> New in v3\n> ---\n> src/libcamera/pipeline/vimc/vimc.cpp | 5 ++++-\n> 1 file changed, 4 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> index b653066..e55a861 100644\n> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> @@ -160,6 +160,10 @@ CameraConfiguration::Status VimcCameraConfiguration::validate()\n> \n> \tcfg.bufferCount = 4;\n> \n> +\tconst PixelFormatInfo &info = PixelFormatInfo::info(cfg.pixelFormat);\n> +\tcfg.stride = info.stride(cfg.size.width, 0);\n> +\tcfg.frameSize = info.frameSize(cfg.size);\n\nYou know what I'm going to say already :-) Please check the driver to\nfind the alignment constraints.\n\n> +\n> \treturn status;\n> }\n> \n> @@ -282,7 +286,6 @@ int PipelineHandlerVimc::configure(Camera *camera, CameraConfiguration *config)\n> \t\treturn ret;\n> \n> \tcfg.setStream(&data->stream_);\n> -\tcfg.stride = format.planes[0].bpl;\n> \n> \treturn 0;\n> }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EFB70BD790\n\tfor ;\n\tSat, 4 Jul 2020 22:02:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BC63260C50;\n\tSun, 5 Jul 2020 00:02:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3E2B3609A9\n\tfor ;\n\tSun, 5 Jul 2020 00:02:17 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8FCAE296;\n\tSun, 5 Jul 2020 00:02:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KBPagLkQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593900136;\n\tbh=wGV2xof/+enIsc63WqVsFwMepyRsKLA0RLGV1BSfb3c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KBPagLkQmbis7/4PNnRtKefJV0sTcHwu1Omsz+2qpktpWMrDBnTMSgMAT9AEYP/tx\n\tlEBiCiC72wN6a/45KvJkIZDQQHRLC+b/nCv5LWBanE4IyDV1o0JmfifJ1Bhpd0RxEY\n\tNWF0u0EZtiH7KK5KLgKqAJUcqg/fRktHIHnUO014=","Date":"Sun, 5 Jul 2020 01:02:12 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"<20200704220212.GK10773@pendragon.ideasonboard.com>","References":"<20200704133140.1738660-1-paul.elder@ideasonboard.com>\n\t<20200704133140.1738660-22-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200704133140.1738660-22-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 21/22] libcamera: vimc: Fill stride\n\tand frameSize at config validation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]