{"id":8639,"url":"https://patchwork.libcamera.org/api/patches/8639/?format=json","web_url":"https://patchwork.libcamera.org/patch/8639/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200704133140.1738660-19-paul.elder@ideasonboard.com>","date":"2020-07-04T13:31:36","name":"[libcamera-devel,v3,18/22] libcamera: rkisp1: Fill stride and frameSize at config validation","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1e3eeb5a8ee9bc1ddec2b3996ee5f24f18d30b9e","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8639/mbox/","series":[{"id":1083,"url":"https://patchwork.libcamera.org/api/series/1083/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1083","date":"2020-07-04T13:31:18","name":"Clean up formats in v4l2-compat and pipeline handlers","version":3,"mbox":"https://patchwork.libcamera.org/series/1083/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8639/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8639/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A789BBD792\n\tfor ;\n\tSat, 4 Jul 2020 13:32:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6FDC960E4D;\n\tSat, 4 Jul 2020 15:32:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 91C4D60E44\n\tfor ;\n\tSat, 4 Jul 2020 15:32:30 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 101E1296;\n\tSat, 4 Jul 2020 15:32:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UkcNo6Vs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593869550;\n\tbh=xj49UfMfDuEQlMtpgqHNpuRxbOMEwAWnuN7gACUWhD0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=UkcNo6VsOFqdcKHQ5ptc9SipDtj/qezhWowEelM0zMOX4/lgyDn54U4UV3JygISPn\n\tUGqA7dtAFVmV2THqmuD0EYnq5P3cKyIIfACwbvU82ZhCd2yYQB+dJmRDUPzClO88OL\n\t8ryfp63hPoPd9Q6mgdtktBaL0KWpfyIh3YLjPbX0=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 4 Jul 2020 22:31:36 +0900","Message-Id":"<20200704133140.1738660-19-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200704133140.1738660-1-paul.elder@ideasonboard.com>","References":"<20200704133140.1738660-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 18/22] libcamera: rkisp1: Fill stride\n\tand frameSize at config validation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Fill the stride and frameSize fields of the StreamConfiguration at\nconfiguration validation time instead of at camera configuration time.\n\nSigned-off-by: Paul Elder \n\n---\nNew in v3\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 3c3f3f3..3ac7b3c 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -535,6 +535,10 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()\n \n \tcfg.bufferCount = RKISP1_BUFFER_COUNT;\n \n+\tconst PixelFormatInfo &info = PixelFormatInfo::info(cfg.pixelFormat);\n+\tcfg.stride = info.stride(cfg.size.width, 0);\n+\tcfg.frameSize = info.frameSize(cfg.size);\n+\n \treturn status;\n }\n \n@@ -683,7 +687,6 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \t\treturn ret;\n \n \tcfg.setStream(&data->stream_);\n-\tcfg.stride = outputFormat.planes[0].bpl;\n \n \treturn 0;\n }\n","prefixes":["libcamera-devel","v3","18/22"]}