[{"id":11177,"web_url":"https://patchwork.libcamera.org/comment/11177/","msgid":"<20200704212301.GD10773@pendragon.ideasonboard.com>","date":"2020-07-04T21:23:01","subject":"Re: [libcamera-devel] [PATCH v3 14/22] libcamera: pipeline:\n\traspberrypi: Filter out unsupported formats","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Sat, Jul 04, 2020 at 10:31:32PM +0900, Paul Elder wrote:\n> Unsupported formats should not be added to the configuration when\n> generating the configuration. Filter them out.\n> \n> Signed-off-by: Paul Elder \n> \n> ---\n> No change in v3\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 12 +++++-------\n> 1 file changed, 5 insertions(+), 7 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index cbb6f1c..18d068a 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -569,13 +569,11 @@ CameraConfiguration *PipelineHandlerRPi::generateConfiguration(Camera *camera,\n> \n> \t\t/* Translate the V4L2PixelFormat to PixelFormat. */\n> \t\tstd::map> deviceFormats;\n> -\t\tstd::transform(fmts.begin(), fmts.end(), std::inserter(deviceFormats, deviceFormats.end()),\n> -\t\t\t [&](const decltype(fmts)::value_type &format) {\n> -\t\t\t\t\treturn decltype(deviceFormats)::value_type{\n> -\t\t\t\t\t\tformat.first.toPixelFormat(),\n> -\t\t\t\t\t\tformat.second\n> -\t\t\t\t\t};\n> -\t\t\t });\n> +\t\tfor (auto format : fmts) {\n\n\t\tfor (const auto &format : fmts) {\n\n> +\t\t\tPixelFormat pixelFormat = format.first.toPixelFormat();\n> +\t\t\tif (pixelFormat.isValid())\n> +\t\t\t\tdeviceFormats[pixelFormat] = format.second;\n> +\t\t}\n\nI wonder if newer C++ versions will get a std::transform_if(), or if\nglobal mind sanity will prevail :-)\n\nReviewed-by: Laurent Pinchart \n\n> \n> \t\t/* Add the stream format based on the device node used for the use case. */\n> \t\tStreamFormats formats(deviceFormats);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 641ACBD792\n\tfor ;\n\tSat, 4 Jul 2020 21:23:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3063460E01;\n\tSat, 4 Jul 2020 23:23:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7175C609C7\n\tfor ;\n\tSat, 4 Jul 2020 23:23:05 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 08FA6296;\n\tSat, 4 Jul 2020 23:23:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Gt3lDK9F\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593897785;\n\tbh=Dtril7sgmeDVIoUO7qZypAB5/e1Exxwsi+d8Sotn8QI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Gt3lDK9FfIDPq8h6pnB0eww1qsKiTGteR2pMyWQwIcuDSo1F2L0Lh90ZxC8KhRuEC\n\tqWl+a4G3m/ix1cJmNfHlOWCjKOJgdJWt0U9dLIvMVHgU5qsdGDa6Cz2K/6CIoy/qsU\n\td5EmGMz5iuz9idM8mHL9JT9wwC8P/pqGmRdiwRkQ=","Date":"Sun, 5 Jul 2020 00:23:01 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"<20200704212301.GD10773@pendragon.ideasonboard.com>","References":"<20200704133140.1738660-1-paul.elder@ideasonboard.com>\n\t<20200704133140.1738660-15-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200704133140.1738660-15-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 14/22] libcamera: pipeline:\n\traspberrypi: Filter out unsupported formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]