[{"id":11176,"web_url":"https://patchwork.libcamera.org/comment/11176/","msgid":"<20200704212125.GC10773@pendragon.ideasonboard.com>","date":"2020-07-04T21:21:25","subject":"Re: [libcamera-devel] [PATCH v3 13/22] libcamera: pipeline_handler:\n\tFatal if registering camera without media devices","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Sat, Jul 04, 2020 at 10:31:31PM +0900, Paul Elder wrote:\n> Pipeline handlers must acquire media devices via\n> PipelineHander::acquireMediaDevice so that the media devices can be\n> registered with the pipeline handler, so that they can be automatically\n> added to the devnum map for the v4l2 compatibility layer to use. Die\n> fatally if any camera trying to be registered has not acquired any media\n> devices via acquireMediaDevice.\n> \n> Signed-off-by: Paul Elder \n> \n> ---\n> No change in v3\n> ---\n> src/libcamera/pipeline_handler.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index de5ca09..8a6c9c2 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -496,6 +496,10 @@ void PipelineHandler::registerCamera(std::shared_ptr camera,\n> \tcameraData_[camera.get()] = std::move(data);\n> \tcameras_.push_back(camera);\n> \n> +\tif (!mediaDevices_.size())\n\n\tif (mediaDevices_.empty())\n\nReviewed-by: Laurent Pinchart \n\n> +\t\tLOG(Pipeline, Fatal)\n> +\t\t\t<< \"Registering camera with no media devices!\";\n> +\n> \t/*\n> \t * Walk the entity list and map the devnums of all capture video nodes\n> \t * to the camera.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2F61DBD792\n\tfor ;\n\tSat, 4 Jul 2020 21:21:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B92FD60C50;\n\tSat, 4 Jul 2020 23:21:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 213B1609C7\n\tfor ;\n\tSat, 4 Jul 2020 23:21:30 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B21A296;\n\tSat, 4 Jul 2020 23:21:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cF1QXmqW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593897689;\n\tbh=ncdGz7VX4wWVwmSstfL2NSfaBmB4fI0VfBMCijd1fgY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cF1QXmqWL5NCOftkW2n/iG4bAfSZzZLpq37bQ7aNz9AVVr95JUC3U5iIziVuY7dp6\n\tM56HOoEeULo5CHZyFWbaa4yqOOPNKtiiyPTUkcGXg2DyntkWUaupZSS5cm0MF/oDx9\n\tiVAj3+fx1IgIu0a/goxOwEWHZdwyrQWiU4ZQXDl4=","Date":"Sun, 5 Jul 2020 00:21:25 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"<20200704212125.GC10773@pendragon.ideasonboard.com>","References":"<20200704133140.1738660-1-paul.elder@ideasonboard.com>\n\t<20200704133140.1738660-14-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200704133140.1738660-14-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 13/22] libcamera: pipeline_handler:\n\tFatal if registering camera without media devices","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]