{"id":8628,"url":"https://patchwork.libcamera.org/api/patches/8628/?format=json","web_url":"https://patchwork.libcamera.org/patch/8628/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200704133140.1738660-8-paul.elder@ideasonboard.com>","date":"2020-07-04T13:31:25","name":"[libcamera-devel,v3,07/22] v4l2: v4l2_camera: Add validateConfiguration","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"98d89f17d8481b7f206f65fb2b283223fb47a1d4","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8628/mbox/","series":[{"id":1083,"url":"https://patchwork.libcamera.org/api/series/1083/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1083","date":"2020-07-04T13:31:18","name":"Clean up formats in v4l2-compat and pipeline handlers","version":3,"mbox":"https://patchwork.libcamera.org/series/1083/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8628/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8628/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BA7DFBD792\n\tfor ;\n\tSat, 4 Jul 2020 13:32:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 86FBD60E1F;\n\tSat, 4 Jul 2020 15:32:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2955D60E1F\n\tfor ;\n\tSat, 4 Jul 2020 15:32:09 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A9383296;\n\tSat, 4 Jul 2020 15:32:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Gx78/MYj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593869528;\n\tbh=xd10mEY+pQVIjwMRdM2jBnYvFVRcSb1QerJ6VSiYrLw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Gx78/MYjirbYxAaaf9uKNqoIZlKFLMyodOkkcwUdkuw3J+csTKUskkBOOdWdSPMgl\n\td0G8BfnY/GSitaKygU9bmwVCivFrV/MKjyf4e3Xyyi6hyds8s1H26DOVdq2UaEWjUm\n\tuo5ikPGUHd0ZaUhDM6AdA6HynStLLLIhttTv5y8A=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 4 Jul 2020 22:31:25 +0900","Message-Id":"<20200704133140.1738660-8-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200704133140.1738660-1-paul.elder@ideasonboard.com>","References":"<20200704133140.1738660-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 07/22] v4l2: v4l2_camera: Add\n\tvalidateConfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In V4L2CameraProxy, we need a way to validate formats and sizes, to\nimplement try_fmt. Instead of manually checking it against the cached\nlist of formats and sizes, add V4L2Camera::validateConfiguration that we\ncan use to implement try_fmt.\n\nSigned-off-by: Paul Elder \n\n---\nNew in v3\n---\n src/v4l2/v4l2_camera.cpp | 29 +++++++++++++++++++++++++++++\n src/v4l2/v4l2_camera.h | 3 +++\n 2 files changed, 32 insertions(+)","diff":"diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp\nindex ffc1230..326e1c2 100644\n--- a/src/v4l2/v4l2_camera.cpp\n+++ b/src/v4l2/v4l2_camera.cpp\n@@ -138,6 +138,35 @@ int V4L2Camera::configure(StreamConfiguration *streamConfigOut,\n \treturn 0;\n }\n \n+int V4L2Camera::validateConfiguration(StreamConfiguration *streamConfigOut,\n+\t\t\t\t const Size &size,\n+\t\t\t\t const PixelFormat &pixelFormat)\n+{\n+\tif (!streamConfigOut)\n+\t\treturn -EINVAL;\n+\n+\tstd::unique_ptr config =\n+\t\tcamera_->generateConfiguration({ StreamRole::Viewfinder });\n+\tStreamConfiguration &cfg = config->at(0);\n+\tcfg.size.width = size.width;\n+\tcfg.size.height = size.height;\n+\tcfg.pixelFormat = pixelFormat;\n+\tcfg.bufferCount = 1;\n+\n+\tCameraConfiguration::Status validation = config->validate();\n+\tif (validation == CameraConfiguration::Invalid)\n+\t\treturn -EINVAL;\n+\n+\tstreamConfigOut->pixelFormat = cfg.pixelFormat;\n+\tstreamConfigOut->size.width = cfg.size.width;\n+\tstreamConfigOut->size.height = cfg.size.height;\n+\tstreamConfigOut->bufferCount = cfg.bufferCount;\n+\tstreamConfigOut->stride = cfg.stride;\n+\tstreamConfigOut->frameSize = cfg.frameSize;\n+\n+\treturn 0;\n+}\n+\n int V4L2Camera::allocBuffers(unsigned int count)\n {\n \tStream *stream = *camera_->streams().begin();\ndiff --git a/src/v4l2/v4l2_camera.h b/src/v4l2/v4l2_camera.h\nindex 515e906..15a9363 100644\n--- a/src/v4l2/v4l2_camera.h\n+++ b/src/v4l2/v4l2_camera.h\n@@ -47,6 +47,9 @@ public:\n \tint configure(StreamConfiguration *streamConfigOut,\n \t\t const Size &size, const PixelFormat &pixelformat,\n \t\t unsigned int bufferCount);\n+\tint validateConfiguration(StreamConfiguration *streamConfigOut,\n+\t\t\t\t const Size &size,\n+\t\t\t\t const PixelFormat &pixelformat);\n \n \tint allocBuffers(unsigned int count);\n \tvoid freeBuffers();\n","prefixes":["libcamera-devel","v3","07/22"]}