{"id":8626,"url":"https://patchwork.libcamera.org/api/patches/8626/?format=json","web_url":"https://patchwork.libcamera.org/patch/8626/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200704133140.1738660-6-paul.elder@ideasonboard.com>","date":"2020-07-04T13:31:23","name":"[libcamera-devel,v3,05/22] libcamera: formats: PixelFormatInfo: Add v4l2 lookup function","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"cafbaa165171804fb3b29ebf208c2d5046d45879","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8626/mbox/","series":[{"id":1083,"url":"https://patchwork.libcamera.org/api/series/1083/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1083","date":"2020-07-04T13:31:18","name":"Clean up formats in v4l2-compat and pipeline handlers","version":3,"mbox":"https://patchwork.libcamera.org/series/1083/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8626/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8626/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 052E5BD792\n\tfor ;\n\tSat, 4 Jul 2020 13:32:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C7A2060E05;\n\tSat, 4 Jul 2020 15:32:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4299560E1D\n\tfor ;\n\tSat, 4 Jul 2020 15:32:05 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 78C97296;\n\tSat, 4 Jul 2020 15:32:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KWaBJd3g\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593869525;\n\tbh=j4iqNR/ZUm39viBGrTNJW2NbG/vnJ3jNGZqiIsuAN/c=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=KWaBJd3g6f4QNUXEiTJMTP+XKhyU6R31+Dhe8hWFloKYnlIsmczBBcijfw/mwC35Y\n\t2+FA3W39UFXso6g6PoLYlMZF9r+xXLL45NVS8YDjtFGNzdzEzeSKs8JCrFEvuL/koz\n\tWcl5XTWu6G2k8GRAYLxd73kMVxXcN2BenT5ONu18=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 4 Jul 2020 22:31:23 +0900","Message-Id":"<20200704133140.1738660-6-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200704133140.1738660-1-paul.elder@ideasonboard.com>","References":"<20200704133140.1738660-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 05/22] libcamera: formats:\n\tPixelFormatInfo: Add v4l2 lookup function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a lookup function for PixelFormatInfo that takes a V4L2PixelFormat.\n\nSigned-off-by: Paul Elder \nReviewed-by: Laurent Pinchart \n\n---\nChanges in v3:\n- rename invalid PixelFormatInfo\n- make info const in PixelFormatInfo::info()\n\nChanges in v2:\n- move invalid PixelFormatInfo instance to anonymous namespace\n- add documentation\n---\n include/libcamera/internal/formats.h | 1 +\n src/libcamera/formats.cpp | 25 ++++++++++++++++++++++---\n 2 files changed, 23 insertions(+), 3 deletions(-)","diff":"diff --git a/include/libcamera/internal/formats.h b/include/libcamera/internal/formats.h\nindex ebd256c..cf00814 100644\n--- a/include/libcamera/internal/formats.h\n+++ b/include/libcamera/internal/formats.h\n@@ -50,6 +50,7 @@ public:\n \tbool isValid() const { return format.isValid(); }\n \n \tstatic const PixelFormatInfo &info(const PixelFormat &format);\n+\tstatic const PixelFormatInfo &info(const V4L2PixelFormat &format);\n \n \tconst char *name;\n \tPixelFormat format;\ndiff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 6bdd28d..f96bf1f 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -7,6 +7,7 @@\n \n #include \"libcamera/internal/formats.h\"\n \n+#include \n #include \n \n #include \n@@ -206,6 +207,8 @@ const std::map> &ImageFormats::data() const\n \n namespace {\n \n+const PixelFormatInfo pixelFormatInfoInvalid{};\n+\n const std::map pixelFormatInfo{\n \t/* RGB formats. */\n \t{ formats::BGR888, {\n@@ -678,17 +681,33 @@ const std::map pixelFormatInfo{\n */\n const PixelFormatInfo &PixelFormatInfo::info(const PixelFormat &format)\n {\n-\tstatic const PixelFormatInfo invalid{};\n-\n \tconst auto iter = pixelFormatInfo.find(format);\n \tif (iter == pixelFormatInfo.end()) {\n \t\tLOG(Formats, Warning)\n \t\t\t<< \"Unsupported pixel format 0x\"\n \t\t\t<< utils::hex(format.fourcc());\n-\t\treturn invalid;\n+\t\treturn pixelFormatInfoInvalid;\n \t}\n \n \treturn iter->second;\n }\n \n+/**\n+ * \\brief Retrieve information about a pixel format\n+ * \\param[in] format The V4L2 pixel format\n+ * \\return The PixelFormatInfo describing the V4L2 \\a format if known, or an\n+ * invalid PixelFormatInfo otherwise\n+ */\n+const PixelFormatInfo &PixelFormatInfo::info(const V4L2PixelFormat &format)\n+{\n+\tconst auto &info = std::find_if(pixelFormatInfo.begin(), pixelFormatInfo.end(),\n+\t\t\t\t\t[format](auto pair) {\n+\t\t\t\t\t\treturn pair.second.v4l2Format == format;\n+\t\t\t\t\t});\n+\tif (info == pixelFormatInfo.end())\n+\t\treturn pixelFormatInfoInvalid;\n+\n+\treturn info->second;\n+}\n+\n } /* namespace libcamera */\n","prefixes":["libcamera-devel","v3","05/22"]}