[{"id":11194,"web_url":"https://patchwork.libcamera.org/comment/11194/","msgid":"<20200706085112.gka5hoagvh5pzryc@uno.localdomain>","date":"2020-07-06T08:51:12","subject":"Re: [libcamera-devel] [PATCH v2 04/12] libcamera: pipeline:\n\traspberrypi: Drop unused local variable","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Sat, Jul 04, 2020 at 03:52:19AM +0300, Laurent Pinchart wrote:\n> The controls variable in PipelineHandlerRPi::start() is unused. Drop it.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 1 -\n> 1 file changed, 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index ab4b915156e1..db0b20135318 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -787,7 +787,6 @@ int PipelineHandlerRPi::exportFrameBuffers(Camera *camera, Stream *stream,\n> int PipelineHandlerRPi::start(Camera *camera)\n> {\n> \tRPiCameraData *data = cameraData(camera);\n> -\tControlList controls(data->sensor_->controls());\n> \tint ret;\n>\n> \t/* Allocate buffers for internal pipeline usage. */\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3632FBD790\n\tfor ;\n\tMon, 6 Jul 2020 08:47:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0DD2060E09;\n\tMon, 6 Jul 2020 10:47:40 +0200 (CEST)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3429D603B1\n\tfor ;\n\tMon, 6 Jul 2020 10:47:39 +0200 (CEST)","from uno.localdomain (host-79-34-235-173.business.telecomitalia.it\n\t[79.34.235.173]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 781BF20011;\n\tMon, 6 Jul 2020 08:47:38 +0000 (UTC)"],"X-Originating-IP":"79.34.235.173","Date":"Mon, 6 Jul 2020 10:51:12 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20200706085112.gka5hoagvh5pzryc@uno.localdomain>","References":"<20200704005227.21782-1-laurent.pinchart@ideasonboard.com>\n\t<20200704005227.21782-5-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200704005227.21782-5-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 04/12] libcamera: pipeline:\n\traspberrypi: Drop unused local variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11239,"web_url":"https://patchwork.libcamera.org/comment/11239/","msgid":"","date":"2020-07-08T09:47:43","subject":"Re: [libcamera-devel] [PATCH v2 04/12] libcamera: pipeline:\n\traspberrypi: Drop unused local variable","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nOn Sat, 4 Jul 2020 at 01:52, Laurent Pinchart\n wrote:\n>\n> The controls variable in PipelineHandlerRPi::start() is unused. Drop it.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Naushir Patuck \n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 1 -\n> 1 file changed, 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index ab4b915156e1..db0b20135318 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -787,7 +787,6 @@ int PipelineHandlerRPi::exportFrameBuffers(Camera *camera, Stream *stream,\n> int PipelineHandlerRPi::start(Camera *camera)\n> {\n> RPiCameraData *data = cameraData(camera);\n> - ControlList controls(data->sensor_->controls());\n> int ret;\n>\n> /* Allocate buffers for internal pipeline usage. */\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AC645BD790\n\tfor ;\n\tWed, 8 Jul 2020 09:48:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CF452610B2;\n\tWed, 8 Jul 2020 11:48:02 +0200 (CEST)","from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F203603AC\n\tfor ;\n\tWed, 8 Jul 2020 11:48:00 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id q7so40155349ljm.1\n\tfor ;\n\tWed, 08 Jul 2020 02:48:00 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"aEG5fnn6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=KvwivC1Xqr93rFzvgOzZvqmTsrnT5BBTtc0iRHnJWhM=;\n\tb=aEG5fnn6R/RAr8szRqD6EsiBDU+pbr2jhlBPObvCkLHzrdsY8gAjlVA7K4y/2wv93E\n\t5UHHyrRzSsCqEu943CyxlMREuJHQ5rvOIyptPwQRyS4mOwahdriapl/3KlyHCXkzqO7Q\n\tafZrrI4ViqzTdlQxqMdrR1/MFvUr87HjWNDsMpYCZAoqf5a9nMN1H0j+EBPRbf0vWLtg\n\tS4JQy8VxvbTPYRU7YOYJrKFwyYOvtWrDzSTwzLwkEFFgzSIKQ51la1Gdvu3doUsTAgHo\n\tkp8ZiTOoc69VyW3+oXUamzM9tFZsx23R4UxXc83kD/GIiASWriCui5dlsQRjA9LVGIZG\n\tsZjA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=KvwivC1Xqr93rFzvgOzZvqmTsrnT5BBTtc0iRHnJWhM=;\n\tb=dWLKLTlfdpQQiYojCb9YC88XS1cKgTpIY9ihp/jUDAux6tWwFQO87OoBtFEctHO1yS\n\tVyyOQXT3YkAKk5mpKudMJhkIzApo4zXvsEHb6xqsFKQ0BwlvTjsiaBphgSFtaC+153lA\n\taGf6sS6vkkRT8jD1pX5z6uz8Cpwi2k77RdcbF6XaM2tg7IzvaykZp471sWogOAp+Puii\n\tZ1bsvKUD4NINCQoPuxYVzxxmppYj/JYfZju3YZyecmW5IEE53D33pR/3PKPptuhT7LkW\n\t/gqjMBwzRaH38O8Rc7hmSvoWBaDgWfg7Ma3fyyRbz268yH5YD+XLEK8U+Hm+H5uJLVaD\n\twPiA==","X-Gm-Message-State":"AOAM533+meP6O1iJsX7bLrrCo+Qz+5OPkYbA7vfhSdoxm5V/a8Bufxlb\n\tZ/WZIXf2mwFStSQYK6b+rH9+YmZH0Um8is8VYp40Dw==","X-Google-Smtp-Source":"ABdhPJwvVPjcQyyrlCO4r/T/drEE9owNfoA9OoE7x4LSnyAF7BiJqGsdidMVD+Mdc5R/TuOwc98Ir8gHBn3rNAMn0eo=","X-Received":"by 2002:a2e:3a15:: with SMTP id\n\th21mr20829292lja.112.1594201679324; \n\tWed, 08 Jul 2020 02:47:59 -0700 (PDT)","MIME-Version":"1.0","References":"<20200704005227.21782-1-laurent.pinchart@ideasonboard.com>\n\t<20200704005227.21782-5-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20200704005227.21782-5-laurent.pinchart@ideasonboard.com>","From":"Naushir Patuck ","Date":"Wed, 8 Jul 2020 10:47:43 +0100","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH v2 04/12] libcamera: pipeline:\n\traspberrypi: Drop unused local variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]