[{"id":11193,"web_url":"https://patchwork.libcamera.org/comment/11193/","msgid":"<20200706085027.zq2rywscguexwuju@uno.localdomain>","date":"2020-07-06T08:50:27","subject":"Re: [libcamera-devel] [PATCH v2 03/12] libcamera: ipa_interface:\n\tAdd support for custom IPA data to configure()","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Sat, Jul 04, 2020 at 03:52:18AM +0300, Laurent Pinchart wrote:\n> Add two new parameters, ipaConfig and result, to the\n> IPAInterface::configure() function to allow pipeline handlers to pass\n> custom data to their IPA, and receive data back. Wire this through the\n> code base. The C API interface will be addressed separately, likely\n> through automation of the C <-> C++ translation.\n>\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n\nThanks\n  j\n\n> ---\n> Changes since v1:\n>\n> - Replace 'response' with 'result' in a comment\n> ---\n>  include/libcamera/internal/ipa_context_wrapper.h   |  4 +++-\n>  include/libcamera/ipa/ipa_interface.h              |  4 +++-\n>  src/ipa/libipa/ipa_interface_wrapper.cpp           |  5 ++++-\n>  src/ipa/raspberrypi/raspberrypi.cpp                |  8 ++++++--\n>  src/ipa/rkisp1/rkisp1.cpp                          |  8 ++++++--\n>  src/ipa/vimc/vimc.cpp                              |  4 +++-\n>  src/libcamera/ipa_context_wrapper.cpp              |  8 ++++++--\n>  src/libcamera/ipa_interface.cpp                    |  7 +++++++\n>  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp |  4 +++-\n>  src/libcamera/pipeline/rkisp1/rkisp1.cpp           |  4 +++-\n>  src/libcamera/proxy/ipa_proxy_linux.cpp            |  4 +++-\n>  src/libcamera/proxy/ipa_proxy_thread.cpp           | 11 ++++++++---\n>  test/ipa/ipa_wrappers_test.cpp                     |  8 ++++++--\n>  13 files changed, 61 insertions(+), 18 deletions(-)\n>\n> diff --git a/include/libcamera/internal/ipa_context_wrapper.h b/include/libcamera/internal/ipa_context_wrapper.h\n> index 4e6f791d18e6..8f767e844221 100644\n> --- a/include/libcamera/internal/ipa_context_wrapper.h\n> +++ b/include/libcamera/internal/ipa_context_wrapper.h\n> @@ -24,7 +24,9 @@ public:\n>  \tvoid stop() override;\n>  \tvoid configure(const CameraSensorInfo &sensorInfo,\n>  \t\t       const std::map<unsigned int, IPAStream> &streamConfig,\n> -\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls) override;\n> +\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n> +\t\t       const IPAOperationData &ipaConfig,\n> +\t\t       IPAOperationData *result) override;\n>\n>  \tvoid mapBuffers(const std::vector<IPABuffer> &buffers) override;\n>  \tvoid unmapBuffers(const std::vector<unsigned int> &ids) override;\n> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> index dc9fc714d564..5016ec25ea9c 100644\n> --- a/include/libcamera/ipa/ipa_interface.h\n> +++ b/include/libcamera/ipa/ipa_interface.h\n> @@ -158,7 +158,9 @@ public:\n>\n>  \tvirtual void configure(const CameraSensorInfo &sensorInfo,\n>  \t\t\t       const std::map<unsigned int, IPAStream> &streamConfig,\n> -\t\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls) = 0;\n> +\t\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n> +\t\t\t       const IPAOperationData &ipaConfig,\n> +\t\t\t       IPAOperationData *result) = 0;\n>\n>  \tvirtual void mapBuffers(const std::vector<IPABuffer> &buffers) = 0;\n>  \tvirtual void unmapBuffers(const std::vector<unsigned int> &ids) = 0;\n> diff --git a/src/ipa/libipa/ipa_interface_wrapper.cpp b/src/ipa/libipa/ipa_interface_wrapper.cpp\n> index 2a2e43abc708..cee532e3a747 100644\n> --- a/src/ipa/libipa/ipa_interface_wrapper.cpp\n> +++ b/src/ipa/libipa/ipa_interface_wrapper.cpp\n> @@ -166,7 +166,10 @@ void IPAInterfaceWrapper::configure(struct ipa_context *_ctx,\n>  \t\tentityControls.emplace(id, infoMaps[id]);\n>  \t}\n>\n> -\tctx->ipa_->configure(sensorInfo, ipaStreams, entityControls);\n> +\t/* \\todo Translate the ipaConfig and result. */\n> +\tIPAOperationData ipaConfig;\n> +\tctx->ipa_->configure(sensorInfo, ipaStreams, entityControls, ipaConfig,\n> +\t\t\t     nullptr);\n>  }\n>\n>  void IPAInterfaceWrapper::map_buffers(struct ipa_context *_ctx,\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index bc89ab58d03a..860be22ddb5d 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -78,7 +78,9 @@ public:\n>\n>  \tvoid configure(const CameraSensorInfo &sensorInfo,\n>  \t\t       const std::map<unsigned int, IPAStream> &streamConfig,\n> -\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls) override;\n> +\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n> +\t\t       const IPAOperationData &data,\n> +\t\t       IPAOperationData *response) override;\n>  \tvoid mapBuffers(const std::vector<IPABuffer> &buffers) override;\n>  \tvoid unmapBuffers(const std::vector<unsigned int> &ids) override;\n>  \tvoid processEvent(const IPAOperationData &event) override;\n> @@ -186,7 +188,9 @@ void IPARPi::setMode(const CameraSensorInfo &sensorInfo)\n>\n>  void IPARPi::configure(const CameraSensorInfo &sensorInfo,\n>  \t\t       const std::map<unsigned int, IPAStream> &streamConfig,\n> -\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls)\n> +\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n> +\t\t       const IPAOperationData &ipaConfig,\n> +\t\t       IPAOperationData *result)\n>  {\n>  \tif (entityControls.empty())\n>  \t\treturn;\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index bfd76cff75a4..4bb1627342fd 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -39,7 +39,9 @@ public:\n>\n>  \tvoid configure(const CameraSensorInfo &info,\n>  \t\t       const std::map<unsigned int, IPAStream> &streamConfig,\n> -\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls) override;\n> +\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n> +\t\t       const IPAOperationData &ipaConfig,\n> +\t\t       IPAOperationData *response) override;\n>  \tvoid mapBuffers(const std::vector<IPABuffer> &buffers) override;\n>  \tvoid unmapBuffers(const std::vector<unsigned int> &ids) override;\n>  \tvoid processEvent(const IPAOperationData &event) override;\n> @@ -76,7 +78,9 @@ private:\n>   */\n>  void IPARkISP1::configure(const CameraSensorInfo &info,\n>  \t\t\t  const std::map<unsigned int, IPAStream> &streamConfig,\n> -\t\t\t  const std::map<unsigned int, const ControlInfoMap &> &entityControls)\n> +\t\t\t  const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n> +\t\t\t  const IPAOperationData &ipaConfig,\n> +\t\t\t  IPAOperationData *result)\n>  {\n>  \tif (entityControls.empty())\n>  \t\treturn;\n> diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\n> index af278a482b8a..1593c92d80f3 100644\n> --- a/src/ipa/vimc/vimc.cpp\n> +++ b/src/ipa/vimc/vimc.cpp\n> @@ -39,7 +39,9 @@ public:\n>\n>  \tvoid configure(const CameraSensorInfo &sensorInfo,\n>  \t\t       const std::map<unsigned int, IPAStream> &streamConfig,\n> -\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls) override {}\n> +\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n> +\t\t       const IPAOperationData &ipaConfig,\n> +\t\t       IPAOperationData *result) override {}\n>  \tvoid mapBuffers(const std::vector<IPABuffer> &buffers) override {}\n>  \tvoid unmapBuffers(const std::vector<unsigned int> &ids) override {}\n>  \tvoid processEvent(const IPAOperationData &event) override {}\n> diff --git a/src/libcamera/ipa_context_wrapper.cpp b/src/libcamera/ipa_context_wrapper.cpp\n> index 471118f57cdc..231300ce0bec 100644\n> --- a/src/libcamera/ipa_context_wrapper.cpp\n> +++ b/src/libcamera/ipa_context_wrapper.cpp\n> @@ -110,10 +110,13 @@ void IPAContextWrapper::stop()\n>\n>  void IPAContextWrapper::configure(const CameraSensorInfo &sensorInfo,\n>  \t\t\t\t  const std::map<unsigned int, IPAStream> &streamConfig,\n> -\t\t\t\t  const std::map<unsigned int, const ControlInfoMap &> &entityControls)\n> +\t\t\t\t  const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n> +\t\t\t\t  const IPAOperationData &ipaConfig,\n> +\t\t\t\t  IPAOperationData *result)\n>  {\n>  \tif (intf_)\n> -\t\treturn intf_->configure(sensorInfo, streamConfig, entityControls);\n> +\t\treturn intf_->configure(sensorInfo, streamConfig,\n> +\t\t\t\t\tentityControls, ipaConfig, result);\n>\n>  \tif (!ctx_)\n>  \t\treturn;\n> @@ -174,6 +177,7 @@ void IPAContextWrapper::configure(const CameraSensorInfo &sensorInfo,\n>  \t\t++i;\n>  \t}\n>\n> +\t/* \\todo Translate the ipaConfig and reponse */\n>  \tctx_->ops->configure(ctx_, &sensor_info, c_streams, streamConfig.size(),\n>  \t\t\t     c_info_maps, entityControls.size());\n>  }\n> diff --git a/src/libcamera/ipa_interface.cpp b/src/libcamera/ipa_interface.cpp\n> index ebe47e1233a5..23fc56d7d48e 100644\n> --- a/src/libcamera/ipa_interface.cpp\n> +++ b/src/libcamera/ipa_interface.cpp\n> @@ -557,6 +557,8 @@ namespace libcamera {\n>   * \\param[in] sensorInfo Camera sensor information\n>   * \\param[in] streamConfig Configuration of all active streams\n>   * \\param[in] entityControls Controls provided by the pipeline entities\n> + * \\param[in] ipaConfig Pipeline-handler-specific configuration data\n> + * \\param[out] result Pipeline-handler-specific configuration result\n>   *\n>   * This method shall be called when the camera is started to inform the IPA of\n>   * the camera's streams and the sensor settings. The meaning of the numerical\n> @@ -566,6 +568,11 @@ namespace libcamera {\n>   * The \\a sensorInfo conveys information about the camera sensor settings that\n>   * the pipeline handler has selected for the configuration. The IPA may use\n>   * that information to tune its algorithms.\n> + *\n> + * The \\a ipaConfig and \\a result parameters carry custom data passed by the\n> + * pipeline handler to the IPA and back. The pipeline handler may set the \\a\n> + * result parameter to null if the IPA protocol doesn't need to pass a result\n> + * back through the configure() function.\n>   */\n>\n>  /**\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index f4966f8628ee..ab4b915156e1 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -1035,7 +1035,9 @@ int PipelineHandlerRPi::configureIPA(Camera *camera)\n>  \t}\n>\n>  \t/* Ready the IPA - it must know about the sensor resolution. */\n> -\tdata->ipa_->configure(sensorInfo, streamConfig, entityControls);\n> +\tIPAOperationData ipaConfig;\n> +\tdata->ipa_->configure(sensorInfo, streamConfig, entityControls,\n> +\t\t\t      ipaConfig, nullptr);\n>\n>  \treturn 0;\n>  }\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 3c3f3f3a8049..3a0195e05824 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -843,7 +843,9 @@ int PipelineHandlerRkISP1::start(Camera *camera)\n>  \tstd::map<unsigned int, const ControlInfoMap &> entityControls;\n>  \tentityControls.emplace(0, data->sensor_->controls());\n>\n> -\tdata->ipa_->configure(sensorInfo, streamConfig, entityControls);\n> +\tIPAOperationData ipaConfig;\n> +\tdata->ipa_->configure(sensorInfo, streamConfig, entityControls,\n> +\t\t\t      ipaConfig, nullptr);\n>\n>  \treturn ret;\n>  }\n> diff --git a/src/libcamera/proxy/ipa_proxy_linux.cpp b/src/libcamera/proxy/ipa_proxy_linux.cpp\n> index be34f20aa857..68eafb307b2a 100644\n> --- a/src/libcamera/proxy/ipa_proxy_linux.cpp\n> +++ b/src/libcamera/proxy/ipa_proxy_linux.cpp\n> @@ -31,7 +31,9 @@ public:\n>  \tvoid stop() override {}\n>  \tvoid configure(const CameraSensorInfo &sensorInfo,\n>  \t\t       const std::map<unsigned int, IPAStream> &streamConfig,\n> -\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls) override {}\n> +\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n> +\t\t       const IPAOperationData &ipaConfig,\n> +\t\t       IPAOperationData *result) override {}\n>  \tvoid mapBuffers(const std::vector<IPABuffer> &buffers) override {}\n>  \tvoid unmapBuffers(const std::vector<unsigned int> &ids) override {}\n>  \tvoid processEvent(const IPAOperationData &event) override {}\n> diff --git a/src/libcamera/proxy/ipa_proxy_thread.cpp b/src/libcamera/proxy/ipa_proxy_thread.cpp\n> index 6fbebed2ba72..aa403e22f297 100644\n> --- a/src/libcamera/proxy/ipa_proxy_thread.cpp\n> +++ b/src/libcamera/proxy/ipa_proxy_thread.cpp\n> @@ -31,7 +31,9 @@ public:\n>\n>  \tvoid configure(const CameraSensorInfo &sensorInfo,\n>  \t\t       const std::map<unsigned int, IPAStream> &streamConfig,\n> -\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls) override;\n> +\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n> +\t\t       const IPAOperationData &ipaConfig,\n> +\t\t       IPAOperationData *result) override;\n>  \tvoid mapBuffers(const std::vector<IPABuffer> &buffers) override;\n>  \tvoid unmapBuffers(const std::vector<unsigned int> &ids) override;\n>  \tvoid processEvent(const IPAOperationData &event) override;\n> @@ -129,9 +131,12 @@ void IPAProxyThread::stop()\n>\n>  void IPAProxyThread::configure(const CameraSensorInfo &sensorInfo,\n>  \t\t\t       const std::map<unsigned int, IPAStream> &streamConfig,\n> -\t\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls)\n> +\t\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n> +\t\t\t       const IPAOperationData &ipaConfig,\n> +\t\t\t       IPAOperationData *result)\n>  {\n> -\tipa_->configure(sensorInfo, streamConfig, entityControls);\n> +\tipa_->configure(sensorInfo, streamConfig, entityControls, ipaConfig,\n> +\t\t\tresult);\n>  }\n>\n>  void IPAProxyThread::mapBuffers(const std::vector<IPABuffer> &buffers)\n> diff --git a/test/ipa/ipa_wrappers_test.cpp b/test/ipa/ipa_wrappers_test.cpp\n> index aa7a9dcc6050..23c799da0663 100644\n> --- a/test/ipa/ipa_wrappers_test.cpp\n> +++ b/test/ipa/ipa_wrappers_test.cpp\n> @@ -69,7 +69,9 @@ public:\n>\n>  \tvoid configure(const CameraSensorInfo &sensorInfo,\n>  \t\t       const std::map<unsigned int, IPAStream> &streamConfig,\n> -\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls) override\n> +\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n> +\t\t       const IPAOperationData &ipaConfig,\n> +\t\t       IPAOperationData *result) override\n>  \t{\n>  \t\t/* Verify sensorInfo. */\n>  \t\tif (sensorInfo.outputSize.width != 2560 ||\n> @@ -317,7 +319,9 @@ protected:\n>  \t\t};\n>  \t\tstd::map<unsigned int, const ControlInfoMap &> controlInfo;\n>  \t\tcontrolInfo.emplace(42, subdev_->controls());\n> -\t\tret = INVOKE(configure, sensorInfo, config, controlInfo);\n> +\t\tIPAOperationData ipaConfig;\n> +\t\tret = INVOKE(configure, sensorInfo, config, controlInfo,\n> +\t\t\t     ipaConfig, nullptr);\n>  \t\tif (ret == TestFail)\n>  \t\t\treturn TestFail;\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3B2A0BD790\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon,  6 Jul 2020 08:46:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D55C260E01;\n\tMon,  6 Jul 2020 10:46:55 +0200 (CEST)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F1B67603B1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  6 Jul 2020 10:46:54 +0200 (CEST)","from uno.localdomain (host-79-34-235-173.business.telecomitalia.it\n\t[79.34.235.173]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id AE9A22000C;\n\tMon,  6 Jul 2020 08:46:53 +0000 (UTC)"],"X-Originating-IP":"79.34.235.173","Date":"Mon, 6 Jul 2020 10:50:27 +0200","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Message-ID":"<20200706085027.zq2rywscguexwuju@uno.localdomain>","References":"<20200704005227.21782-1-laurent.pinchart@ideasonboard.com>\n\t<20200704005227.21782-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200704005227.21782-4-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 03/12] libcamera: ipa_interface:\n\tAdd support for custom IPA data to configure()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":11423,"web_url":"https://patchwork.libcamera.org/comment/11423/","msgid":"<65501f62-5975-35e7-cdfc-3e332d106986@ideasonboard.com>","date":"2020-07-17T11:27:17","subject":"Re: [libcamera-devel] [PATCH v2 03/12] libcamera: ipa_interface:\n\tAdd support for custom IPA data to configure()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 04/07/2020 01:52, Laurent Pinchart wrote:\n> Add two new parameters, ipaConfig and result, to the\n> IPAInterface::configure() function to allow pipeline handlers to pass\n> custom data to their IPA, and receive data back. Wire this through the\n> code base. The C API interface will be addressed separately, likely\n> through automation of the C <-> C++ translation.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n> ---\n> Changes since v1:\n> \n> - Replace 'response' with 'result' in a comment\n> ---\n>  include/libcamera/internal/ipa_context_wrapper.h   |  4 +++-\n>  include/libcamera/ipa/ipa_interface.h              |  4 +++-\n>  src/ipa/libipa/ipa_interface_wrapper.cpp           |  5 ++++-\n>  src/ipa/raspberrypi/raspberrypi.cpp                |  8 ++++++--\n>  src/ipa/rkisp1/rkisp1.cpp                          |  8 ++++++--\n>  src/ipa/vimc/vimc.cpp                              |  4 +++-\n>  src/libcamera/ipa_context_wrapper.cpp              |  8 ++++++--\n>  src/libcamera/ipa_interface.cpp                    |  7 +++++++\n>  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp |  4 +++-\n>  src/libcamera/pipeline/rkisp1/rkisp1.cpp           |  4 +++-\n>  src/libcamera/proxy/ipa_proxy_linux.cpp            |  4 +++-\n>  src/libcamera/proxy/ipa_proxy_thread.cpp           | 11 ++++++++---\n>  test/ipa/ipa_wrappers_test.cpp                     |  8 ++++++--\n>  13 files changed, 61 insertions(+), 18 deletions(-)\n> \n> diff --git a/include/libcamera/internal/ipa_context_wrapper.h b/include/libcamera/internal/ipa_context_wrapper.h\n> index 4e6f791d18e6..8f767e844221 100644\n> --- a/include/libcamera/internal/ipa_context_wrapper.h\n> +++ b/include/libcamera/internal/ipa_context_wrapper.h\n> @@ -24,7 +24,9 @@ public:\n>  \tvoid stop() override;\n>  \tvoid configure(const CameraSensorInfo &sensorInfo,\n>  \t\t       const std::map<unsigned int, IPAStream> &streamConfig,\n> -\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls) override;\n> +\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n> +\t\t       const IPAOperationData &ipaConfig,\n> +\t\t       IPAOperationData *result) override;\n>  \n>  \tvoid mapBuffers(const std::vector<IPABuffer> &buffers) override;\n>  \tvoid unmapBuffers(const std::vector<unsigned int> &ids) override;\n> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> index dc9fc714d564..5016ec25ea9c 100644\n> --- a/include/libcamera/ipa/ipa_interface.h\n> +++ b/include/libcamera/ipa/ipa_interface.h\n> @@ -158,7 +158,9 @@ public:\n>  \n>  \tvirtual void configure(const CameraSensorInfo &sensorInfo,\n>  \t\t\t       const std::map<unsigned int, IPAStream> &streamConfig,\n> -\t\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls) = 0;\n> +\t\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n> +\t\t\t       const IPAOperationData &ipaConfig,\n> +\t\t\t       IPAOperationData *result) = 0;\n>  \n>  \tvirtual void mapBuffers(const std::vector<IPABuffer> &buffers) = 0;\n>  \tvirtual void unmapBuffers(const std::vector<unsigned int> &ids) = 0;\n> diff --git a/src/ipa/libipa/ipa_interface_wrapper.cpp b/src/ipa/libipa/ipa_interface_wrapper.cpp\n> index 2a2e43abc708..cee532e3a747 100644\n> --- a/src/ipa/libipa/ipa_interface_wrapper.cpp\n> +++ b/src/ipa/libipa/ipa_interface_wrapper.cpp\n> @@ -166,7 +166,10 @@ void IPAInterfaceWrapper::configure(struct ipa_context *_ctx,\n>  \t\tentityControls.emplace(id, infoMaps[id]);\n>  \t}\n>  \n> -\tctx->ipa_->configure(sensorInfo, ipaStreams, entityControls);\n> +\t/* \\todo Translate the ipaConfig and result. */\n> +\tIPAOperationData ipaConfig;\n> +\tctx->ipa_->configure(sensorInfo, ipaStreams, entityControls, ipaConfig,\n> +\t\t\t     nullptr);\n>  }\n>  \n>  void IPAInterfaceWrapper::map_buffers(struct ipa_context *_ctx,\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index bc89ab58d03a..860be22ddb5d 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -78,7 +78,9 @@ public:\n>  \n>  \tvoid configure(const CameraSensorInfo &sensorInfo,\n>  \t\t       const std::map<unsigned int, IPAStream> &streamConfig,\n> -\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls) override;\n> +\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n> +\t\t       const IPAOperationData &data,\n> +\t\t       IPAOperationData *response) override;\n>  \tvoid mapBuffers(const std::vector<IPABuffer> &buffers) override;\n>  \tvoid unmapBuffers(const std::vector<unsigned int> &ids) override;\n>  \tvoid processEvent(const IPAOperationData &event) override;\n> @@ -186,7 +188,9 @@ void IPARPi::setMode(const CameraSensorInfo &sensorInfo)\n>  \n>  void IPARPi::configure(const CameraSensorInfo &sensorInfo,\n>  \t\t       const std::map<unsigned int, IPAStream> &streamConfig,\n> -\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls)\n> +\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n> +\t\t       const IPAOperationData &ipaConfig,\n> +\t\t       IPAOperationData *result)\n>  {\n>  \tif (entityControls.empty())\n>  \t\treturn;\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index bfd76cff75a4..4bb1627342fd 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -39,7 +39,9 @@ public:\n>  \n>  \tvoid configure(const CameraSensorInfo &info,\n>  \t\t       const std::map<unsigned int, IPAStream> &streamConfig,\n> -\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls) override;\n> +\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n> +\t\t       const IPAOperationData &ipaConfig,\n> +\t\t       IPAOperationData *response) override;\n>  \tvoid mapBuffers(const std::vector<IPABuffer> &buffers) override;\n>  \tvoid unmapBuffers(const std::vector<unsigned int> &ids) override;\n>  \tvoid processEvent(const IPAOperationData &event) override;\n> @@ -76,7 +78,9 @@ private:\n>   */\n>  void IPARkISP1::configure(const CameraSensorInfo &info,\n>  \t\t\t  const std::map<unsigned int, IPAStream> &streamConfig,\n> -\t\t\t  const std::map<unsigned int, const ControlInfoMap &> &entityControls)\n> +\t\t\t  const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n> +\t\t\t  const IPAOperationData &ipaConfig,\n> +\t\t\t  IPAOperationData *result)\n>  {\n>  \tif (entityControls.empty())\n>  \t\treturn;\n> diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\n> index af278a482b8a..1593c92d80f3 100644\n> --- a/src/ipa/vimc/vimc.cpp\n> +++ b/src/ipa/vimc/vimc.cpp\n> @@ -39,7 +39,9 @@ public:\n>  \n>  \tvoid configure(const CameraSensorInfo &sensorInfo,\n>  \t\t       const std::map<unsigned int, IPAStream> &streamConfig,\n> -\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls) override {}\n> +\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n> +\t\t       const IPAOperationData &ipaConfig,\n> +\t\t       IPAOperationData *result) override {}\n>  \tvoid mapBuffers(const std::vector<IPABuffer> &buffers) override {}\n>  \tvoid unmapBuffers(const std::vector<unsigned int> &ids) override {}\n>  \tvoid processEvent(const IPAOperationData &event) override {}\n> diff --git a/src/libcamera/ipa_context_wrapper.cpp b/src/libcamera/ipa_context_wrapper.cpp\n> index 471118f57cdc..231300ce0bec 100644\n> --- a/src/libcamera/ipa_context_wrapper.cpp\n> +++ b/src/libcamera/ipa_context_wrapper.cpp\n> @@ -110,10 +110,13 @@ void IPAContextWrapper::stop()\n>  \n>  void IPAContextWrapper::configure(const CameraSensorInfo &sensorInfo,\n>  \t\t\t\t  const std::map<unsigned int, IPAStream> &streamConfig,\n> -\t\t\t\t  const std::map<unsigned int, const ControlInfoMap &> &entityControls)\n> +\t\t\t\t  const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n> +\t\t\t\t  const IPAOperationData &ipaConfig,\n> +\t\t\t\t  IPAOperationData *result)\n>  {\n>  \tif (intf_)\n> -\t\treturn intf_->configure(sensorInfo, streamConfig, entityControls);\n> +\t\treturn intf_->configure(sensorInfo, streamConfig,\n> +\t\t\t\t\tentityControls, ipaConfig, result);\n>  \n>  \tif (!ctx_)\n>  \t\treturn;\n> @@ -174,6 +177,7 @@ void IPAContextWrapper::configure(const CameraSensorInfo &sensorInfo,\n>  \t\t++i;\n>  \t}\n>  \n> +\t/* \\todo Translate the ipaConfig and reponse */\n>  \tctx_->ops->configure(ctx_, &sensor_info, c_streams, streamConfig.size(),\n>  \t\t\t     c_info_maps, entityControls.size());\n>  }\n> diff --git a/src/libcamera/ipa_interface.cpp b/src/libcamera/ipa_interface.cpp\n> index ebe47e1233a5..23fc56d7d48e 100644\n> --- a/src/libcamera/ipa_interface.cpp\n> +++ b/src/libcamera/ipa_interface.cpp\n> @@ -557,6 +557,8 @@ namespace libcamera {\n>   * \\param[in] sensorInfo Camera sensor information\n>   * \\param[in] streamConfig Configuration of all active streams\n>   * \\param[in] entityControls Controls provided by the pipeline entities\n> + * \\param[in] ipaConfig Pipeline-handler-specific configuration data\n> + * \\param[out] result Pipeline-handler-specific configuration result\n>   *\n>   * This method shall be called when the camera is started to inform the IPA of\n>   * the camera's streams and the sensor settings. The meaning of the numerical\n> @@ -566,6 +568,11 @@ namespace libcamera {\n>   * The \\a sensorInfo conveys information about the camera sensor settings that\n>   * the pipeline handler has selected for the configuration. The IPA may use\n>   * that information to tune its algorithms.\n> + *\n> + * The \\a ipaConfig and \\a result parameters carry custom data passed by the\n> + * pipeline handler to the IPA and back. The pipeline handler may set the \\a\n> + * result parameter to null if the IPA protocol doesn't need to pass a result\n> + * back through the configure() function.\n>   */\n>  \n>  /**\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index f4966f8628ee..ab4b915156e1 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -1035,7 +1035,9 @@ int PipelineHandlerRPi::configureIPA(Camera *camera)\n>  \t}\n>  \n>  \t/* Ready the IPA - it must know about the sensor resolution. */\n> -\tdata->ipa_->configure(sensorInfo, streamConfig, entityControls);\n> +\tIPAOperationData ipaConfig;\n> +\tdata->ipa_->configure(sensorInfo, streamConfig, entityControls,\n> +\t\t\t      ipaConfig, nullptr);\n>  \n>  \treturn 0;\n>  }\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 3c3f3f3a8049..3a0195e05824 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -843,7 +843,9 @@ int PipelineHandlerRkISP1::start(Camera *camera)\n>  \tstd::map<unsigned int, const ControlInfoMap &> entityControls;\n>  \tentityControls.emplace(0, data->sensor_->controls());\n>  \n> -\tdata->ipa_->configure(sensorInfo, streamConfig, entityControls);\n> +\tIPAOperationData ipaConfig;\n> +\tdata->ipa_->configure(sensorInfo, streamConfig, entityControls,\n> +\t\t\t      ipaConfig, nullptr);\n>  \n>  \treturn ret;\n>  }\n> diff --git a/src/libcamera/proxy/ipa_proxy_linux.cpp b/src/libcamera/proxy/ipa_proxy_linux.cpp\n> index be34f20aa857..68eafb307b2a 100644\n> --- a/src/libcamera/proxy/ipa_proxy_linux.cpp\n> +++ b/src/libcamera/proxy/ipa_proxy_linux.cpp\n> @@ -31,7 +31,9 @@ public:\n>  \tvoid stop() override {}\n>  \tvoid configure(const CameraSensorInfo &sensorInfo,\n>  \t\t       const std::map<unsigned int, IPAStream> &streamConfig,\n> -\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls) override {}\n> +\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n> +\t\t       const IPAOperationData &ipaConfig,\n> +\t\t       IPAOperationData *result) override {}\n>  \tvoid mapBuffers(const std::vector<IPABuffer> &buffers) override {}\n>  \tvoid unmapBuffers(const std::vector<unsigned int> &ids) override {}\n>  \tvoid processEvent(const IPAOperationData &event) override {}\n> diff --git a/src/libcamera/proxy/ipa_proxy_thread.cpp b/src/libcamera/proxy/ipa_proxy_thread.cpp\n> index 6fbebed2ba72..aa403e22f297 100644\n> --- a/src/libcamera/proxy/ipa_proxy_thread.cpp\n> +++ b/src/libcamera/proxy/ipa_proxy_thread.cpp\n> @@ -31,7 +31,9 @@ public:\n>  \n>  \tvoid configure(const CameraSensorInfo &sensorInfo,\n>  \t\t       const std::map<unsigned int, IPAStream> &streamConfig,\n> -\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls) override;\n> +\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n> +\t\t       const IPAOperationData &ipaConfig,\n> +\t\t       IPAOperationData *result) override;\n>  \tvoid mapBuffers(const std::vector<IPABuffer> &buffers) override;\n>  \tvoid unmapBuffers(const std::vector<unsigned int> &ids) override;\n>  \tvoid processEvent(const IPAOperationData &event) override;\n> @@ -129,9 +131,12 @@ void IPAProxyThread::stop()\n>  \n>  void IPAProxyThread::configure(const CameraSensorInfo &sensorInfo,\n>  \t\t\t       const std::map<unsigned int, IPAStream> &streamConfig,\n> -\t\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls)\n> +\t\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n> +\t\t\t       const IPAOperationData &ipaConfig,\n> +\t\t\t       IPAOperationData *result)\n>  {\n> -\tipa_->configure(sensorInfo, streamConfig, entityControls);\n> +\tipa_->configure(sensorInfo, streamConfig, entityControls, ipaConfig,\n> +\t\t\tresult);\n>  }\n>  \n>  void IPAProxyThread::mapBuffers(const std::vector<IPABuffer> &buffers)\n> diff --git a/test/ipa/ipa_wrappers_test.cpp b/test/ipa/ipa_wrappers_test.cpp\n> index aa7a9dcc6050..23c799da0663 100644\n> --- a/test/ipa/ipa_wrappers_test.cpp\n> +++ b/test/ipa/ipa_wrappers_test.cpp\n> @@ -69,7 +69,9 @@ public:\n>  \n>  \tvoid configure(const CameraSensorInfo &sensorInfo,\n>  \t\t       const std::map<unsigned int, IPAStream> &streamConfig,\n> -\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls) override\n> +\t\t       const std::map<unsigned int, const ControlInfoMap &> &entityControls,\n> +\t\t       const IPAOperationData &ipaConfig,\n> +\t\t       IPAOperationData *result) override\n>  \t{\n>  \t\t/* Verify sensorInfo. */\n>  \t\tif (sensorInfo.outputSize.width != 2560 ||\n> @@ -317,7 +319,9 @@ protected:\n>  \t\t};\n>  \t\tstd::map<unsigned int, const ControlInfoMap &> controlInfo;\n>  \t\tcontrolInfo.emplace(42, subdev_->controls());\n> -\t\tret = INVOKE(configure, sensorInfo, config, controlInfo);\n> +\t\tIPAOperationData ipaConfig;\n> +\t\tret = INVOKE(configure, sensorInfo, config, controlInfo,\n> +\t\t\t     ipaConfig, nullptr);\n\nThis change has introduced the following coverity warning. If you supply a\npatch to fix this issue, please add the following tag:\n\nReported-by: Coverity CID=294428\n\n>     CID 294428:  Uninitialized variables  (UNINIT)\n>     Using uninitialized value \"ipaConfig.operation\" when calling \"IPAOperationData\".\n\n\nAlternatively, if you believe it's a false positive, let me know and\nI'll close it.\n\n>  \t\tif (ret == TestFail)\n>  \t\t\treturn TestFail;\n>  \n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E86DCBD792\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 17 Jul 2020 11:27:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4789E60548;\n\tFri, 17 Jul 2020 13:27:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D6D0A6053C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 17 Jul 2020 13:27:20 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 45804561;\n\tFri, 17 Jul 2020 13:27:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RTENvDI9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594985240;\n\tbh=KYtIhe+FxGAV0b3vvnEudfar8kYODdQz0LaFc42gimU=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=RTENvDI9sKC9tkrrP5Te7xVE4vnhXuQxvKkQ4CWDGak9HdUJC5DH+e7QWDp1fC3jX\n\toAXh09PwtDncHqI3Z7OFLZhFbMFPDImWc6ISiCbk3jIpdb3a7rP89s/MbCHLq+qp+/\n\t/nH/OrjerQkgmeg7qHpqSrKnUhgoIUmq+j35gptc=","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200704005227.21782-1-laurent.pinchart@ideasonboard.com>\n\t<20200704005227.21782-4-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<65501f62-5975-35e7-cdfc-3e332d106986@ideasonboard.com>","Date":"Fri, 17 Jul 2020 12:27:17 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.8.0","MIME-Version":"1.0","In-Reply-To":"<20200704005227.21782-4-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 03/12] libcamera: ipa_interface:\n\tAdd support for custom IPA data to configure()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]