[{"id":11188,"web_url":"https://patchwork.libcamera.org/comment/11188/","msgid":"<20200706080423.grmwnxtycozh2hvg@uno.localdomain>","date":"2020-07-06T08:04:23","subject":"Re: [libcamera-devel] [PATCH v3 8/8] android: camera_device: Remove\n\tsingle buffer restriction.","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran\n\nOn Fri, Jul 03, 2020 at 01:39:19PM +0100, Kieran Bingham wrote:\n> A capture request is no longer limited to a single output buffer.\n> Remove the limitation, but (for now) keep the check to ensure that\n> at least one buffer is always provided.\n>\n> Signed-off-by: Kieran Bingham \n> Reviewed-by: Niklas Söderlund \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/android/camera_device.cpp | 5 ++---\n> 1 file changed, 2 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 3d21e59af258..1f85e7e535f5 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1050,9 +1050,8 @@ FrameBuffer *CameraDevice::createFrameBuffer(const buffer_handle_t camera3buffer\n>\n> int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Request)\n> {\n> -\tif (camera3Request->num_output_buffers != 1) {\n> -\t\tLOG(HAL, Error) << \"Invalid number of output buffers: \"\n> -\t\t\t\t<< camera3Request->num_output_buffers;\n> +\tif (!camera3Request->num_output_buffers) {\n> +\t\tLOG(HAL, Error) << \"No output buffers provided\";\n> \t\treturn -EINVAL;\n> \t}\n>\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7DD4DBD790\n\tfor ;\n\tMon, 6 Jul 2020 08:00:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4B58D60E01;\n\tMon, 6 Jul 2020 10:00:52 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7DF44603B1\n\tfor ;\n\tMon, 6 Jul 2020 10:00:51 +0200 (CEST)","from uno.localdomain (host-79-34-235-173.business.telecomitalia.it\n\t[79.34.235.173]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 54FD724000C;\n\tMon, 6 Jul 2020 08:00:49 +0000 (UTC)"],"Date":"Mon, 6 Jul 2020 10:04:23 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20200706080423.grmwnxtycozh2hvg@uno.localdomain>","References":"<20200703123919.2223048-1-kieran.bingham@ideasonboard.com>\n\t<20200703123919.2223048-9-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200703123919.2223048-9-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 8/8] android: camera_device: Remove\n\tsingle buffer restriction.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]