[{"id":11159,"web_url":"https://patchwork.libcamera.org/comment/11159/","msgid":"<20200703143244.GC14255@pendragon.ideasonboard.com>","date":"2020-07-03T14:32:44","subject":"Re: [libcamera-devel] [PATCH v3 5/8] android: camera_device: Create\n\tthe Request and Camera3RequestDescriptor together","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Jul 03, 2020 at 01:39:16PM +0100, Kieran Bingham wrote:\n> Move the construction of the Request higher in the code flow\n> so that multiple buffers and streams can be added where required.\n> \n> Signed-off-by: Kieran Bingham \n> Reviewed-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_device.cpp | 7 +++++--\n> 1 file changed, 5 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 73cfab532cf5..4e77a92dbea5 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1066,6 +1066,10 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> \tCamera3RequestDescriptor *descriptor =\n> \t\tnew Camera3RequestDescriptor(camera3Request->frame_number,\n> \t\t\t\t\t camera3Request->num_output_buffers);\n> +\n> +\tRequest *request =\n> +\t\tcamera_->createRequest(reinterpret_cast(descriptor));\n> +\n> \tfor (unsigned int i = 0; i < descriptor->numBuffers; ++i) {\n> \t\t/*\n> \t\t * Keep track of which stream the request belongs to and store\n> @@ -1085,12 +1089,11 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> \tFrameBuffer *buffer = createFrameBuffer(*camera3Buffers[0].buffer);\n> \tif (!buffer) {\n> \t\tLOG(HAL, Error) << \"Failed to create buffer\";\n> +\t\tdelete request;\n> \t\tdelete descriptor;\n> \t\treturn -ENOMEM;\n> \t}\n> \n> -\tRequest *request =\n> -\t\tcamera_->createRequest(reinterpret_cast(descriptor));\n> \trequest->addBuffer(stream, buffer);\n> \n> \tint ret = camera_->queueRequest(request);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5D682BFFE2\n\tfor ;\n\tFri, 3 Jul 2020 14:32:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E93A1603B1;\n\tFri, 3 Jul 2020 16:32:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 451E3603AE\n\tfor ;\n\tFri, 3 Jul 2020 16:32:49 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A635A29E;\n\tFri, 3 Jul 2020 16:32:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qJxM/ko8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593786768;\n\tbh=qkWvg/x/d5jSYpPDmY0Q1U0MlCsiH5WmFVDCh9TldZc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qJxM/ko8V02tlWVjM4EQEYEf7mUAuK2/N3o8V2fchvRTM7VFw+7ggI3bDpB5/CT/s\n\tYM6hzlbDALdgu66jxcnso83R0GZZ1Y1hkyT6YzOM4pcjcMruA9akU276AdValxa2ch\n\t8y86oGjHRK+nLtuvKeTmlUIhAaMFw2lK8xbzo9KM=","Date":"Fri, 3 Jul 2020 17:32:44 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200703143244.GC14255@pendragon.ideasonboard.com>","References":"<20200703123919.2223048-1-kieran.bingham@ideasonboard.com>\n\t<20200703123919.2223048-6-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200703123919.2223048-6-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 5/8] android: camera_device: Create\n\tthe Request and Camera3RequestDescriptor together","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11189,"web_url":"https://patchwork.libcamera.org/comment/11189/","msgid":"<20200706080528.a7p77pkdhqjmk463@uno.localdomain>","date":"2020-07-06T08:05:28","subject":"Re: [libcamera-devel] [PATCH v3 5/8] android: camera_device: Create\n\tthe Request and Camera3RequestDescriptor together","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"On Fri, Jul 03, 2020 at 01:39:16PM +0100, Kieran Bingham wrote:\n> Move the construction of the Request higher in the code flow\n> so that multiple buffers and streams can be added where required.\n>\n> Signed-off-by: Kieran Bingham \n> Reviewed-by: Niklas Söderlund \n> ---\n> src/android/camera_device.cpp | 7 +++++--\n> 1 file changed, 5 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 73cfab532cf5..4e77a92dbea5 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1066,6 +1066,10 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> \tCamera3RequestDescriptor *descriptor =\n> \t\tnew Camera3RequestDescriptor(camera3Request->frame_number,\n> \t\t\t\t\t camera3Request->num_output_buffers);\n> +\n> +\tRequest *request =\n> +\t\tcamera_->createRequest(reinterpret_cast(descriptor));\n> +\n> \tfor (unsigned int i = 0; i < descriptor->numBuffers; ++i) {\n> \t\t/*\n> \t\t * Keep track of which stream the request belongs to and store\n> @@ -1085,12 +1089,11 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> \tFrameBuffer *buffer = createFrameBuffer(*camera3Buffers[0].buffer);\n> \tif (!buffer) {\n> \t\tLOG(HAL, Error) << \"Failed to create buffer\";\n> +\t\tdelete request;\n> \t\tdelete descriptor;\n\nThis is a replic of the below queueRequest() error path. Might be\nworth creating a label and jump to it.\n\nAnywya\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> \t\treturn -ENOMEM;\n> \t}\n>\n> -\tRequest *request =\n> -\t\tcamera_->createRequest(reinterpret_cast(descriptor));\n> \trequest->addBuffer(stream, buffer);\n>\n> \tint ret = camera_->queueRequest(request);\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B43AFBD790\n\tfor ;\n\tMon, 6 Jul 2020 08:01:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9082460E01;\n\tMon, 6 Jul 2020 10:01:56 +0200 (CEST)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A941E603B1\n\tfor ;\n\tMon, 6 Jul 2020 10:01:55 +0200 (CEST)","from uno.localdomain (host-79-34-235-173.business.telecomitalia.it\n\t[79.34.235.173]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id F278540022;\n\tMon, 6 Jul 2020 08:01:54 +0000 (UTC)"],"X-Originating-IP":"79.34.235.173","Date":"Mon, 6 Jul 2020 10:05:28 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20200706080528.a7p77pkdhqjmk463@uno.localdomain>","References":"<20200703123919.2223048-1-kieran.bingham@ideasonboard.com>\n\t<20200703123919.2223048-6-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200703123919.2223048-6-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 5/8] android: camera_device: Create\n\tthe Request and Camera3RequestDescriptor together","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11203,"web_url":"https://patchwork.libcamera.org/comment/11203/","msgid":"","date":"2020-07-06T09:36:33","subject":"Re: [libcamera-devel] [PATCH v3 5/8] android: camera_device: Create\n\tthe Request and Camera3RequestDescriptor together","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 06/07/2020 09:05, Jacopo Mondi wrote:\n> On Fri, Jul 03, 2020 at 01:39:16PM +0100, Kieran Bingham wrote:\n>> Move the construction of the Request higher in the code flow\n>> so that multiple buffers and streams can be added where required.\n>>\n>> Signed-off-by: Kieran Bingham \n>> Reviewed-by: Niklas Söderlund \n>> ---\n>> src/android/camera_device.cpp | 7 +++++--\n>> 1 file changed, 5 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n>> index 73cfab532cf5..4e77a92dbea5 100644\n>> --- a/src/android/camera_device.cpp\n>> +++ b/src/android/camera_device.cpp\n>> @@ -1066,6 +1066,10 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n>> \tCamera3RequestDescriptor *descriptor =\n>> \t\tnew Camera3RequestDescriptor(camera3Request->frame_number,\n>> \t\t\t\t\t camera3Request->num_output_buffers);\n>> +\n>> +\tRequest *request =\n>> +\t\tcamera_->createRequest(reinterpret_cast(descriptor));\n>> +\n>> \tfor (unsigned int i = 0; i < descriptor->numBuffers; ++i) {\n>> \t\t/*\n>> \t\t * Keep track of which stream the request belongs to and store\n>> @@ -1085,12 +1089,11 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n>> \tFrameBuffer *buffer = createFrameBuffer(*camera3Buffers[0].buffer);\n>> \tif (!buffer) {\n>> \t\tLOG(HAL, Error) << \"Failed to create buffer\";\n>> +\t\tdelete request;\n>> \t\tdelete descriptor;\n> \n> This is a replic of the below queueRequest() error path. Might be\n> worth creating a label and jump to it.\n> \n\nGiven the need to add the FrameBuffer's to the Camera3RequestDescriptor,\nhow about we add a unique_ptr to that, so that we only have\nto track the lifetime of the Camera3RequestDescriptor manually?\n\n--\nKieran\n\n\n> Anywya\n> Reviewed-by: Jacopo Mondi \n> \n> Thanks\n> j\n> \n>> \t\treturn -ENOMEM;\n>> \t}\n>>\n>> -\tRequest *request =\n>> -\t\tcamera_->createRequest(reinterpret_cast(descriptor));\n>> \trequest->addBuffer(stream, buffer);\n>>\n>> \tint ret = camera_->queueRequest(request);\n>> --\n>> 2.25.1\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BED59BD790\n\tfor ;\n\tMon, 6 Jul 2020 09:36:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5A86960C59;\n\tMon, 6 Jul 2020 11:36:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B9327603B1\n\tfor ;\n\tMon, 6 Jul 2020 11:36:36 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2495197E;\n\tMon, 6 Jul 2020 11:36:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Oc3sQniN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594028196;\n\tbh=jfyKLwXvB47jWXJoENJNVwylNyBH5Rg7/ekYVi87GoY=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=Oc3sQniNfWRSOHIrRaBcSu9ErcVzKfe7YekU4jOJA8wiYNULdR1G9lwZiQ3/iRbRP\n\tvb0Mr4S2/U5nCtCCHY1yma6BvVG+cyzKJY53S6moGN+z3MlT5dXTbNQIpR440oLjIl\n\t6p1lI0+kM8SMrGPtShEMr+QZx5w3zYPPfpmrJNk4=","To":"Jacopo Mondi ","References":"<20200703123919.2223048-1-kieran.bingham@ideasonboard.com>\n\t<20200703123919.2223048-6-kieran.bingham@ideasonboard.com>\n\t<20200706080528.a7p77pkdhqjmk463@uno.localdomain>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 6 Jul 2020 10:36:33 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.8.0","MIME-Version":"1.0","In-Reply-To":"<20200706080528.a7p77pkdhqjmk463@uno.localdomain>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v3 5/8] android: camera_device: Create\n\tthe Request and Camera3RequestDescriptor together","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11205,"web_url":"https://patchwork.libcamera.org/comment/11205/","msgid":"<20200706102504.6ux6hatwfkqzytlc@uno.localdomain>","date":"2020-07-06T10:25:04","subject":"Re: [libcamera-devel] [PATCH v3 5/8] android: camera_device: Create\n\tthe Request and Camera3RequestDescriptor together","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Mon, Jul 06, 2020 at 10:36:33AM +0100, Kieran Bingham wrote:\n> Hi Jacopo,\n>\n> On 06/07/2020 09:05, Jacopo Mondi wrote:\n> > On Fri, Jul 03, 2020 at 01:39:16PM +0100, Kieran Bingham wrote:\n> >> Move the construction of the Request higher in the code flow\n> >> so that multiple buffers and streams can be added where required.\n> >>\n> >> Signed-off-by: Kieran Bingham \n> >> Reviewed-by: Niklas Söderlund \n> >> ---\n> >> src/android/camera_device.cpp | 7 +++++--\n> >> 1 file changed, 5 insertions(+), 2 deletions(-)\n> >>\n> >> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> >> index 73cfab532cf5..4e77a92dbea5 100644\n> >> --- a/src/android/camera_device.cpp\n> >> +++ b/src/android/camera_device.cpp\n> >> @@ -1066,6 +1066,10 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> >> \tCamera3RequestDescriptor *descriptor =\n> >> \t\tnew Camera3RequestDescriptor(camera3Request->frame_number,\n> >> \t\t\t\t\t camera3Request->num_output_buffers);\n> >> +\n> >> +\tRequest *request =\n> >> +\t\tcamera_->createRequest(reinterpret_cast(descriptor));\n> >> +\n> >> \tfor (unsigned int i = 0; i < descriptor->numBuffers; ++i) {\n> >> \t\t/*\n> >> \t\t * Keep track of which stream the request belongs to and store\n> >> @@ -1085,12 +1089,11 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> >> \tFrameBuffer *buffer = createFrameBuffer(*camera3Buffers[0].buffer);\n> >> \tif (!buffer) {\n> >> \t\tLOG(HAL, Error) << \"Failed to create buffer\";\n> >> +\t\tdelete request;\n> >> \t\tdelete descriptor;\n> >\n> > This is a replic of the below queueRequest() error path. Might be\n> > worth creating a label and jump to it.\n> >\n>\n> Given the need to add the FrameBuffer's to the Camera3RequestDescriptor,\n> how about we add a unique_ptr to that, so that we only have\n> to track the lifetime of the Camera3RequestDescriptor manually?\n\nSeem like a good idea :)\n\nWould you like to send a v4 or fixes on top ?\n\n>\n> --\n> Kieran\n>\n>\n> > Anywya\n> > Reviewed-by: Jacopo Mondi \n> >\n> > Thanks\n> > j\n> >\n> >> \t\treturn -ENOMEM;\n> >> \t}\n> >>\n> >> -\tRequest *request =\n> >> -\t\tcamera_->createRequest(reinterpret_cast(descriptor));\n> >> \trequest->addBuffer(stream, buffer);\n> >>\n> >> \tint ret = camera_->queueRequest(request);\n> >> --\n> >> 2.25.1\n> >>\n> >> _______________________________________________\n> >> libcamera-devel mailing list\n> >> libcamera-devel@lists.libcamera.org\n> >> https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AD3C5BD790\n\tfor ;\n\tMon, 6 Jul 2020 10:21:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 488F060E01;\n\tMon, 6 Jul 2020 12:21:32 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6623E603AA\n\tfor ;\n\tMon, 6 Jul 2020 12:21:31 +0200 (CEST)","from uno.localdomain (host-79-34-235-173.business.telecomitalia.it\n\t[79.34.235.173]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id B2E80C0003;\n\tMon, 6 Jul 2020 10:21:30 +0000 (UTC)"],"X-Originating-IP":"79.34.235.173","Date":"Mon, 6 Jul 2020 12:25:04 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20200706102504.6ux6hatwfkqzytlc@uno.localdomain>","References":"<20200703123919.2223048-1-kieran.bingham@ideasonboard.com>\n\t<20200703123919.2223048-6-kieran.bingham@ideasonboard.com>\n\t<20200706080528.a7p77pkdhqjmk463@uno.localdomain>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v3 5/8] android: camera_device: Create\n\tthe Request and Camera3RequestDescriptor together","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11227,"web_url":"https://patchwork.libcamera.org/comment/11227/","msgid":"","date":"2020-07-06T22:28:07","subject":"Re: [libcamera-devel] [PATCH v3 5/8] android: camera_device: Create\n\tthe Request and Camera3RequestDescriptor together","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 06/07/2020 11:25, Jacopo Mondi wrote:\n> Hi Kieran,\n> \n> On Mon, Jul 06, 2020 at 10:36:33AM +0100, Kieran Bingham wrote:\n>> Hi Jacopo,\n>>\n>> On 06/07/2020 09:05, Jacopo Mondi wrote:\n>>> On Fri, Jul 03, 2020 at 01:39:16PM +0100, Kieran Bingham wrote:\n>>>> Move the construction of the Request higher in the code flow\n>>>> so that multiple buffers and streams can be added where required.\n>>>>\n>>>> Signed-off-by: Kieran Bingham \n>>>> Reviewed-by: Niklas Söderlund \n>>>> ---\n>>>> src/android/camera_device.cpp | 7 +++++--\n>>>> 1 file changed, 5 insertions(+), 2 deletions(-)\n>>>>\n>>>> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n>>>> index 73cfab532cf5..4e77a92dbea5 100644\n>>>> --- a/src/android/camera_device.cpp\n>>>> +++ b/src/android/camera_device.cpp\n>>>> @@ -1066,6 +1066,10 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n>>>> \tCamera3RequestDescriptor *descriptor =\n>>>> \t\tnew Camera3RequestDescriptor(camera3Request->frame_number,\n>>>> \t\t\t\t\t camera3Request->num_output_buffers);\n>>>> +\n>>>> +\tRequest *request =\n>>>> +\t\tcamera_->createRequest(reinterpret_cast(descriptor));\n>>>> +\n>>>> \tfor (unsigned int i = 0; i < descriptor->numBuffers; ++i) {\n>>>> \t\t/*\n>>>> \t\t * Keep track of which stream the request belongs to and store\n>>>> @@ -1085,12 +1089,11 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n>>>> \tFrameBuffer *buffer = createFrameBuffer(*camera3Buffers[0].buffer);\n>>>> \tif (!buffer) {\n>>>> \t\tLOG(HAL, Error) << \"Failed to create buffer\";\n>>>> +\t\tdelete request;\n>>>> \t\tdelete descriptor;\n>>>\n>>> This is a replic of the below queueRequest() error path. Might be\n>>> worth creating a label and jump to it.\n>>>\n>>\n>> Given the need to add the FrameBuffer's to the Camera3RequestDescriptor,\n>> how about we add a unique_ptr to that, so that we only have\n>> to track the lifetime of the Camera3RequestDescriptor manually?\n> \n> Seem like a good idea :)\n\nTurns out it was a really bad idea ;-)\n\nI had forgotten that the Request is deleted by the libcamera core after\ncompletion, so by tracking the Request as a unique object, I introduced\na double-free.\n\nOoops.\n\nSo we should only delete Requests in this function if they are not\nsuccessfully submitted.\n\n--\nv5....\n\n> \n> Would you like to send a v4 or fixes on top ?\n> \n>>\n>> --\n>> Kieran\n>>\n>>\n>>> Anywya\n>>> Reviewed-by: Jacopo Mondi \n>>>\n>>> Thanks\n>>> j\n>>>\n>>>> \t\treturn -ENOMEM;\n>>>> \t}\n>>>>\n>>>> -\tRequest *request =\n>>>> -\t\tcamera_->createRequest(reinterpret_cast(descriptor));\n>>>> \trequest->addBuffer(stream, buffer);\n>>>>\n>>>> \tint ret = camera_->queueRequest(request);\n>>>> --\n>>>> 2.25.1\n>>>>\n>>>> _______________________________________________\n>>>> libcamera-devel mailing list\n>>>> libcamera-devel@lists.libcamera.org\n>>>> https://lists.libcamera.org/listinfo/libcamera-devel\n>>\n>> --\n>> Regards\n>> --\n>> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BB322BD790\n\tfor ;\n\tMon, 6 Jul 2020 22:28:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2951860E14;\n\tTue, 7 Jul 2020 00:28:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AA7F0609A9\n\tfor ;\n\tTue, 7 Jul 2020 00:28:12 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 43CF3AC6;\n\tTue, 7 Jul 2020 00:28:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WO7SAcLn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594074491;\n\tbh=O+qlngR44psqR4r2EA4sz7JCEdJLb5/QWWZwSPGdpSM=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=WO7SAcLnPEbj2B93p3yNfRL2waI46q21jGu/9RjjKIBY1xMLGOTOO+3kvF1H6HfWS\n\ti+D9oMX1jN/So3Wrm7tfb+p71o65Gt7HArdoTDiZD4AL5n+61Nvp0Wr2NoN1LtNGJg\n\ttbnD7HG3Dy5SzofPWlb52cnKfOxENex54nn1JU6I=","To":"Jacopo Mondi ","References":"<20200703123919.2223048-1-kieran.bingham@ideasonboard.com>\n\t<20200703123919.2223048-6-kieran.bingham@ideasonboard.com>\n\t<20200706080528.a7p77pkdhqjmk463@uno.localdomain>\n\t\n\t<20200706102504.6ux6hatwfkqzytlc@uno.localdomain>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 6 Jul 2020 23:28:07 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.8.0","MIME-Version":"1.0","In-Reply-To":"<20200706102504.6ux6hatwfkqzytlc@uno.localdomain>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v3 5/8] android: camera_device: Create\n\tthe Request and Camera3RequestDescriptor together","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]