[{"id":1225,"web_url":"https://patchwork.libcamera.org/comment/1225/","msgid":"<20190402180332.GZ23466@bigcity.dyn.berto.se>","date":"2019-04-02T18:03:32","subject":"Re: [libcamera-devel] [PATCH v7 02/13] libcamera: geometry: Add\n\tSize structure","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your patch.\n\nOn 2019-04-02 19:12:58 +0200, Jacopo Mondi wrote:\n> Add a simple Size structure that contains an image width and height.\n> \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/geometry.cpp | 29 +++++++++++++++++++++++++++++\n> src/libcamera/include/geometry.h | 15 +++++++++++++++\n> 2 files changed, 44 insertions(+)\n> \n> diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\n> index f76001d94562..d0c63c353ab3 100644\n> --- a/src/libcamera/geometry.cpp\n> +++ b/src/libcamera/geometry.cpp\n> @@ -105,4 +105,33 @@ const std::string Rectangle::toString() const\n> * \\brief The maximum image height\n> */\n> \n> +/**\n> + * \\struct Size\n> + * \\brief Describe a two-dimensional size\n> + *\n> + * The Size structure defines a two-dimensional size with integer precision.\n> + */\n> +\n> +/**\n> + * \\fn Size::Size()\n> + * \\brief Construct a Size with width and height set to 0\n> + */\n> +\n> +/**\n> + * \\fn Size::Size(unsigned int width, unsigned int height)\n> + * \\brief Construct a Size with given \\a width and \\a height\n> + * \\param width The Size width\n> + * \\param height The Size height\n> + */\n> +\n> +/**\n> + * \\var Size::width\n> + * \\brief The Size width\n> + */\n> +\n> +/**\n> + * \\var Size::height\n> + * \\brief The Size height\n> + */\n> +\n> } /* namespace libcamera */\n> diff --git a/src/libcamera/include/geometry.h b/src/libcamera/include/geometry.h\n> index 567a54299b24..315168a5fbbd 100644\n> --- a/src/libcamera/include/geometry.h\n> +++ b/src/libcamera/include/geometry.h\n> @@ -40,6 +40,21 @@ struct SizeRange {\n> \tunsigned int maxHeight;\n> };\n> \n> +struct Size {\n> +\tSize()\n> +\t\t: Size(0, 0)\n> +\t{\n> +\t}\n> +\n> +\tSize(unsigned int w, unsigned int h)\n> +\t\t: width(w), height(h)\n> +\t{\n> +\t}\n> +\n> +\tunsigned int width;\n> +\tunsigned int height;\n> +};\n> +\n> } /* namespace libcamera */\n> \n> #endif /* __LIBCAMERA_GEOMETRY_H__ */\n> -- \n> 2.21.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com\n\t[IPv6:2a00:1450:4864:20::12e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 39F84610B6\n\tfor ;\n\tTue, 2 Apr 2019 20:03:34 +0200 (CEST)","by mail-lf1-x12e.google.com with SMTP id g7so9681781lfh.10\n\tfor ;\n\tTue, 02 Apr 2019 11:03:34 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tm19sm2854763lji.70.2019.04.02.11.03.32\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 02 Apr 2019 11:03:32 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=cy6mJXfwWiBK/vZmXypqfNFfyW44A+oK7KimMNB21gg=;\n\tb=D7v0ELLx8QNW0h+mkLxbj5N8GvzqVQV+8EH7/CeIn1ZZ2SJg5xY7LupK2k1WgNd3Y+\n\tScH6+Z7k7C4cRxek3yz72BSWvYKLeW9OhSBjdvG6ncBL8zrK7vstOsVa7fr6z5eza+GU\n\tseJyGUcUPxCowVF+IEEcQBhnR96rrjJzNQ6lwwTvtZI8QZdN0OaVN8kzTWvhZHhzX0BK\n\tIIb6HM0IsOCpNZjolzuaqSsFZiNvtf3052VSJKWEgIZBc0cjaUnqO2LV5N7kesby3GZ4\n\tuo6mnyAmSCIGscArZL8yT0leq3AcMGwo9ornyV33xVSpyEsHWgYmj+Q+sT1I7iZ9YIxd\n\trM+w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=cy6mJXfwWiBK/vZmXypqfNFfyW44A+oK7KimMNB21gg=;\n\tb=Bpo/9oqxU7lnvUI/w/4aqkFRMPFXi6Mu3k0PaNDcHSjvgO98CTRTLnQbuNqaLi6ZfA\n\tion4SG3Creo+08GIxNhN2DJz2hfcTr+MoLwC4LCp4YUYoIuWnjCaEIceFwsMNbpkicoi\n\tsU6fQ/k8AUkDIv7n2zP3U1iZSdOg5HvuNmVfgW3L8E+66+u+ic4srxPDXNstv6KuN6Su\n\tZvgOJMGagrLHLjxotWPOjUaKdTfl1pjXnPwMpcD6t4VXbWJcUdu4k9aEpfHZDMHx61g4\n\tlnxBubwE3VeLPArU3xd//f1a/gvZs+XR0ZLQMkcL2zZWRMwADPX/oOysut/f/bmy+Cp4\n\tPQcA==","X-Gm-Message-State":"APjAAAUi+JYuKKJp+cCqdTT+0wzXIctee79fI3ItBSNlkMuv8xOqQwR/\n\tg9+duppQJdULkpbXWF1TejGpvaWwdnM=","X-Google-Smtp-Source":"APXvYqwb7ka2yb1htEj4XljcXvRw7olN+gN2I77aXgULJiky6+CeF90gebpliIAgvt6Bq23zYMO34A==","X-Received":"by 2002:ac2:4563:: with SMTP id\n\tk3mr35981738lfm.101.1554228213508; \n\tTue, 02 Apr 2019 11:03:33 -0700 (PDT)","Date":"Tue, 2 Apr 2019 20:03:32 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190402180332.GZ23466@bigcity.dyn.berto.se>","References":"<20190402171309.6447-1-jacopo@jmondi.org>\n\t<20190402171309.6447-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190402171309.6447-3-jacopo@jmondi.org>","User-Agent":"Mutt/1.11.3 (2019-02-01)","Subject":"Re: [libcamera-devel] [PATCH v7 02/13] libcamera: geometry: Add\n\tSize structure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 02 Apr 2019 18:03:34 -0000"}}]