[{"id":1223,"web_url":"https://patchwork.libcamera.org/comment/1223/","msgid":"<20190402174148.GS4805@pendragon.ideasonboard.com>","date":"2019-04-02T17:41:48","subject":"Re: [libcamera-devel] [PATCH v7 01/13] libcamera: geometry: Add\n\t0-initialized SizeRange constructor","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Apr 02, 2019 at 07:12:57PM +0200, Jacopo Mondi wrote:\n> Add constructor to SizeRange which initialize all the size range fields\n> to 0.\n> \n> While at there make the in-line constructor declarations respect the\n> coding style by moving braces to a new line.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/geometry.cpp | 11 ++++++++++-\n> src/libcamera/include/geometry.h | 9 ++++++++-\n> 2 files changed, 18 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\n> index 6dc8e74d2801..f76001d94562 100644\n> --- a/src/libcamera/geometry.cpp\n> +++ b/src/libcamera/geometry.cpp\n> @@ -73,7 +73,16 @@ const std::string Rectangle::toString() const\n> \n> /**\n> * \\fn SizeRange::SizeRange()\n> - * \\brief Construct a size range\n> + * \\brief Construct a size range initialized to 0\n> + */\n> +\n> +/**\n> + * \\fn SizeRange::SizeRange(unsigned int minW, unsigned int minH, unsigned int maxW, unsigned int maxH)\n> + * \\brief Construct an initialized size range\n> + * \\param minW The minimum width\n> + * \\param minH The minimum height\n> + * \\param maxW The maximum width\n> + * \\param maxH The maximum height\n> */\n> \n> /**\n> diff --git a/src/libcamera/include/geometry.h b/src/libcamera/include/geometry.h\n> index b14f9732f3db..567a54299b24 100644\n> --- a/src/libcamera/include/geometry.h\n> +++ b/src/libcamera/include/geometry.h\n> @@ -22,10 +22,17 @@ struct Rectangle {\n> };\n> \n> struct SizeRange {\n> +\tSizeRange(void)\n\ns/void//\n\nReviewed-by: Laurent Pinchart \n\n> +\t\t: SizeRange(0, 0, 0, 0)\n> +\t{\n> +\t}\n> +\n> \tSizeRange(unsigned int minW, unsigned int minH,\n> \t\t unsigned int maxW, unsigned int maxH)\n> \t\t: minWidth(minW), minHeight(minH), maxWidth(maxW),\n> -\t\t maxHeight(maxH) {}\n> +\t\t maxHeight(maxH)\n> +\t{\n> +\t}\n> \n> \tunsigned int minWidth;\n> \tunsigned int minHeight;","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC628610B6\n\tfor ;\n\tTue, 2 Apr 2019 19:41:59 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4EB752F9;\n\tTue, 2 Apr 2019 19:41:59 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1554226919;\n\tbh=M1h3wpTkwD/ZyOrm7DNBPhRU7/+X8TUxjdZcdzXHNvg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QNqun1ePpCha0T2tq0acUNqbxpUNH1V0vxLbaA5uSbV4uxU/4gFxByxUI4l4b3BUH\n\tvV5b5TUm09h7aOzWu8S9+udSnjVr1JtBapGFsYLES7yq5G+YQomKq3h8lzz4/Hkgc3\n\tCyGf4K/M2S7eM7evKgZnmAP55srk/Tnbvb7csbf4=","Date":"Tue, 2 Apr 2019 20:41:48 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190402174148.GS4805@pendragon.ideasonboard.com>","References":"<20190402171309.6447-1-jacopo@jmondi.org>\n\t<20190402171309.6447-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190402171309.6447-2-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v7 01/13] libcamera: geometry: Add\n\t0-initialized SizeRange constructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 02 Apr 2019 17:41:59 -0000"}},{"id":1224,"web_url":"https://patchwork.libcamera.org/comment/1224/","msgid":"<20190402180135.GY23466@bigcity.dyn.berto.se>","date":"2019-04-02T18:01:35","subject":"Re: [libcamera-devel] [PATCH v7 01/13] libcamera: geometry: Add\n\t0-initialized SizeRange constructor","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2019-04-02 19:12:57 +0200, Jacopo Mondi wrote:\n> Add constructor to SizeRange which initialize all the size range fields\n> to 0.\n> \n> While at there make the in-line constructor declarations respect the\n> coding style by moving braces to a new line.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/geometry.cpp | 11 ++++++++++-\n> src/libcamera/include/geometry.h | 9 ++++++++-\n> 2 files changed, 18 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\n> index 6dc8e74d2801..f76001d94562 100644\n> --- a/src/libcamera/geometry.cpp\n> +++ b/src/libcamera/geometry.cpp\n> @@ -73,7 +73,16 @@ const std::string Rectangle::toString() const\n> \n> /**\n> * \\fn SizeRange::SizeRange()\n> - * \\brief Construct a size range\n> + * \\brief Construct a size range initialized to 0\n> + */\n> +\n> +/**\n> + * \\fn SizeRange::SizeRange(unsigned int minW, unsigned int minH, unsigned int maxW, unsigned int maxH)\n> + * \\brief Construct an initialized size range\n> + * \\param minW The minimum width\n> + * \\param minH The minimum height\n> + * \\param maxW The maximum width\n> + * \\param maxH The maximum height\n> */\n> \n> /**\n> diff --git a/src/libcamera/include/geometry.h b/src/libcamera/include/geometry.h\n> index b14f9732f3db..567a54299b24 100644\n> --- a/src/libcamera/include/geometry.h\n> +++ b/src/libcamera/include/geometry.h\n> @@ -22,10 +22,17 @@ struct Rectangle {\n> };\n> \n> struct SizeRange {\n> +\tSizeRange(void)\n> +\t\t: SizeRange(0, 0, 0, 0)\n> +\t{\n> +\t}\n> +\n> \tSizeRange(unsigned int minW, unsigned int minH,\n> \t\t unsigned int maxW, unsigned int maxH)\n> \t\t: minWidth(minW), minHeight(minH), maxWidth(maxW),\n> -\t\t maxHeight(maxH) {}\n> +\t\t maxHeight(maxH)\n> +\t{\n> +\t}\n> \n> \tunsigned int minWidth;\n> \tunsigned int minHeight;\n> -- \n> 2.21.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com\n\t[IPv6:2a00:1450:4864:20::22c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E9485610B6\n\tfor ;\n\tTue, 2 Apr 2019 20:01:37 +0200 (CEST)","by mail-lj1-x22c.google.com with SMTP id v22so7758081lje.9\n\tfor ;\n\tTue, 02 Apr 2019 11:01:37 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tf25sm2054293lfk.69.2019.04.02.11.01.36\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 02 Apr 2019 11:01:36 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=cuWMP/gaT9O+hfdDDXWp0x4s2qBYnYy8Cs+ylVOVkWA=;\n\tb=TrNEHIqKdvUTSmsQaTx3yDkQvMfBPsHeM+Ep/p84kkkcFvJCWINFTfXZEaAWxxj3EH\n\tQ7JZbbQV6co4aNDUGhoJ/AF84JhZuf6VOZGH7+wZYswQuJS9cchLmqfPPVL9yzfZ1UMu\n\tUpDl0orPYkJ8wdYb++QfsWsldtiLC0gMHUOJ89/wPumrt4NvOtGDNdcuPFTv1q6PrUoq\n\t1s5MQutkBnf8KA8MjRgrOS7mpW80FvqoVTxQsgvm7wbRjjqFYqvyQihMFurMMrBELHIb\n\tkxx1sdyNn+vIlYeo2kjI1H/M3s5B3AOY1EZjiBIKtngkZoOZSUnfY7RjcCF7V0oy1K7R\n\tYiDw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=cuWMP/gaT9O+hfdDDXWp0x4s2qBYnYy8Cs+ylVOVkWA=;\n\tb=rLXwrt4izjhQhFPbKLsVkqMzkAtvEfsvBts+HSvf3rro4+KurnI+Tr+PTNpehWqaWf\n\t6aPJPi33yJMQF1CTMR4fjntn9f3bU45cbT/OR4iU+Q6Md5dZ9l57o+2jIqY24HRaGIMx\n\txf6SfXnkzs4UwBPL8A2JW8EFyJKqX1SIcdcFcJ+Z9Kgh6Q/uEOrfB/hZ/xxiIhByTp6O\n\tTT95H1KBDdDzlUP/f7c/u3RSKxu/cGMciMSFZYuAvU4sk9qVMGiCUo9Xhw7xy5X6zleE\n\tZc+0I9Nn+VOmF4hOUWvKa+nH7GUbmsTlP6Z/6EFQaCnY9nlUpQtm12G3FUaycanpuSB/\n\tgKVQ==","X-Gm-Message-State":"APjAAAV7Nc3zxCTQ+o/+V+ANgT34JdXQfwJs+y7H01iAOk0XAp8lwpad\n\tia9j3A84dPPZCIBu7wHM2T0zCw==","X-Google-Smtp-Source":"APXvYqwGMTFWl+lyDSHSWpird8XfkPJrkEpFMWW3G/OyPb7KhpDifUmtxuYw6BMcrTvegPDLusxOSw==","X-Received":"by 2002:a2e:99c5:: with SMTP id l5mr16444677ljj.55.1554228097207;\n\tTue, 02 Apr 2019 11:01:37 -0700 (PDT)","Date":"Tue, 2 Apr 2019 20:01:35 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190402180135.GY23466@bigcity.dyn.berto.se>","References":"<20190402171309.6447-1-jacopo@jmondi.org>\n\t<20190402171309.6447-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190402171309.6447-2-jacopo@jmondi.org>","User-Agent":"Mutt/1.11.3 (2019-02-01)","Subject":"Re: [libcamera-devel] [PATCH v7 01/13] libcamera: geometry: Add\n\t0-initialized SizeRange constructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 02 Apr 2019 18:01:38 -0000"}}]