[{"id":11098,"web_url":"https://patchwork.libcamera.org/comment/11098/","msgid":"<20200702233353.GK3158543@oden.dyn.berto.se>","date":"2020-07-02T23:33:53","subject":"Re: [libcamera-devel] [PATCH v2 8/9] android: camera_device: Remove\n\tsingle buffer restriction.","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nThanks for your work.\n\nOn 2020-07-02 22:36:53 +0100, Kieran Bingham wrote:\n> A capture request is no longer limited to a single output buffer.\n> Remove the limitation, but (for now) keep the check to ensure that\n> at least one buffer is always provided.\n> \n> This 'should never happen' so could be a LOG(Fatal) or removed.\n\nI would remove this last line from the commit message, with that fixed\n\nReviewed-by: Niklas Söderlund \n\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/android/camera_device.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index eea8c8c50352..4681fd8af90b 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1046,7 +1046,7 @@ static FrameBuffer *newFrameBuffer(const buffer_handle_t camera3buffer)\n> \n> int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Request)\n> {\n> -\tif (camera3Request->num_output_buffers != 1) {\n> +\tif (camera3Request->num_output_buffers < 1) {\n> \t\tLOG(HAL, Error) << \"Invalid number of output buffers: \"\n> \t\t\t\t<< camera3Request->num_output_buffers;\n> \t\treturn -EINVAL;\n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C3A8BFFE2\n\tfor ;\n\tThu, 2 Jul 2020 23:33:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3C63760C57;\n\tFri, 3 Jul 2020 01:33:56 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E5DAA609C7\n\tfor ;\n\tFri, 3 Jul 2020 01:33:54 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id e4so34462364ljn.4\n\tfor ;\n\tThu, 02 Jul 2020 16:33:54 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tk6sm3960425lfm.89.2020.07.02.16.33.53\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 02 Jul 2020 16:33:53 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"MNuV36Pk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=DNSArIIasX0zmTlWa1oTc1Ju9pwaIUwHX03X6ty3mjM=;\n\tb=MNuV36PkPVbKjbAYpTCMwGZNuXY7+oVLoktSkW3Qhr4X5NsSaNSthmPTlonkq9oUwh\n\tSB1yIDRLPcnjTdvBkQ2lf7hvW20c//G16glvycmLWuL57mPmI4NrZIwp5pxY3bjr9rti\n\tl6JVsnWk5Ww3JB+bhMyFF8dl3SMlttknxCwoiX6AaE3QMJrE3Wu3pd7Zk141lHX9YSr9\n\thj81jPYikXKoW4cHTJUS2nTRNM0S6Xtm0M0uBpWhphcNFEv/lZbJNpnx6IxpE6+A4d8s\n\tcUo3pk5qq9aWKZeg9l4gxzK4QuFQC/Qh6KauvxiayXF+CPdTwIoTCphar6s88Q71mtIU\n\t/Mgg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=DNSArIIasX0zmTlWa1oTc1Ju9pwaIUwHX03X6ty3mjM=;\n\tb=oebSkIijdRqN/Hv5Jl+wXNshI12hylqcEciRv3XxpM9MVMgFzavo1EMqoNuekItGF2\n\tdVQviJ6md0zb7+Jw3qZts0Dc5C/QY7IglGUOGMIuAQj0nQjPCNdAt5sSRgG2tuMocfwW\n\tXDB2ShD3Esz8YV6/XXkjfxTi9DR+P/bh1ZcRVGE+QZcNSDy3HJrQforYnkV6Ayx/qJdx\n\tOLEafY5uTYBQ7TzUtO5I1SzZWhcsliWRyJ2T7xE4n+rQUKsLP3rJzDCknqc1oZlLpxgh\n\t2LEOd/h7XVzMYhs7/zNAg53CGv49Uhi3BRMucTPjKjaTlNM1A1ucvKq68HYwMFhM6Yru\n\tc0cg==","X-Gm-Message-State":"AOAM530dmNB7ELKhXupky+ffLGxjNQDLyZ4aPGQyaxIMsGIZQTIDsYFH\n\tCqkRCX1mN1o5esUz82+qdETlZAYj30zNfg==","X-Google-Smtp-Source":"ABdhPJz6GseaxiQvBYPvPriLfiYuBoge6BB5IGqcvdmi+50rLTjj0O7S7se0CMhT7CqsnMao/6AKfg==","X-Received":"by 2002:a05:651c:305:: with SMTP id\n\ta5mr17070686ljp.387.1593732834406; \n\tThu, 02 Jul 2020 16:33:54 -0700 (PDT)","Date":"Fri, 3 Jul 2020 01:33:53 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Message-ID":"<20200702233353.GK3158543@oden.dyn.berto.se>","References":"<20200702213654.2129054-1-kieran.bingham@ideasonboard.com>\n\t<20200702213654.2129054-9-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200702213654.2129054-9-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 8/9] android: camera_device: Remove\n\tsingle buffer restriction.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11105,"web_url":"https://patchwork.libcamera.org/comment/11105/","msgid":"<20200703004112.GF12562@pendragon.ideasonboard.com>","date":"2020-07-03T00:41:12","subject":"Re: [libcamera-devel] [PATCH v2 8/9] android: camera_device: Remove\n\tsingle buffer restriction.","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Jul 02, 2020 at 10:36:53PM +0100, Kieran Bingham wrote:\n> A capture request is no longer limited to a single output buffer.\n> Remove the limitation, but (for now) keep the check to ensure that\n> at least one buffer is always provided.\n> \n> This 'should never happen' so could be a LOG(Fatal) or removed.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/android/camera_device.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index eea8c8c50352..4681fd8af90b 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1046,7 +1046,7 @@ static FrameBuffer *newFrameBuffer(const buffer_handle_t camera3buffer)\n> \n> int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Request)\n> {\n> -\tif (camera3Request->num_output_buffers != 1) {\n> +\tif (camera3Request->num_output_buffers < 1) {\n> \t\tLOG(HAL, Error) << \"Invalid number of output buffers: \"\n> \t\t\t\t<< camera3Request->num_output_buffers;\n\nAs num_output_buffers is unsigned, it can only be 0 here. I'd write\n\n \t\tLOG(HAL, Error) << \"No output buffers provided\";\n\nReviewed-by: Laurent Pinchart \n\n> \t\treturn -EINVAL;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4226CBE905\n\tfor ;\n\tFri, 3 Jul 2020 00:41:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B4E3460C59;\n\tFri, 3 Jul 2020 02:41:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F326A609C7\n\tfor ;\n\tFri, 3 Jul 2020 02:41:16 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 44CD99CB;\n\tFri, 3 Jul 2020 02:41:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"osNgC/Tb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593736876;\n\tbh=lJfB2yFACWVRP+qwPPIDCDu2eytAcRglhdc91Q3R1Ic=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=osNgC/TbZ6MTrsftf4aBqQocMyH0r+UBjVA0tR4mgjA3W55OSgXo/YFu3cfPHdbu3\n\tVuKZKcw1Mwtak+aotBQGqcJkMp6P44if3HUJIzhtWrnF0nqoN5T6xpZEC3Qs3gVkJ8\n\tGfgoCdXnvbr7WIcL3fmnlh3DqSRZhMa04i+SU0iM=","Date":"Fri, 3 Jul 2020 03:41:12 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200703004112.GF12562@pendragon.ideasonboard.com>","References":"<20200702213654.2129054-1-kieran.bingham@ideasonboard.com>\n\t<20200702213654.2129054-9-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200702213654.2129054-9-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 8/9] android: camera_device: Remove\n\tsingle buffer restriction.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11150,"web_url":"https://patchwork.libcamera.org/comment/11150/","msgid":"","date":"2020-07-03T11:07:57","subject":"Re: [libcamera-devel] [PATCH v2 8/9] android: camera_device: Remove\n\tsingle buffer restriction.","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 03/07/2020 01:41, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Thu, Jul 02, 2020 at 10:36:53PM +0100, Kieran Bingham wrote:\n>> A capture request is no longer limited to a single output buffer.\n>> Remove the limitation, but (for now) keep the check to ensure that\n>> at least one buffer is always provided.\n>>\n>> This 'should never happen' so could be a LOG(Fatal) or removed.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> src/android/camera_device.cpp | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n>> index eea8c8c50352..4681fd8af90b 100644\n>> --- a/src/android/camera_device.cpp\n>> +++ b/src/android/camera_device.cpp\n>> @@ -1046,7 +1046,7 @@ static FrameBuffer *newFrameBuffer(const buffer_handle_t camera3buffer)\n>> \n>> int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Request)\n>> {\n>> -\tif (camera3Request->num_output_buffers != 1) {\n>> +\tif (camera3Request->num_output_buffers < 1) {\n>> \t\tLOG(HAL, Error) << \"Invalid number of output buffers: \"\n>> \t\t\t\t<< camera3Request->num_output_buffers;\n> \n> As num_output_buffers is unsigned, it can only be 0 here. I'd write\n> \n> \t\tLOG(HAL, Error) << \"No output buffers provided\";\n\n\nGood point, would you also change the conditional to:\n\n if (!camera3Request->num_output_buffers) {\n\nor\n if (camera3Request->num_output_buffers == 0) {\n\nin that case?\n\n\n\n> \n> Reviewed-by: Laurent Pinchart \n> \n>> \t\treturn -EINVAL;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 24BDCBE905\n\tfor ;\n\tFri, 3 Jul 2020 11:08:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A7D1260C53;\n\tFri, 3 Jul 2020 13:08:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 636F7603AE\n\tfor ;\n\tFri, 3 Jul 2020 13:08:00 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CDCC051B;\n\tFri, 3 Jul 2020 13:07:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"T921M5Iq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593774480;\n\tbh=bw9drM2s7OINntYh5YoWCZV1vqk1a209lj1JzGWNMjQ=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=T921M5Iqqlp8seuTkDSi/kd8O6TBJQr/U2vvuNsimK9un4HEZJmAcZNlEwbTdpznO\n\ttdwxU60zdDurvNXl8tsBP0MhtzTYj5lJlK05jqn4kc3JjDOXp+YdU1aDqelCT9Vyez\n\tcreRG3rEH3Cumce8mjmoBiZfn5HEVSeCN2MaXBjo=","To":"Laurent Pinchart ","References":"<20200702213654.2129054-1-kieran.bingham@ideasonboard.com>\n\t<20200702213654.2129054-9-kieran.bingham@ideasonboard.com>\n\t<20200703004112.GF12562@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Fri, 3 Jul 2020 12:07:57 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.8.0","MIME-Version":"1.0","In-Reply-To":"<20200703004112.GF12562@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 8/9] android: camera_device: Remove\n\tsingle buffer restriction.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11151,"web_url":"https://patchwork.libcamera.org/comment/11151/","msgid":"<20200703110831.GI5963@pendragon.ideasonboard.com>","date":"2020-07-03T11:08:31","subject":"Re: [libcamera-devel] [PATCH v2 8/9] android: camera_device: Remove\n\tsingle buffer restriction.","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Fri, Jul 03, 2020 at 12:07:57PM +0100, Kieran Bingham wrote:\n> On 03/07/2020 01:41, Laurent Pinchart wrote:\n> > On Thu, Jul 02, 2020 at 10:36:53PM +0100, Kieran Bingham wrote:\n> >> A capture request is no longer limited to a single output buffer.\n> >> Remove the limitation, but (for now) keep the check to ensure that\n> >> at least one buffer is always provided.\n> >>\n> >> This 'should never happen' so could be a LOG(Fatal) or removed.\n> >>\n> >> Signed-off-by: Kieran Bingham \n> >> ---\n> >> src/android/camera_device.cpp | 2 +-\n> >> 1 file changed, 1 insertion(+), 1 deletion(-)\n> >>\n> >> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> >> index eea8c8c50352..4681fd8af90b 100644\n> >> --- a/src/android/camera_device.cpp\n> >> +++ b/src/android/camera_device.cpp\n> >> @@ -1046,7 +1046,7 @@ static FrameBuffer *newFrameBuffer(const buffer_handle_t camera3buffer)\n> >> \n> >> int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Request)\n> >> {\n> >> -\tif (camera3Request->num_output_buffers != 1) {\n> >> +\tif (camera3Request->num_output_buffers < 1) {\n> >> \t\tLOG(HAL, Error) << \"Invalid number of output buffers: \"\n> >> \t\t\t\t<< camera3Request->num_output_buffers;\n> > \n> > As num_output_buffers is unsigned, it can only be 0 here. I'd write\n> > \n> > \t\tLOG(HAL, Error) << \"No output buffers provided\";\n> \n> \n> Good point, would you also change the conditional to:\n> \n> if (!camera3Request->num_output_buffers) {\n\nYes, I think this is best.\n\n> \n> or\n> if (camera3Request->num_output_buffers == 0) {\n> \n> in that case?\n> \n> > Reviewed-by: Laurent Pinchart \n> > \n> >> \t\treturn -EINVAL;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 46E7BBE905\n\tfor ;\n\tFri, 3 Jul 2020 11:08:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 146A560C57;\n\tFri, 3 Jul 2020 13:08:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 978C6603AE\n\tfor ;\n\tFri, 3 Jul 2020 13:08:35 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 37B6751B;\n\tFri, 3 Jul 2020 13:08:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fFZps+Bc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593774515;\n\tbh=xqKP1iUqAJsn+o8LpqRSFj9ZRGgSeuXI4g1vlh5vEtk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fFZps+Bc+LgWRKMtevwYzaNM2jlopipjQNFucBP9B5ruUNHesDFJxE7kJqriAa3OZ\n\tST5lOjhyopWMAGJkzeYZtemEL0MeSERFXYyKtyTnoYSclj+Mti1XPzk9xHZIjptcqk\n\tYIli+kThBG9nc6qWSLgYgM8S33gIPWK6fzRvM+b4=","Date":"Fri, 3 Jul 2020 14:08:31 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200703110831.GI5963@pendragon.ideasonboard.com>","References":"<20200702213654.2129054-1-kieran.bingham@ideasonboard.com>\n\t<20200702213654.2129054-9-kieran.bingham@ideasonboard.com>\n\t<20200703004112.GF12562@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v2 8/9] android: camera_device: Remove\n\tsingle buffer restriction.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]