{"id":8563,"url":"https://patchwork.libcamera.org/api/patches/8563/?format=json","web_url":"https://patchwork.libcamera.org/patch/8563/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200702213654.2129054-9-kieran.bingham@ideasonboard.com>","date":"2020-07-02T21:36:53","name":"[libcamera-devel,v2,8/9] android: camera_device: Remove single buffer restriction.","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b58689786e04242cecbad4453d16ea691cd97f28","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8563/mbox/","series":[{"id":1073,"url":"https://patchwork.libcamera.org/api/series/1073/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1073","date":"2020-07-02T21:36:45","name":"android: Multi-stream support","version":2,"mbox":"https://patchwork.libcamera.org/series/1073/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8563/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8563/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 77121BE905\n\tfor ;\n\tThu, 2 Jul 2020 21:37:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 454F860CBC;\n\tThu, 2 Jul 2020 23:37:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 930B060C59\n\tfor ;\n\tThu, 2 Jul 2020 23:37:05 +0200 (CEST)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3321FA2D;\n\tThu, 2 Jul 2020 23:37:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qpjMbeT7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593725825;\n\tbh=I1wp9s75ueoou49UbaFzesjuDck3Y2J7kqNLX/OAk2s=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=qpjMbeT7xn/zLzPJ4doX95htUIwMBc3vQLk7VadDLk4B8VjOxnb6WradC29MUMgm2\n\tJZo00WwordyGxXsdaGGP1CdDnu+rdSqyFARFF4RWdQVTR10ng8hRtBktamsux3gkp+\n\tERQy8N11c5TfTZ9ADl4++YEKESvRnZEqfGrf2QBE=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Thu, 2 Jul 2020 22:36:53 +0100","Message-Id":"<20200702213654.2129054-9-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200702213654.2129054-1-kieran.bingham@ideasonboard.com>","References":"<20200702213654.2129054-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 8/9] android: camera_device: Remove\n\tsingle buffer restriction.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"A capture request is no longer limited to a single output buffer.\nRemove the limitation, but (for now) keep the check to ensure that\nat least one buffer is always provided.\n\nThis 'should never happen' so could be a LOG(Fatal) or removed.\n\nSigned-off-by: Kieran Bingham \n---\n src/android/camera_device.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex eea8c8c50352..4681fd8af90b 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1046,7 +1046,7 @@ static FrameBuffer *newFrameBuffer(const buffer_handle_t camera3buffer)\n \n int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Request)\n {\n-\tif (camera3Request->num_output_buffers != 1) {\n+\tif (camera3Request->num_output_buffers < 1) {\n \t\tLOG(HAL, Error) << \"Invalid number of output buffers: \"\n \t\t\t\t<< camera3Request->num_output_buffers;\n \t\treturn -EINVAL;\n","prefixes":["libcamera-devel","v2","8/9"]}