[{"id":11094,"web_url":"https://patchwork.libcamera.org/comment/11094/","msgid":"<20200702232559.GG3158543@oden.dyn.berto.se>","date":"2020-07-02T23:25:59","subject":"Re: [libcamera-devel] [PATCH v2 4/9] android: camera_device:\n\tSimplify FrameBuffer construction from a buffer_handle_t","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nThanks for your work.\n\nOn 2020-07-02 22:36:49 +0100, Kieran Bingham wrote:\n> Move the code which constructs a FrameBuffer from the Android buffer handle\n> to it's own function to simplify the code flow and readability.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/android/camera_device.cpp | 35 +++++++++++++++++++----------------\n> 1 file changed, 19 insertions(+), 16 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 03dcdd520794..78ecfd7c2ee2 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1011,6 +1011,24 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> \treturn 0;\n> }\n> \n> +static FrameBuffer *newFrameBuffer(const buffer_handle_t camera3buffer)\n> +{\n> +\tstd::vector planes;\n> +\tfor (unsigned int i = 0; i < 3; i++) {\n> +\t\tFrameBuffer::Plane plane;\n> +\t\tplane.fd = FileDescriptor(camera3buffer->data[i]);\n> +\t\t/*\n> +\t\t * Setting length to zero here is OK as the length is only used\n> +\t\t * to map the memory of the plane. Libcamera do not need to poke\n> +\t\t * at the memory content queued by the HAL.\n> +\t\t */\n> +\t\tplane.length = 0;\n> +\t\tplanes.push_back(std::move(plane));\n> +\t}\n> +\n> +\treturn new FrameBuffer(std::move(planes));\n> +}\n> +\n> int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Request)\n> {\n> \tStreamConfiguration *streamConfiguration = &config_->at(0);\n> @@ -1064,22 +1082,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> \t * Create a libcamera buffer using the dmabuf descriptors of the first\n> \t * and (currently) only supported request buffer.\n> \t */\n> -\tconst buffer_handle_t camera3Handle = *camera3Buffers[0].buffer;\n> -\n> -\tstd::vector planes;\n> -\tfor (int i = 0; i < 3; i++) {\n> -\t\tFrameBuffer::Plane plane;\n> -\t\tplane.fd = FileDescriptor(camera3Handle->data[i]);\n> -\t\t/*\n> -\t\t * Setting length to zero here is OK as the length is only used\n> -\t\t * to map the memory of the plane. Libcamera do not need to poke\n> -\t\t * at the memory content queued by the HAL.\n> -\t\t */\n> -\t\tplane.length = 0;\n> -\t\tplanes.push_back(std::move(plane));\n> -\t}\n> -\n> -\tFrameBuffer *buffer = new FrameBuffer(std::move(planes));\n> +\tFrameBuffer *buffer = newFrameBuffer(*camera3Buffers[0].buffer);\n\nWould it make sens to change the argument to a pointer instead of \ndereferencing it here? Also I think I would callt the function \nconstructFrameBuffer() or createFrameBuffer().\n\n> \tif (!buffer) {\n> \t\tLOG(HAL, Error) << \"Failed to create buffer\";\n> \t\tdelete descriptor;\n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A2D6CBFFE2\n\tfor ;\n\tThu, 2 Jul 2020 23:26:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2D2A160C57;\n\tFri, 3 Jul 2020 01:26:03 +0200 (CEST)","from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 635BC609C7\n\tfor ;\n\tFri, 3 Jul 2020 01:26:01 +0200 (CEST)","by mail-lj1-x243.google.com with SMTP id z24so9513862ljn.8\n\tfor ;\n\tThu, 02 Jul 2020 16:26:01 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ta16sm3577490ljj.108.2020.07.02.16.26.00\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 02 Jul 2020 16:26:00 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"Xh8ayjFZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=YdEuKBcIWrFpMmmkunCOSX6IkORKzEHR7foZCLQyHa4=;\n\tb=Xh8ayjFZtq4XAS3JJA/kTuOXPw5rxO6DLRDcKNiv1d7X2JLioQr8QBfnvz/aGgSPo7\n\tCnnMdZCWMtihIHAj71JFCCd0xryvLnqW/XKYKWj//QJH96eix5Ey05Tq9VIVyd4HY8eA\n\t3+6TyYg5HDCIZ/CNYFTdxnyn4xXfFJVXXIPMlB2JH20+6qWZaKiUc+z4BkgbUeIob+/G\n\tXsEVrEJvlBChP2CLQ2gJ2XYlJgzDyxvdGtFmvMcs/fTqPzoTW3wllqb0Z68+F3sJABtE\n\t5d0K8mx+cDQe6UwJ2asNtqEayJFC/e9QtSZ/xE1u4Ug7cJg0vgPedTgHxcZoirOgtgfC\n\tE7Pg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=YdEuKBcIWrFpMmmkunCOSX6IkORKzEHR7foZCLQyHa4=;\n\tb=DyBQJesvKlpQQrr1SxxN+6MU37CUbZnwfI6jyC7LQ2WQOgnHcMWJtm/DV/zLM9pZCB\n\tNrwsQleXd9ZF+akjM++mAxsL+lwliL0nqU9tOxBUAadQPMYdDI0/uqwpS45jGY8Kq5ss\n\taWY2p1qk4GqK7EDr1TpzrcS7ZcPDLBMuPlZrhYTGWZ2d68ocuVqMe38UIYgPFys0hhsM\n\ta5NinOIgCZk0eGkdABcH9LoU92M3WayB811EkSFSd7twD0qWLSFDOZ9Y0fpEUd3ycUnK\n\tR+8bIOGSKqDcZxf8T7+WCroC4xgLEg6riTSAjGJHmsHqPX/ZtQyDcOI6WuZbSYuEzCuc\n\t3V2w==","X-Gm-Message-State":"AOAM5339PtHYfOxb5tCmqu2RIIpW4+DfGGlSEsnt8fslwczQJfjJwKdi\n\tP9sbTWUdh0qEyMsaqaaf/m3FzA==","X-Google-Smtp-Source":"ABdhPJwgh7fBU3z4oouMjFHwUDJOCopFBFmgqHmnnjlPzpvAjCy0Ppo4GxxuL8y7b+iWT/ntoG7Gtg==","X-Received":"by 2002:a2e:b88e:: with SMTP id\n\tr14mr16611336ljp.197.1593732360764; \n\tThu, 02 Jul 2020 16:26:00 -0700 (PDT)","Date":"Fri, 3 Jul 2020 01:25:59 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Message-ID":"<20200702232559.GG3158543@oden.dyn.berto.se>","References":"<20200702213654.2129054-1-kieran.bingham@ideasonboard.com>\n\t<20200702213654.2129054-5-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200702213654.2129054-5-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 4/9] android: camera_device:\n\tSimplify FrameBuffer construction from a buffer_handle_t","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11102,"web_url":"https://patchwork.libcamera.org/comment/11102/","msgid":"<20200703002903.GC12562@pendragon.ideasonboard.com>","date":"2020-07-03T00:29:03","subject":"Re: [libcamera-devel] [PATCH v2 4/9] android: camera_device:\n\tSimplify FrameBuffer construction from a buffer_handle_t","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Jul 03, 2020 at 01:25:59AM +0200, Niklas Söderlund wrote:\n> On 2020-07-02 22:36:49 +0100, Kieran Bingham wrote:\n> > Move the code which constructs a FrameBuffer from the Android buffer handle\n> > to it's own function to simplify the code flow and readability.\n\ns/it's/its/\n\n> > \n> > Signed-off-by: Kieran Bingham \n> > ---\n> > src/android/camera_device.cpp | 35 +++++++++++++++++++----------------\n> > 1 file changed, 19 insertions(+), 16 deletions(-)\n> > \n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index 03dcdd520794..78ecfd7c2ee2 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -1011,6 +1011,24 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> > \treturn 0;\n> > }\n> > \n> > +static FrameBuffer *newFrameBuffer(const buffer_handle_t camera3buffer)\n> > +{\n> > +\tstd::vector planes;\n> > +\tfor (unsigned int i = 0; i < 3; i++) {\n> > +\t\tFrameBuffer::Plane plane;\n> > +\t\tplane.fd = FileDescriptor(camera3buffer->data[i]);\n> > +\t\t/*\n> > +\t\t * Setting length to zero here is OK as the length is only used\n> > +\t\t * to map the memory of the plane. Libcamera do not need to poke\n> > +\t\t * at the memory content queued by the HAL.\n> > +\t\t */\n> > +\t\tplane.length = 0;\n> > +\t\tplanes.push_back(std::move(plane));\n> > +\t}\n> > +\n> > +\treturn new FrameBuffer(std::move(planes));\n> > +}\n> > +\n> > int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Request)\n> > {\n> > \tStreamConfiguration *streamConfiguration = &config_->at(0);\n> > @@ -1064,22 +1082,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> > \t * Create a libcamera buffer using the dmabuf descriptors of the first\n> > \t * and (currently) only supported request buffer.\n> > \t */\n> > -\tconst buffer_handle_t camera3Handle = *camera3Buffers[0].buffer;\n> > -\n> > -\tstd::vector planes;\n> > -\tfor (int i = 0; i < 3; i++) {\n> > -\t\tFrameBuffer::Plane plane;\n> > -\t\tplane.fd = FileDescriptor(camera3Handle->data[i]);\n> > -\t\t/*\n> > -\t\t * Setting length to zero here is OK as the length is only used\n> > -\t\t * to map the memory of the plane. Libcamera do not need to poke\n> > -\t\t * at the memory content queued by the HAL.\n> > -\t\t */\n> > -\t\tplane.length = 0;\n> > -\t\tplanes.push_back(std::move(plane));\n> > -\t}\n> > -\n> > -\tFrameBuffer *buffer = new FrameBuffer(std::move(planes));\n> > +\tFrameBuffer *buffer = newFrameBuffer(*camera3Buffers[0].buffer);\n> \n> Would it make sens to change the argument to a pointer instead of \n> dereferencing it here?\n\nbuffer_handle_t is already a pointer, the function would then need to do\n\n\tplane.fd = FileDescriptor((*camera3buffer)->data[i]);\n\nwhich isn't nice. I think it's best to dereference it once only here, in\nthe case function needs to access more than one field.\n\n> Also I think I would callt the function \n> constructFrameBuffer() or createFrameBuffer().\n\nI like createFrameBuffer() better, and I would make it a private member\nof CameraDevice. With these changes,\n\nReviewed-by: Laurent Pinchart \n\n> > \tif (!buffer) {\n> > \t\tLOG(HAL, Error) << \"Failed to create buffer\";\n> > \t\tdelete descriptor;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4AD73BE905\n\tfor ;\n\tFri, 3 Jul 2020 00:29:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C962960C57;\n\tFri, 3 Jul 2020 02:29:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 95A41609C7\n\tfor ;\n\tFri, 3 Jul 2020 02:29:09 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A31309CB;\n\tFri, 3 Jul 2020 02:29:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uNztl7sm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593736149;\n\tbh=fUD+l7ukdK3gqJ9aoSocrZ9Hf5usggMS8gsJfgrrBKE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=uNztl7smMGuFjwvbDC7mu5nbFGDnCkuC9DxS7+qXYW/cAoOEfdFff6JeYi5aNP3C5\n\thoIm20CMPmjrJ8WGjNRFJqapXrvh51Wo3AE5gi0PVrIgVxgl3cB1p8HT795n6LvndF\n\tbSzgFBE9AdC9QmjQUzfgcXiFarEHbewBu2Lgu/bc=","Date":"Fri, 3 Jul 2020 03:29:03 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200703002903.GC12562@pendragon.ideasonboard.com>","References":"<20200702213654.2129054-1-kieran.bingham@ideasonboard.com>\n\t<20200702213654.2129054-5-kieran.bingham@ideasonboard.com>\n\t<20200702232559.GG3158543@oden.dyn.berto.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200702232559.GG3158543@oden.dyn.berto.se>","Subject":"Re: [libcamera-devel] [PATCH v2 4/9] android: camera_device:\n\tSimplify FrameBuffer construction from a buffer_handle_t","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11124,"web_url":"https://patchwork.libcamera.org/comment/11124/","msgid":"<20200703091318.redpst35ko664b2f@uno.localdomain>","date":"2020-07-03T09:13:18","subject":"Re: [libcamera-devel] [PATCH v2 4/9] android: camera_device:\n\tSimplify FrameBuffer construction from a buffer_handle_t","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Fri, Jul 03, 2020 at 03:29:03AM +0300, Laurent Pinchart wrote:\n> Hi Kieran,\n>\n> Thank you for the patch.\n>\n> On Fri, Jul 03, 2020 at 01:25:59AM +0200, Niklas Söderlund wrote:\n> > On 2020-07-02 22:36:49 +0100, Kieran Bingham wrote:\n> > > Move the code which constructs a FrameBuffer from the Android buffer handle\n> > > to it's own function to simplify the code flow and readability.\n>\n> s/it's/its/\n>\n> > >\n> > > Signed-off-by: Kieran Bingham \n> > > ---\n> > > src/android/camera_device.cpp | 35 +++++++++++++++++++----------------\n> > > 1 file changed, 19 insertions(+), 16 deletions(-)\n> > >\n> > > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > > index 03dcdd520794..78ecfd7c2ee2 100644\n> > > --- a/src/android/camera_device.cpp\n> > > +++ b/src/android/camera_device.cpp\n> > > @@ -1011,6 +1011,24 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> > > \treturn 0;\n> > > }\n> > >\n> > > +static FrameBuffer *newFrameBuffer(const buffer_handle_t camera3buffer)\n> > > +{\n> > > +\tstd::vector planes;\n> > > +\tfor (unsigned int i = 0; i < 3; i++) {\n> > > +\t\tFrameBuffer::Plane plane;\n> > > +\t\tplane.fd = FileDescriptor(camera3buffer->data[i]);\n> > > +\t\t/*\n> > > +\t\t * Setting length to zero here is OK as the length is only used\n> > > +\t\t * to map the memory of the plane. Libcamera do not need to poke\n> > > +\t\t * at the memory content queued by the HAL.\n> > > +\t\t */\n> > > +\t\tplane.length = 0;\n> > > +\t\tplanes.push_back(std::move(plane));\n> > > +\t}\n> > > +\n> > > +\treturn new FrameBuffer(std::move(planes));\n> > > +}\n> > > +\n> > > int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Request)\n> > > {\n> > > \tStreamConfiguration *streamConfiguration = &config_->at(0);\n> > > @@ -1064,22 +1082,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> > > \t * Create a libcamera buffer using the dmabuf descriptors of the first\n> > > \t * and (currently) only supported request buffer.\n> > > \t */\n> > > -\tconst buffer_handle_t camera3Handle = *camera3Buffers[0].buffer;\n> > > -\n> > > -\tstd::vector planes;\n> > > -\tfor (int i = 0; i < 3; i++) {\n> > > -\t\tFrameBuffer::Plane plane;\n> > > -\t\tplane.fd = FileDescriptor(camera3Handle->data[i]);\n> > > -\t\t/*\n> > > -\t\t * Setting length to zero here is OK as the length is only used\n> > > -\t\t * to map the memory of the plane. Libcamera do not need to poke\n> > > -\t\t * at the memory content queued by the HAL.\n> > > -\t\t */\n> > > -\t\tplane.length = 0;\n> > > -\t\tplanes.push_back(std::move(plane));\n> > > -\t}\n> > > -\n> > > -\tFrameBuffer *buffer = new FrameBuffer(std::move(planes));\n> > > +\tFrameBuffer *buffer = newFrameBuffer(*camera3Buffers[0].buffer);\n> >\n> > Would it make sens to change the argument to a pointer instead of\n> > dereferencing it here?\n>\n> buffer_handle_t is already a pointer, the function would then need to do\n>\n> \tplane.fd = FileDescriptor((*camera3buffer)->data[i]);\n>\n> which isn't nice. I think it's best to dereference it once only here, in\n> the case function needs to access more than one field.\n>\n> > Also I think I would callt the function\n> > constructFrameBuffer() or createFrameBuffer().\n>\n> I like createFrameBuffer() better, and I would make it a private member\n> of CameraDevice. With these changes,\n\nMe too, and I like this better as a private helper function\n\n>\n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n>\n> > > \tif (!buffer) {\n> > > \t\tLOG(HAL, Error) << \"Failed to create buffer\";\n> > > \t\tdelete descriptor;\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 47C8ABE905\n\tfor ;\n\tFri, 3 Jul 2020 09:09:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C7A4560C5B;\n\tFri, 3 Jul 2020 11:09:48 +0200 (CEST)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D2D1E60C55\n\tfor ;\n\tFri, 3 Jul 2020 11:09:47 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 5F423200008;\n\tFri, 3 Jul 2020 09:09:46 +0000 (UTC)"],"Date":"Fri, 3 Jul 2020 11:13:18 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20200703091318.redpst35ko664b2f@uno.localdomain>","References":"<20200702213654.2129054-1-kieran.bingham@ideasonboard.com>\n\t<20200702213654.2129054-5-kieran.bingham@ideasonboard.com>\n\t<20200702232559.GG3158543@oden.dyn.berto.se>\n\t<20200703002903.GC12562@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200703002903.GC12562@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 4/9] android: camera_device:\n\tSimplify FrameBuffer construction from a buffer_handle_t","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11130,"web_url":"https://patchwork.libcamera.org/comment/11130/","msgid":"<53c5b4b6-5d1f-45bc-1b2a-397410742c26@ideasonboard.com>","date":"2020-07-03T09:38:09","subject":"Re: [libcamera-devel] [PATCH v2 4/9] android: camera_device:\n\tSimplify FrameBuffer construction from a buffer_handle_t","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi All,\n\nOn 03/07/2020 10:13, Jacopo Mondi wrote:\n> Hi Kieran,\n> \n> On Fri, Jul 03, 2020 at 03:29:03AM +0300, Laurent Pinchart wrote:\n>> Hi Kieran,\n>>\n>> Thank you for the patch.\n>>\n>> On Fri, Jul 03, 2020 at 01:25:59AM +0200, Niklas Söderlund wrote:\n>>> On 2020-07-02 22:36:49 +0100, Kieran Bingham wrote:\n>>>> Move the code which constructs a FrameBuffer from the Android buffer handle\n>>>> to it's own function to simplify the code flow and readability.\n>>\n>> s/it's/its/\n>>\n>>>>\n>>>> Signed-off-by: Kieran Bingham \n>>>> ---\n>>>> src/android/camera_device.cpp | 35 +++++++++++++++++++----------------\n>>>> 1 file changed, 19 insertions(+), 16 deletions(-)\n>>>>\n>>>> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n>>>> index 03dcdd520794..78ecfd7c2ee2 100644\n>>>> --- a/src/android/camera_device.cpp\n>>>> +++ b/src/android/camera_device.cpp\n>>>> @@ -1011,6 +1011,24 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n>>>> \treturn 0;\n>>>> }\n>>>>\n>>>> +static FrameBuffer *newFrameBuffer(const buffer_handle_t camera3buffer)\n>>>> +{\n>>>> +\tstd::vector planes;\n>>>> +\tfor (unsigned int i = 0; i < 3; i++) {\n>>>> +\t\tFrameBuffer::Plane plane;\n>>>> +\t\tplane.fd = FileDescriptor(camera3buffer->data[i]);\n>>>> +\t\t/*\n>>>> +\t\t * Setting length to zero here is OK as the length is only used\n>>>> +\t\t * to map the memory of the plane. Libcamera do not need to poke\n>>>> +\t\t * at the memory content queued by the HAL.\n>>>> +\t\t */\n>>>> +\t\tplane.length = 0;\n>>>> +\t\tplanes.push_back(std::move(plane));\n>>>> +\t}\n>>>> +\n>>>> +\treturn new FrameBuffer(std::move(planes));\n>>>> +}\n>>>> +\n>>>> int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Request)\n>>>> {\n>>>> \tStreamConfiguration *streamConfiguration = &config_->at(0);\n>>>> @@ -1064,22 +1082,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n>>>> \t * Create a libcamera buffer using the dmabuf descriptors of the first\n>>>> \t * and (currently) only supported request buffer.\n>>>> \t */\n>>>> -\tconst buffer_handle_t camera3Handle = *camera3Buffers[0].buffer;\n>>>> -\n>>>> -\tstd::vector planes;\n>>>> -\tfor (int i = 0; i < 3; i++) {\n>>>> -\t\tFrameBuffer::Plane plane;\n>>>> -\t\tplane.fd = FileDescriptor(camera3Handle->data[i]);\n>>>> -\t\t/*\n>>>> -\t\t * Setting length to zero here is OK as the length is only used\n>>>> -\t\t * to map the memory of the plane. Libcamera do not need to poke\n>>>> -\t\t * at the memory content queued by the HAL.\n>>>> -\t\t */\n>>>> -\t\tplane.length = 0;\n>>>> -\t\tplanes.push_back(std::move(plane));\n>>>> -\t}\n>>>> -\n>>>> -\tFrameBuffer *buffer = new FrameBuffer(std::move(planes));\n>>>> +\tFrameBuffer *buffer = newFrameBuffer(*camera3Buffers[0].buffer);\n>>>\n>>> Would it make sens to change the argument to a pointer instead of\n>>> dereferencing it here?\n>>\n>> buffer_handle_t is already a pointer, the function would then need to do\n>>\n>> \tplane.fd = FileDescriptor((*camera3buffer)->data[i]);\n>>\n>> which isn't nice. I think it's best to dereference it once only here, in\n>> the case function needs to access more than one field.\n\nYup, the ** was a pain, so I chose to dereference it here.\n\n\n>>\n>>> Also I think I would callt the function\n>>> constructFrameBuffer() or createFrameBuffer().\n>>\n>> I like createFrameBuffer() better, and I would make it a private member\n\n\nI'll rename to createFrameBuffer()\n\n\n>> of CameraDevice. With these changes,\n> \n> Me too, and I like this better as a private helper function\n\nAgreed, me too - this was just a remnant of hacking it in to get the\nreworks done.\n\n\n\n>> Reviewed-by: Laurent Pinchart \n> \n> Reviewed-by: Jacopo Mondi \n\nThanks.\n\n\n> \n> Thanks\n> j\n>>\n>>>> \tif (!buffer) {\n>>>> \t\tLOG(HAL, Error) << \"Failed to create buffer\";\n>>>> \t\tdelete descriptor;\n>>\n>> --\n>> Regards,\n>>\n>> Laurent Pinchart\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2E82CBE905\n\tfor ;\n\tFri, 3 Jul 2020 09:38:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F1AB860C58;\n\tFri, 3 Jul 2020 11:38:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9938D60C50\n\tfor ;\n\tFri, 3 Jul 2020 11:38:12 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0DDEA51B;\n\tFri, 3 Jul 2020 11:38:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oPvKqR2d\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593769092;\n\tbh=EIDTH3E6cjL9k9r/AYHgJPQfFECa1YeiPz+h0d0xOxY=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=oPvKqR2d9ItMHxQS7s42Q6wvblakoqzzQw5mpT84To1SrR+hpo2i3OikXppmVsW9+\n\t8PDgyHw5fd29PXa1J/dYcmTB0rYTRb/562IF4IeRCZZPlIQcxN8oC9zO3B74z7sF1A\n\t/7ggqfUD98MqkWw8i6DOeDGm+Y64ITt03sLAZmMc=","To":"Jacopo Mondi ,\n\tLaurent Pinchart ","References":"<20200702213654.2129054-1-kieran.bingham@ideasonboard.com>\n\t<20200702213654.2129054-5-kieran.bingham@ideasonboard.com>\n\t<20200702232559.GG3158543@oden.dyn.berto.se>\n\t<20200703002903.GC12562@pendragon.ideasonboard.com>\n\t<20200703091318.redpst35ko664b2f@uno.localdomain>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<53c5b4b6-5d1f-45bc-1b2a-397410742c26@ideasonboard.com>","Date":"Fri, 3 Jul 2020 10:38:09 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.8.0","MIME-Version":"1.0","In-Reply-To":"<20200703091318.redpst35ko664b2f@uno.localdomain>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 4/9] android: camera_device:\n\tSimplify FrameBuffer construction from a buffer_handle_t","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]