[{"id":11091,"web_url":"https://patchwork.libcamera.org/comment/11091/","msgid":"<20200702231504.GD3158543@oden.dyn.berto.se>","date":"2020-07-02T23:15:04","subject":"Re: [libcamera-devel] [PATCH v2 1/9] libcamera: camera: Allow\n\tunspecified roles for generateConfiguration","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nThanks for your work.\n\nOn 2020-07-02 22:36:46 +0100, Kieran Bingham wrote:\n> Providing an empty set of roles is permitted to generate an empty\n> configuration from the pipeline handlers.\n> \n> Overload the generateConfiguration() function such that not specifying a\n> roles parameter will use an empty set, and return an empty\n> configuration.\n> \n> Signed-off-by: Kieran Bingham \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/camera.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\n> index 9c0e58f7864b..4d1a4a9f52ec 100644\n> --- a/include/libcamera/camera.h\n> +++ b/include/libcamera/camera.h\n> @@ -89,7 +89,7 @@ public:\n> \tconst ControlList &properties();\n> \n> \tconst std::set &streams() const;\n> -\tstd::unique_ptr generateConfiguration(const StreamRoles &roles);\n> +\tstd::unique_ptr generateConfiguration(const StreamRoles &roles = {});\n> \tint configure(CameraConfiguration *config);\n> \n> \tRequest *createRequest(uint64_t cookie = 0);\n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 865B3BFFE2\n\tfor ;\n\tThu, 2 Jul 2020 23:15:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1F78160C57;\n\tFri, 3 Jul 2020 01:15:07 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 95612609C7\n\tfor ;\n\tFri, 3 Jul 2020 01:15:05 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id z24so9488511ljn.8\n\tfor ;\n\tThu, 02 Jul 2020 16:15:05 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tp13sm3379353ljj.101.2020.07.02.16.15.04\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 02 Jul 2020 16:15:04 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"actxEukC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=2CRyS7M4yi/dgzSD08bFWgm1rTBn98vieqiT+blc/wo=;\n\tb=actxEukC7TAT7Cwo92BRQbfgvJ9O/eOiVvBqDLs6a0eJdTMscn2ajZKa85YkE8rx65\n\twJUebOdryjWYSpNwh2JskbfABNsNLLvYRQGJHyT8q7HBCRNJjASX9qw2Ij0wNGfa5PiM\n\tt8OGRS+v61qr73yucgR1smS8LTMvSzZfUDV+W3bBit4438SwKKSd8ggul+pHIjPqpM2J\n\tdWTQnEOlyAc2iPLjBBhE3He72LN3nWvbVbToeJ4TINC27ufNkr0+lZQL0zYyv43hk8Og\n\tDiNao9Ld8yFzMa0Sn//Vm0OOSG00ujJxDpwyiN8YN3bTOYJNz6T/Lt85ISuAlMHZzd0X\n\tDSkg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=2CRyS7M4yi/dgzSD08bFWgm1rTBn98vieqiT+blc/wo=;\n\tb=F5XR69yA5AGzzDVjbIuCpj0WVsDMoDPV5YlA6qhMYLXY3NW2+otDbd417EM2fJnAUZ\n\tv+2kFuNfvI94ZgGiRPpJkzd6FrG1S3Xly4lSos5OgILk6Af5sd0cV9jPxKfYLo9syqqX\n\tR9/yUWT4uPCb9yPSBB5c2VxM5l89BkhxcSgBTGBORRCy5EgCuFqmhErqTepwVa3OQtrw\n\tL0IbuvKb6p6S8ippGZlA7TRrPySrkHXRlomBM9sqkkBRhN5hnicCZuKuQmRVwtMbB4a1\n\tXc7kO4MEf1heVuCSKen0j/WVNElvS1y0tWBwJ2tlEKXMZ1IfWOn9FB4z47MaMYjy01Ly\n\tTKZg==","X-Gm-Message-State":"AOAM530U9/fdlGQe3o+fSbQDEjHEPZvVss1rLh0PMIFkGMSooSeQxdMo\n\tquSb58ozgVQ3b5NCv6KaMDfrrr88922gNg==","X-Google-Smtp-Source":"ABdhPJzANiOvHw3RoXW6vmZKvQtslFamWJ0/eeiqs4qqoA88n9FRaXyEBn6mBnOkyIO4I0pIjxzcUQ==","X-Received":"by 2002:a2e:8816:: with SMTP id\n\tx22mr6088027ljh.304.1593731704979; \n\tThu, 02 Jul 2020 16:15:04 -0700 (PDT)","Date":"Fri, 3 Jul 2020 01:15:04 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Message-ID":"<20200702231504.GD3158543@oden.dyn.berto.se>","References":"<20200702213654.2129054-1-kieran.bingham@ideasonboard.com>\n\t<20200702213654.2129054-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200702213654.2129054-2-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/9] libcamera: camera: Allow\n\tunspecified roles for generateConfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11119,"web_url":"https://patchwork.libcamera.org/comment/11119/","msgid":"<20200703085749.qjqy3drkemgj7hnz@uno.localdomain>","date":"2020-07-03T08:57:49","subject":"Re: [libcamera-devel] [PATCH v2 1/9] libcamera: camera: Allow\n\tunspecified roles for generateConfiguration","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Thu, Jul 02, 2020 at 10:36:46PM +0100, Kieran Bingham wrote:\n> Providing an empty set of roles is permitted to generate an empty\n> configuration from the pipeline handlers.\n>\n> Overload the generateConfiguration() function such that not specifying a\n> roles parameter will use an empty set, and return an empty\n> configuration.\n>\n> Signed-off-by: Kieran Bingham \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> include/libcamera/camera.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\n> index 9c0e58f7864b..4d1a4a9f52ec 100644\n> --- a/include/libcamera/camera.h\n> +++ b/include/libcamera/camera.h\n> @@ -89,7 +89,7 @@ public:\n> \tconst ControlList &properties();\n>\n> \tconst std::set &streams() const;\n> -\tstd::unique_ptr generateConfiguration(const StreamRoles &roles);\n> +\tstd::unique_ptr generateConfiguration(const StreamRoles &roles = {});\n> \tint configure(CameraConfiguration *config);\n>\n> \tRequest *createRequest(uint64_t cookie = 0);\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0F628BFFE2\n\tfor ;\n\tFri, 3 Jul 2020 08:54:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A74E260C57;\n\tFri, 3 Jul 2020 10:54:19 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E27660C50\n\tfor ;\n\tFri, 3 Jul 2020 10:54:18 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id B9302E0002;\n\tFri, 3 Jul 2020 08:54:17 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Fri, 3 Jul 2020 10:57:49 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20200703085749.qjqy3drkemgj7hnz@uno.localdomain>","References":"<20200702213654.2129054-1-kieran.bingham@ideasonboard.com>\n\t<20200702213654.2129054-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200702213654.2129054-2-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/9] libcamera: camera: Allow\n\tunspecified roles for generateConfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]