[{"id":11059,"web_url":"https://patchwork.libcamera.org/comment/11059/","msgid":"<20200701165448.GO2399385@oden.dyn.berto.se>","date":"2020-07-01T16:54:48","subject":"Re: [libcamera-devel] [PATCH 14/15] libcamera: ipu3: Rename\n\tImgUDevice::configureInput()","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-07-01 14:30:35 +0200, Jacopo Mondi wrote:\n> Rename the ImgUDevice::configureInput() method to just configure() as it\n> will be modified not only configure the ImgU unit input, but calculate\n> the whole pipeline configuration parameters.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-\n> src/libcamera/pipeline/ipu3/imgu.h | 2 +-\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> 3 files changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\n> index 49201157eb07..f580c1d2ff6c 100644\n> --- a/src/libcamera/pipeline/ipu3/imgu.cpp\n> +++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n> @@ -99,7 +99,7 @@ int ImgUDevice::init(MediaDevice *media, unsigned int index)\n> * \\param[in] inputFormat The format to be applied to ImgU input\n> * \\return 0 on success or a negative error code otherwise\n> */\n> -int ImgUDevice::configureInput(struct Pipe *pipe, V4L2DeviceFormat *inputFormat)\n> +int ImgUDevice::configure(struct Pipe *pipe, V4L2DeviceFormat *inputFormat)\n> {\n> \t/* Configure the ImgU input video device with the requested sizes. */\n> \tint ret = input_->setFormat(inputFormat);\n> diff --git a/src/libcamera/pipeline/ipu3/imgu.h b/src/libcamera/pipeline/ipu3/imgu.h\n> index c0353955ea43..45c5cc1ce8e6 100644\n> --- a/src/libcamera/pipeline/ipu3/imgu.h\n> +++ b/src/libcamera/pipeline/ipu3/imgu.h\n> @@ -31,7 +31,7 @@ public:\n> \n> \tint init(MediaDevice *media, unsigned int index);\n> \n> -\tint configureInput(struct Pipe *pipe, V4L2DeviceFormat *inputFormat);\n> +\tint configure(struct Pipe *pipe, V4L2DeviceFormat *inputFormat);\n> \n> \tint configureOutput(const StreamConfiguration &cfg,\n> \t\t\t V4L2DeviceFormat *outputFormat)\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 9499c127ef79..317e78155ebb 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -459,7 +459,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n> \t * Configure the ImgU with the collected pipe configuration and the\n> \t * CIO2 unit format.\n> \t */\n> -\tret = imgu->configureInput(&imguPipe, &cio2Format);\n> +\tret = imgu->configure(&imguPipe, &cio2Format);\n> \tif (ret)\n> \t\treturn ret;\n> \n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 35F33BE905\n\tfor ;\n\tWed, 1 Jul 2020 16:54:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 046D160C56;\n\tWed, 1 Jul 2020 18:54:51 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B4979609A9\n\tfor ;\n\tWed, 1 Jul 2020 18:54:49 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id h19so27981976ljg.13\n\tfor ;\n\tWed, 01 Jul 2020 09:54:49 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ti2sm1998452lji.59.2020.07.01.09.54.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 01 Jul 2020 09:54:48 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"guAvLvEo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=dIT29yMPfE4JkB0pthCBKBYP/gYkIvFL1aZVdavK4pc=;\n\tb=guAvLvEoYfjEznqaVqMsbcU4TP3xXwHAz+9yUZyoiD9tkVn/Pxm2XETyEpv5mGfM2q\n\tv5HolQicL8hea9659kU8ifS/UT4vkywJg/KFZq7E/KdZgbv5TLY9q3V0lTzMyN+8hcSY\n\tE3AdQ9GeOlhIBtuB/U6ouzRWDXxSkhYUfmzbizq7W6iKLYlC0/TIV70U335ZoToloMU9\n\tI4PbHWFnZuhS88IlFNwrZ76+Ch4gw5Vy+U2wq6fWimFfYp00JV4nqtnADtTiXcS3K4bU\n\tuFW5UnalLoml/kdPEL8APuwhzBBrV0gjfjJO2PgZs51cSUng/Z7DumAtl4cQsV9tw6Nr\n\temuQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=dIT29yMPfE4JkB0pthCBKBYP/gYkIvFL1aZVdavK4pc=;\n\tb=P1KGR/fEoYSxICiKoW8bFfCJBjcvNNLTOqgy+aSzsZtAQD9rG6CdPs0CtbC4ODLK4A\n\tPspahvhq01lRrD/TqqpCnzOYxr6/kdg7fWgXDLHLXxN4FXnvi40c2wGsSSJNI6n84iOI\n\tD6Yp2fEChoL5bMLSO4AEVp6zJpb4ISp8TOcefWdYYt48quXmbwCbMJjr+TkZzUggsCW1\n\tfeKy/R1UGsCvqugX6SterM3qhTadOTArZBzDfUgGaJqbwA7xS6JBDv/bJEUigXtJn+Fe\n\tVSrbY33EEM7GKVuA5n3nEqUi6jzIfxnuGKbSErkF2LWwbAI/NIpI16xzjVW1Fv5TeFri\n\t7TKA==","X-Gm-Message-State":"AOAM5319Pwr/UV1kbkjHn4HdRlxXTdRqvIXxzq9lFRdi5CheTaEeJj2i\n\tNGcWe6kBR7ehJZQIqSiqMzvry7U0y6U=","X-Google-Smtp-Source":"ABdhPJwVB03iUSb+SoYK2OqI1T5g/0q8P9KC8/VYLayW8i/kBqlliyIlE/LC1R1lYBHivZdtQadhSQ==","X-Received":"by 2002:a2e:a484:: with SMTP id\n\th4mr14213639lji.468.1593622489201; \n\tWed, 01 Jul 2020 09:54:49 -0700 (PDT)","Date":"Wed, 1 Jul 2020 18:54:48 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200701165448.GO2399385@oden.dyn.berto.se>","References":"<20200701123036.51922-1-jacopo@jmondi.org>\n\t<20200701123036.51922-15-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200701123036.51922-15-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 14/15] libcamera: ipu3: Rename\n\tImgUDevice::configureInput()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]