{"id":8541,"url":"https://patchwork.libcamera.org/api/patches/8541/?format=json","web_url":"https://patchwork.libcamera.org/patch/8541/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200701123036.51922-15-jacopo@jmondi.org>","date":"2020-07-01T12:30:35","name":"[libcamera-devel,14/15] libcamera: ipu3: Rename ImgUDevice::configureInput()","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"3917d8cab657d9a3c9a6f08537eb74ffbc143538","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/8541/mbox/","series":[{"id":1066,"url":"https://patchwork.libcamera.org/api/series/1066/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1066","date":"2020-07-01T12:30:21","name":"libcamera: ipu3: Rework streams configuration","version":1,"mbox":"https://patchwork.libcamera.org/series/1066/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8541/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8541/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B3A0FC2E6B\n\tfor ;\n\tWed, 1 Jul 2020 12:27:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8B9A460D4C;\n\tWed, 1 Jul 2020 14:27:29 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2295C60CE8\n\tfor ;\n\tWed, 1 Jul 2020 14:27:27 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id B69881C000F;\n\tWed, 1 Jul 2020 12:27:26 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 1 Jul 2020 14:30:35 +0200","Message-Id":"<20200701123036.51922-15-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200701123036.51922-1-jacopo@jmondi.org>","References":"<20200701123036.51922-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 14/15] libcamera: ipu3: Rename\n\tImgUDevice::configureInput()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Rename the ImgUDevice::configureInput() method to just configure() as it\nwill be modified not only configure the ImgU unit input, but calculate\nthe whole pipeline configuration parameters.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-\n src/libcamera/pipeline/ipu3/imgu.h | 2 +-\n src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\nindex 49201157eb07..f580c1d2ff6c 100644\n--- a/src/libcamera/pipeline/ipu3/imgu.cpp\n+++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n@@ -99,7 +99,7 @@ int ImgUDevice::init(MediaDevice *media, unsigned int index)\n * \\param[in] inputFormat The format to be applied to ImgU input\n * \\return 0 on success or a negative error code otherwise\n */\n-int ImgUDevice::configureInput(struct Pipe *pipe, V4L2DeviceFormat *inputFormat)\n+int ImgUDevice::configure(struct Pipe *pipe, V4L2DeviceFormat *inputFormat)\n {\n \t/* Configure the ImgU input video device with the requested sizes. */\n \tint ret = input_->setFormat(inputFormat);\ndiff --git a/src/libcamera/pipeline/ipu3/imgu.h b/src/libcamera/pipeline/ipu3/imgu.h\nindex c0353955ea43..45c5cc1ce8e6 100644\n--- a/src/libcamera/pipeline/ipu3/imgu.h\n+++ b/src/libcamera/pipeline/ipu3/imgu.h\n@@ -31,7 +31,7 @@ public:\n \n \tint init(MediaDevice *media, unsigned int index);\n \n-\tint configureInput(struct Pipe *pipe, V4L2DeviceFormat *inputFormat);\n+\tint configure(struct Pipe *pipe, V4L2DeviceFormat *inputFormat);\n \n \tint configureOutput(const StreamConfiguration &cfg,\n \t\t\t V4L2DeviceFormat *outputFormat)\ndiff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 9499c127ef79..317e78155ebb 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -459,7 +459,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n \t * Configure the ImgU with the collected pipe configuration and the\n \t * CIO2 unit format.\n \t */\n-\tret = imgu->configureInput(&imguPipe, &cio2Format);\n+\tret = imgu->configure(&imguPipe, &cio2Format);\n \tif (ret)\n \t\treturn ret;\n \n","prefixes":["libcamera-devel","14/15"]}