[{"id":11057,"web_url":"https://patchwork.libcamera.org/comment/11057/","msgid":"<20200701165056.GM2399385@oden.dyn.berto.se>","date":"2020-07-01T16:50:56","subject":"Re: [libcamera-devel] [PATCH 12/15] libcamera: ipu3: add\n\tImgUDevice::Pipe","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your patch.\n\nOn 2020-07-01 14:30:33 +0200, Jacopo Mondi wrote:\n> Add a structure that describes the ImgU pipe configuration.\n> \n> The new structure reports the size of the ImgU input frame, the\n> desired main output size and desired viewfinder size.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/ipu3/imgu.cpp | 19 +++++++++++++++++++\n> src/libcamera/pipeline/ipu3/imgu.h | 6 ++++++\n> 2 files changed, 25 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\n> index d7f4173d3607..7e9047cc8dc1 100644\n> --- a/src/libcamera/pipeline/ipu3/imgu.cpp\n> +++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n> @@ -19,6 +19,25 @@ namespace libcamera {\n> \n> LOG_DECLARE_CATEGORY(IPU3)\n> \n> +/**\n> + * \\struct Pipe\n> + * \\brief Describe the ImgU requested configuration\n> + *\n> + * The ImgU unit processes images through several components, which have\n> + * to be properly configured inspecting the input image size and the desired\n> + * output sizes. This structure collects the ImgU input configuration and the\n> + * requested main output and viewfinder configurations.\n> + *\n> + * \\var Pipe::input\n> + * \\brief The input image size\n> + *\n> + * \\var Pipe::output\n> + * \\brief The requested main output size\n> + *\n> + * \\var Pipe::viewfinder\n> + * \\brief The requested viewfinder size\n> + */\n> +\n> /**\n> * \\brief Initialize components of the ImgU instance\n> * \\param[in] mediaDevice The ImgU instance media device\n> diff --git a/src/libcamera/pipeline/ipu3/imgu.h b/src/libcamera/pipeline/ipu3/imgu.h\n> index 5c124af2e9fe..8fb271fb8350 100644\n> --- a/src/libcamera/pipeline/ipu3/imgu.h\n> +++ b/src/libcamera/pipeline/ipu3/imgu.h\n> @@ -23,6 +23,12 @@ struct StreamConfiguration;\n> class ImgUDevice\n> {\n> public:\n> +\tstruct Pipe {\n> +\t\tSize input;\n> +\t\tSize output;\n> +\t\tSize viewfinder;\n> +\t};\n> +\n> \tint init(MediaDevice *media, unsigned int index);\n> \n> \tint configureInput(const Size &size, V4L2DeviceFormat *inputFormat);\n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1813ABFFE2\n\tfor ;\n\tWed, 1 Jul 2020 16:50:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D5F7260C56;\n\tWed, 1 Jul 2020 18:50:58 +0200 (CEST)","from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 156C160C53\n\tfor ;\n\tWed, 1 Jul 2020 18:50:58 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id 9so27968846ljv.5\n\tfor ;\n\tWed, 01 Jul 2020 09:50:58 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ty143sm2233949lff.88.2020.07.01.09.50.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 01 Jul 2020 09:50:56 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"ThfvxemB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=W5lEN0DFVrDCL0XUxi3urqIV9RDlIgNGqGQRVvgggEY=;\n\tb=ThfvxemBLKjf3PJyIjdFjfa4vqid3p1Y9vbYqIvrFvTTn148wWmmmkKuH6bbQGTBpO\n\tolo1Q65nEWgapf/uHVMHq084DDdXQ+SO9g8hbxMuC9gzjmo9a7NkoN9yTsX7Mj5j1FGO\n\ttWZCeZgAhX3JjbfpOLDs+3rWF0uFT+6BGwPLDGdPqLXinypsaClom6WsGPsALQRSL+e8\n\t1+SX6wmn8TaBMNkM8Lp191RC0WBQHO8JnhlyVeJi12aJDxGx01kFwANSiPCijNM3yP/z\n\thkXamsPZqWgkne32ceqleVaH1b+Ke4QkMsDsx/SsfMAY8uyMilrgZsIb6/JFu7jzwVFT\n\tFN5Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=W5lEN0DFVrDCL0XUxi3urqIV9RDlIgNGqGQRVvgggEY=;\n\tb=iuROxB6r0vycLPzIMzyewYyCAHHf1/OQcUAeDERzJzDc4O1mutNts4HGtfLuWLswto\n\tHIFSJDjS1UJpVQABlIHe6AWimpWbXeKBJIUTHBruh5QQpl8J1/SQfvZsjM6dOuaSItrP\n\tzD8NoGoIqxQwzrFApmBWpWqavS7s7xykCLJyt5XM3UjWPDDX32DAdAEpMPfF5U0vX9Yh\n\tnPz2v28NdA3v0LwApoSyfnVRkqHpGDQF1lvYb0l0vXKtffFwihehgvKPWYELHyCs12Ng\n\tPxwphkez9NnWoq2CHczOxyTkr6+HoyOQhvmUAKlX3uVK6uICntUTgV8k/0Xd1fs0K15j\n\tTtIw==","X-Gm-Message-State":"AOAM531fe6hUgegQzJnWdVl0E+oDK5GAYUb/NbIGvLehFxUImnkyB75z\n\taNLi1MxhYeVLN+n7I7ZyWsZJU5TsxpM=","X-Google-Smtp-Source":"ABdhPJwm6x2/kcVxbT7MPjDeRBemv2VuCDegk5Ku79wEWx1+kNWggKQXN1kN8CXSej5xLNyNDyAwTw==","X-Received":"by 2002:a2e:5141:: with SMTP id\n\tb1mr13173963lje.336.1593622257400; \n\tWed, 01 Jul 2020 09:50:57 -0700 (PDT)","Date":"Wed, 1 Jul 2020 18:50:56 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200701165056.GM2399385@oden.dyn.berto.se>","References":"<20200701123036.51922-1-jacopo@jmondi.org>\n\t<20200701123036.51922-13-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200701123036.51922-13-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 12/15] libcamera: ipu3: add\n\tImgUDevice::Pipe","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]