{"id":8539,"url":"https://patchwork.libcamera.org/api/patches/8539/?format=json","web_url":"https://patchwork.libcamera.org/patch/8539/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200701123036.51922-13-jacopo@jmondi.org>","date":"2020-07-01T12:30:33","name":"[libcamera-devel,12/15] libcamera: ipu3: add ImgUDevice::Pipe","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"04a126c0dbf4a37807a03b5aa0e0e83069a40573","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/8539/mbox/","series":[{"id":1066,"url":"https://patchwork.libcamera.org/api/series/1066/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1066","date":"2020-07-01T12:30:21","name":"libcamera: ipu3: Rework streams configuration","version":1,"mbox":"https://patchwork.libcamera.org/series/1066/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8539/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8539/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6EBA7BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  1 Jul 2020 12:27:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4892C60C5C;\n\tWed,  1 Jul 2020 14:27:29 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 109EB60CC2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  1 Jul 2020 14:27:26 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id A5E741C0007;\n\tWed,  1 Jul 2020 12:27:25 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Wed,  1 Jul 2020 14:30:33 +0200","Message-Id":"<20200701123036.51922-13-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200701123036.51922-1-jacopo@jmondi.org>","References":"<20200701123036.51922-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 12/15] libcamera: ipu3: add\n\tImgUDevice::Pipe","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Add a structure that describes the ImgU pipe configuration.\n\nThe new structure reports the size of the ImgU input frame, the\ndesired main output size and desired viewfinder size.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/ipu3/imgu.cpp | 19 +++++++++++++++++++\n src/libcamera/pipeline/ipu3/imgu.h   |  6 ++++++\n 2 files changed, 25 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\nindex d7f4173d3607..7e9047cc8dc1 100644\n--- a/src/libcamera/pipeline/ipu3/imgu.cpp\n+++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n@@ -19,6 +19,25 @@ namespace libcamera {\n \n LOG_DECLARE_CATEGORY(IPU3)\n \n+/**\n+ * \\struct Pipe\n+ * \\brief Describe the ImgU requested configuration\n+ *\n+ * The ImgU unit processes images through several components, which have\n+ * to be properly configured inspecting the input image size and the desired\n+ * output sizes. This structure collects the ImgU input configuration and the\n+ * requested main output and viewfinder configurations.\n+ *\n+ * \\var Pipe::input\n+ * \\brief The input image size\n+ *\n+ * \\var Pipe::output\n+ * \\brief The requested main output size\n+ *\n+ * \\var Pipe::viewfinder\n+ * \\brief The requested viewfinder size\n+ */\n+\n /**\n  * \\brief Initialize components of the ImgU instance\n  * \\param[in] mediaDevice The ImgU instance media device\ndiff --git a/src/libcamera/pipeline/ipu3/imgu.h b/src/libcamera/pipeline/ipu3/imgu.h\nindex 5c124af2e9fe..8fb271fb8350 100644\n--- a/src/libcamera/pipeline/ipu3/imgu.h\n+++ b/src/libcamera/pipeline/ipu3/imgu.h\n@@ -23,6 +23,12 @@ struct StreamConfiguration;\n class ImgUDevice\n {\n public:\n+\tstruct Pipe {\n+\t\tSize input;\n+\t\tSize output;\n+\t\tSize viewfinder;\n+\t};\n+\n \tint init(MediaDevice *media, unsigned int index);\n \n \tint configureInput(const Size &size, V4L2DeviceFormat *inputFormat);\n","prefixes":["libcamera-devel","12/15"]}