[{"id":11055,"web_url":"https://patchwork.libcamera.org/comment/11055/","msgid":"<20200701164954.GK2399385@oden.dyn.berto.se>","date":"2020-07-01T16:49:54","subject":"Re: [libcamera-devel] [PATCH 10/15] libcamera: ipu3: Remove camera_\n\tfrom IPU3CameraConfiguration","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-07-01 14:30:31 +0200, Jacopo Mondi wrote:\n> The IPU3CameraConfiguration::camera_ shared pointer is not used.\n> Remove it.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 14 +++-----------\n> 1 file changed, 3 insertions(+), 11 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 4d70f9e3a30c..16bda97a3cc3 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -59,19 +59,13 @@ public:\n> class IPU3CameraConfiguration : public CameraConfiguration\n> {\n> public:\n> -\tIPU3CameraConfiguration(Camera *camera, IPU3CameraData *data);\n> +\tIPU3CameraConfiguration(IPU3CameraData *data);\n> \n> \tStatus validate() override;\n> \n> \tconst StreamConfiguration &cio2Format() const { return cio2Configuration_; };\n> \n> private:\n> -\t/*\n> -\t * The IPU3CameraData instance is guaranteed to be valid as long as the\n> -\t * corresponding Camera instance is valid. In order to borrow a\n> -\t * reference to the camera data, store a new reference to the camera.\n> -\t */\n> -\tstd::shared_ptr camera_;\n> \tconst IPU3CameraData *data_;\n> \n> \tStreamConfiguration cio2Configuration_;\n> @@ -121,11 +115,9 @@ private:\n> \tMediaDevice *imguMediaDev_;\n> };\n> \n> -IPU3CameraConfiguration::IPU3CameraConfiguration(Camera *camera,\n> -\t\t\t\t\t\t IPU3CameraData *data)\n> +IPU3CameraConfiguration::IPU3CameraConfiguration(IPU3CameraData *data)\n> \t: CameraConfiguration()\n> {\n> -\tcamera_ = camera->shared_from_this();\n> \tdata_ = data;\n> }\n> \n> @@ -234,7 +226,7 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n> \t\t\t\t\t\t\t\tconst StreamRoles &roles)\n> {\n> \tIPU3CameraData *data = cameraData(camera);\n> -\tIPU3CameraConfiguration *config = new IPU3CameraConfiguration(camera, data);\n> +\tIPU3CameraConfiguration *config = new IPU3CameraConfiguration(data);\n> \tCIO2Device *cio2 = &data->cio2_;\n> \n> \tif (roles.empty())\n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 37756BFFE2\n\tfor ;\n\tWed, 1 Jul 2020 16:49:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 04F4860C58;\n\tWed, 1 Jul 2020 18:49:58 +0200 (CEST)","from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8311060C53\n\tfor ;\n\tWed, 1 Jul 2020 18:49:56 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id d17so13274325ljl.3\n\tfor ;\n\tWed, 01 Jul 2020 09:49:56 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\te29sm2246580lfc.51.2020.07.01.09.49.55\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 01 Jul 2020 09:49:55 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"NYs/BwTA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=WbhQlEOX7XQ5DoKnDANk6gTIqN3nLqaxnJs5V4/OnWA=;\n\tb=NYs/BwTAbv068gks2ZlppOlkyMr9BT33btcY/oN+uYedXOFvSh/YA2/H/JWwTUGlF/\n\tac14mspPgR9A2lfG2NLg4xSXvRBtOkRV5wr24RYVuZJ5rnHBbFM7br2w+BA4XAxapapF\n\tymEsPIaJP92HqrVDlaxagR4rWPfVAVXOfme5eF0isbXIGS0rMDqB2tYx1tR/pksvq90x\n\tTWSOupE2eYWxJYeF0gkQcgC+x1o712bL6S79xcxX34g/o4NYfiElLUoSVhZGVswbZhv4\n\tOtWiCSiX3jlW2jsZ/H3wgVI8nxE4iF6JSRf3qtgPQPMSpM/tLYpT7FTSDAt/GIuDN9Pr\n\tnAwQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=WbhQlEOX7XQ5DoKnDANk6gTIqN3nLqaxnJs5V4/OnWA=;\n\tb=RqFdJBMOr5O4gCTlVpTV/kRPWG2HllRDBee1JJ/5FFmPA1sbPrZz2clHABMexO7U8n\n\tvZ8qsfbdiiFiln1sopzTd14wjr6dwkDTTskXQ5Ru9gOI/jvBXDKlPQF1t2Oyve4UOqYy\n\tcYrRdygDje8F3S358ucHHL9F3Gn80oQCBEfXBHsH8vTQqoLLkmfZAXEf9tNhveJ4XLJi\n\tHE5bEoYEiUlxzHClAPkENvEOBFw8WVluTjPl/o80QRhBw++2HOEkK2I9zQGAmsOynFL2\n\t57vKZknq/hGIFgr9+IFymmWxvIGgfoZ8zBJRbMKvgykAzWTXrBoldXJqs+KrPMBt+AP8\n\tlp6Q==","X-Gm-Message-State":"AOAM531naoMkEsGVI/G0mT28nYhXynCrhgPxGaDilDr3rJi150T9ro1v\n\tmEYRCbVIa8o/lHjaq7NxgIMdIje7wA0=","X-Google-Smtp-Source":"ABdhPJx4zOJF8cIIJ6svjwHBnv3UUBC8UdjI18Inzammr+Gf5Rl+l/sAGKP4HDcacdTugtZV/1FTYg==","X-Received":"by 2002:a2e:8e68:: with SMTP id t8mr7231599ljk.335.1593622195929;\n\tWed, 01 Jul 2020 09:49:55 -0700 (PDT)","Date":"Wed, 1 Jul 2020 18:49:54 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200701164954.GK2399385@oden.dyn.berto.se>","References":"<20200701123036.51922-1-jacopo@jmondi.org>\n\t<20200701123036.51922-11-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200701123036.51922-11-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 10/15] libcamera: ipu3: Remove camera_\n\tfrom IPU3CameraConfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]