[{"id":11054,"web_url":"https://patchwork.libcamera.org/comment/11054/","msgid":"<20200701164932.GJ2399385@oden.dyn.berto.se>","date":"2020-07-01T16:49:32","subject":"Re: [libcamera-devel] [PATCH 09/15] libcamera: ipu3: Remove streams\n\tfrom IPU3CameraConfiguration","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-07-01 14:30:30 +0200, Jacopo Mondi wrote:\n> The IPU3CameraConfiguration::streams_ field was used to keep an\n> association between the StreamConfiguration and the assigned streams\n> before CameraConfiguration::setStream() was called at configure() time.\n> \n> The stream assignment was based on the order in which elements were\n> inserted in the vector, implementing a fragile association between\n> streams and their intended configurations.\n> \n> As stream assignment now happens at configure() time, there is no need\n> to keep that association in place, and the streams_ vector is now unused.\n> \n> Remove it and the associated accessor method from the\n> IPU3CameraConfiguration class.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 --\n> 1 file changed, 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 8f75c5186b13..4d70f9e3a30c 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -64,7 +64,6 @@ public:\n> \tStatus validate() override;\n> \n> \tconst StreamConfiguration &cio2Format() const { return cio2Configuration_; };\n> -\tconst std::vector &streams() { return streams_; }\n> \n> private:\n> \t/*\n> @@ -76,7 +75,6 @@ private:\n> \tconst IPU3CameraData *data_;\n> \n> \tStreamConfiguration cio2Configuration_;\n> -\tstd::vector streams_;\n> };\n> \n> class PipelineHandlerIPU3 : public PipelineHandler\n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 114C5BFFE2\n\tfor ;\n\tWed, 1 Jul 2020 16:49:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A398A60C58;\n\tWed, 1 Jul 2020 18:49:35 +0200 (CEST)","from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 81ACD60C53\n\tfor ;\n\tWed, 1 Jul 2020 18:49:34 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id f5so12089558ljj.10\n\tfor ;\n\tWed, 01 Jul 2020 09:49:34 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\t81sm2249133lfj.24.2020.07.01.09.49.33\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 01 Jul 2020 09:49:33 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"2McF7qqV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=71K/tQx6w+RsRO2gS3B7WUzItUXR35ytTG2NH4Cce9Q=;\n\tb=2McF7qqVrB4jVD1vGe+JQxauJHfKpSlz/IRi7oeWjPUlJPUwCAsHZu/0ofnAvppqSq\n\t5ymrVtq+2blYzt+HdH623ZwtC6VVA+dfPcr2+Qq3/f9XpXc+f0o4dBSUliLe2KfgPYBB\n\tmaSZK5HilxDOIOQs6VUrY6jIQTXcxpp41pqOFI05Cyj2jHzmuamFuQmOEBOx9YqNdq59\n\t0OJYRWkQECx352OK7iP1dyQbXTMf32kPnv6Sfhh0cocNVeSuKDP0sBg8j+DmJmbmTExR\n\tCDUEHxr7QPoDYs0EMvBVgXRLir50aQkbEEGtMeUmGm5vhnkcpS+phSB4nVS+5cLHJCeg\n\tcrqA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=71K/tQx6w+RsRO2gS3B7WUzItUXR35ytTG2NH4Cce9Q=;\n\tb=lZIAm4p7NXh25iq9+BPD+XGfntMyJyheiIcSZwoHIt3o0aDz3+naLhnFPWs7GQHRth\n\tcOofakSPSzszreOMCU4vMsfDl80PMclTsirBFQhoJx4brNb2DWoix5+3uGRbBfT6IOJk\n\tJ/eXVrciTPTrMLfXdSEeFAZQoWNI/3SJC7qF7Rvqc50l7C5pddBPGP4NO2ULgaFXWfub\n\to+kZ1AKiUB8kqkD7dDc+nLudSqO4/GqbQYnQ+Ld8NO137+Qc/c4hGPWR/T8y32cVROBB\n\tEviTol75sC4yF8uGNcOTq66jf+w9o6mFaJOSXGsEtzO6wS3Wy9Ol354U9CP3emg8m/v+\n\tFxUw==","X-Gm-Message-State":"AOAM5315ouPbjuT1jqJBw1TacqT9xfZTlsmO7r79vHzjgW9WXgq//heE\n\t3SKUDj6RU9+7s0g+IB+jDf4CAg==","X-Google-Smtp-Source":"ABdhPJwoH/Bqv3FdPTgVYrDK1hHNDkpPJEKJ4HPZhtn130rUNqRMdmKAkazuJXHfq3gkuoBk4/Oh4w==","X-Received":"by 2002:a2e:161a:: with SMTP id\n\tw26mr13898227ljd.216.1593622173869; \n\tWed, 01 Jul 2020 09:49:33 -0700 (PDT)","Date":"Wed, 1 Jul 2020 18:49:32 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200701164932.GJ2399385@oden.dyn.berto.se>","References":"<20200701123036.51922-1-jacopo@jmondi.org>\n\t<20200701123036.51922-10-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200701123036.51922-10-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 09/15] libcamera: ipu3: Remove streams\n\tfrom IPU3CameraConfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]