[{"id":11049,"web_url":"https://patchwork.libcamera.org/comment/11049/","msgid":"<20200701162422.GF2399385@oden.dyn.berto.se>","date":"2020-07-01T16:24:22","subject":"Re: [libcamera-devel] [PATCH 04/15] libcamera: ipu3: Do not\n\toverwrite StreamConfiguration","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-07-01 14:30:25 +0200, Jacopo Mondi wrote:\n> The validate function overwrites the generated StreamConfiguration with\n> the one reported by the CIO2 unit when inspecting the RAW stream\n> configuration.\n> \n> As we prepare to add StreamFormats to the IPU3 StreamConfiguration,\n> assigning to the CIO2 generated configuration would delete the\n> StreamFormats.\n> \n> Fix this by updating relevant fields only in order to keep the\n> assigned StreamFormats.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 97fc8b60c3cb..cd18c6f31023 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -264,7 +264,9 @@ CameraConfiguration::Status IPU3CameraConfiguration::validate()\n> \t\tconst Stream *stream = streams_[i];\n> \n> \t\tif (stream == &data_->rawStream_) {\n> -\t\t\tcfg = cio2Configuration_;\n> +\t\t\tcfg.size = cio2Configuration_.size;\n> +\t\t\tcfg.pixelFormat = cio2Configuration_.pixelFormat;\n> +\t\t\tcfg.bufferCount = cio2Configuration_.bufferCount;\n> \t\t} else {\n> \t\t\tbool scale = stream == &data_->vfStream_;\n> \t\t\tadjustStream(config_[i], scale);\n> --\n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 266F2BE905\n\tfor ;\n\tWed, 1 Jul 2020 16:24:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ECA9E609A9;\n\tWed, 1 Jul 2020 18:24:24 +0200 (CEST)","from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A1E1A609A9\n\tfor ;\n\tWed, 1 Jul 2020 18:24:23 +0200 (CEST)","by mail-lf1-x142.google.com with SMTP id g2so14039536lfb.0\n\tfor ;\n\tWed, 01 Jul 2020 09:24:23 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tm18sm910676lfr.53.2020.07.01.09.24.22\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 01 Jul 2020 09:24:22 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"fOGf42E3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=Xy/ObXUOn7PBQWaFvRCql6CQn+2EdIBQ8PchFsJGies=;\n\tb=fOGf42E3ujrX0ZHJ3SpHQ1gfkoi/pdJLk59kr3m7s7MyBj1Muw1DJ5PUBqoYrY/ZHv\n\tHcq8usi1JsnW/QEfmuQf9bFu5FdmTo7u0H1N7/F6L48Wr2oSHLUOHTCYekx+RrniYZeh\n\t1+kZPyFB578INL/RV6+CDBO7OLcXmC9dWwjyCWDklG/0ei8CS+VxlcoFP2v2QMgIz2aM\n\tDPbNC8FwzxYFbpG+rLzBbJ0b675PS2U3bbJJmM4U0TKt8x4etY4fTCFw8qSiOUj1B5TH\n\tzK20R4kwKNjPE8u33jD/S6ZWwVwRdppyNKejFeboH8WBbsncnAD6RYC8mGjRWJbzWIma\n\tlE1Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=Xy/ObXUOn7PBQWaFvRCql6CQn+2EdIBQ8PchFsJGies=;\n\tb=oFbUyOeLRFhhSPSMIKob+nyX6NSoMpftakvnvPT6/h3IovuRM8LAC6ucyoT1ONrj0s\n\tMIW7liWnr4QF0BEePbD0BzqkQ7/xDEwvj6vEZrUyCJnPwkocEDVLF9GQetcjtQqlHCl2\n\tvNuwA+L35kRQELZUSkJXPLCuuwXRzHBwW5KVl83603oFT7ZqAqGavvhwXfKHoxyNMjXq\n\twhbpqD6dpvGw93IDAJDZE1M+3xThk8tL74S2r9GiOkZAf0GXnWpKkRdwxNqWn5QKKqB2\n\tsUOC1pDF4ZpKEpyjPxeMhT5Y59n+1Y9EcFCebN7Gh4phamcwO1kxGnpvrmeQgvUOjKMd\n\tD1Ew==","X-Gm-Message-State":"AOAM532ZkmCAvM7uSDtUoJifG9X6myhZT6CoTpCRH+EhTaBryEFMKyfP\n\tpcyLhVX2JyR9XlMeVqDADAg1Xg==","X-Google-Smtp-Source":"ABdhPJzEp3pPCb/2Q8dj0oSme0YH0nFW3C3DQrxOdA/zU58VHCOPWwFx1szqRI1na32+LpfFYzd9aw==","X-Received":"by 2002:a19:815:: with SMTP id 21mr15237747lfi.119.1593620663127;\n\tWed, 01 Jul 2020 09:24:23 -0700 (PDT)","Date":"Wed, 1 Jul 2020 18:24:22 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200701162422.GF2399385@oden.dyn.berto.se>","References":"<20200701123036.51922-1-jacopo@jmondi.org>\n\t<20200701123036.51922-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200701123036.51922-5-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 04/15] libcamera: ipu3: Do not\n\toverwrite StreamConfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]