[{"id":10982,"web_url":"https://patchwork.libcamera.org/comment/10982/","msgid":"<20200629202043.GO10681@pendragon.ideasonboard.com>","date":"2020-06-29T20:20:43","subject":"Re: [libcamera-devel] [PATCH 3/4] android: camera_device: Provide a\n\ttoPixelFormat helper","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Mon, Jun 29, 2020 at 05:39:15PM +0100, Kieran Bingham wrote:\n> Rather than converting pixelformats through the map, and then\n> dereferencing the iterator later, create a helper to explicitly return a\n> PixelFormat type.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/android/camera_device.cpp | 29 +++++++++++++++++++++--------\n> src/android/camera_device.h | 1 +\n> 2 files changed, 22 insertions(+), 8 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index f788c11e7254..a6410f42fee8 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -923,6 +923,20 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n> \treturn requestTemplate->get();\n> }\n> \n> +PixelFormat CameraDevice::toPixelFormat(int format)\n> +{\n> +\t/* Translate Android format code to libcamera pixel format. */\n> +\tauto it = formatsMap_.find(format);\n> +\tif (it == formatsMap_.end()) {\n> +\t\tLOG(HAL, Error) << \"Requested format \"\n> +\t\t\t\t<< utils::hex(format)\n> +\t\t\t\t<< \" not supported\";\n\nYou could reduce the number of lines with\n\n\t\tLOG(HAL, Error)\n\t\t\t<< \"Requested format \" << utils::hex(format)\n\t\t\t<< \" not supported\";\n\n\n> +\t\treturn PixelFormat();\n> +\t}\n> +\n> +\treturn it->second;\n> +}\n> +\n> /*\n> * Inspect the stream_list to produce a list of StreamConfiguration to\n> * be use to configure the Camera.\n> @@ -932,11 +946,14 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> \tfor (unsigned int i = 0; i < stream_list->num_streams; ++i) {\n> \t\tcamera3_stream_t *stream = stream_list->streams[i];\n> \n> +\t\tPixelFormat format = toPixelFormat(stream->format);\n> +\n> \t\tLOG(HAL, Info) << \"Stream #\" << i\n> \t\t\t << \", direction: \" << stream->stream_type\n> \t\t\t << \", width: \" << stream->width\n> \t\t\t << \", height: \" << stream->height\n> -\t\t\t << \", format: \" << utils::hex(stream->format);\n> +\t\t\t << \", format: \" << utils::hex(stream->format)\n> +\t\t\t << \" (\" << format.toString() << \")\";\n\nI wonder if it's really needed here, but I suppose it doesn't hurt\neither.\n\nReviewed-by: Laurent Pinchart \n\n> \t}\n> \n> \t/* Only one stream is supported. */\n> @@ -947,13 +964,9 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> \tcamera3_stream_t *camera3Stream = stream_list->streams[0];\n> \n> \t/* Translate Android format code to libcamera pixel format. */\n> -\tauto it = formatsMap_.find(camera3Stream->format);\n> -\tif (it == formatsMap_.end()) {\n> -\t\tLOG(HAL, Error) << \"Requested format \"\n> -\t\t\t\t<< utils::hex(camera3Stream->format)\n> -\t\t\t\t<< \" not supported\";\n> +\tPixelFormat format = toPixelFormat(camera3Stream->format);\n> +\tif (!format.isValid())\n> \t\treturn -EINVAL;\n> -\t}\n> \n> \t/*\n> \t * Hardcode viewfinder role, replacing the generated configuration\n> @@ -969,7 +982,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> \tStreamConfiguration *streamConfiguration = &config_->at(0);\n> \tstreamConfiguration->size.width = camera3Stream->width;\n> \tstreamConfiguration->size.height = camera3Stream->height;\n> -\tstreamConfiguration->pixelFormat = it->second;\n> +\tstreamConfiguration->pixelFormat = format;\n> \n> \tswitch (config_->validate()) {\n> \tcase CameraConfiguration::Valid:\n> diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n> index ed11410a5577..5bd6cf416156 100644\n> --- a/src/android/camera_device.h\n> +++ b/src/android/camera_device.h\n> @@ -72,6 +72,7 @@ private:\n> \tstd::tuple calculateStaticMetadataSize();\n> \tvoid notifyShutter(uint32_t frameNumber, uint64_t timestamp);\n> \tvoid notifyError(uint32_t frameNumber, camera3_stream_t *stream);\n> +\tlibcamera::PixelFormat toPixelFormat(int format);\n> \tstd::unique_ptr getResultMetadata(int frame_number,\n> \t\t\t\t\t\t\t int64_t timestamp);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4C25BBFFE2\n\tfor ;\n\tMon, 29 Jun 2020 20:20:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B6D74609DB;\n\tMon, 29 Jun 2020 22:20:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B4426603B2\n\tfor ;\n\tMon, 29 Jun 2020 22:20:48 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B3733299;\n\tMon, 29 Jun 2020 22:20:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"E4lxa/wn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593462048;\n\tbh=bbPjG1KTZ5ymjXO1iRBKR9k1yJCryD+9RJlQ2AqruHY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=E4lxa/wngMSg8qan2Bj8DxARvkHwSSmRjXMt050Ayhq/M7xkQhIafie4uxKstJscX\n\tfBdByoTkL8d77AVQAEOtGcrVA09TtECXwghzg5WOBh6iN++gJzLhgRgf7xiXl3Whs5\n\tUj+xwAZ4K/YYbxFX0wzn24gbLLohGiEYgJ8cu5ek=","Date":"Mon, 29 Jun 2020 23:20:43 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200629202043.GO10681@pendragon.ideasonboard.com>","References":"<20200629163916.1815321-1-kieran.bingham@ideasonboard.com>\n\t<20200629163916.1815321-4-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200629163916.1815321-4-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 3/4] android: camera_device: Provide a\n\ttoPixelFormat helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11018,"web_url":"https://patchwork.libcamera.org/comment/11018/","msgid":"<45442f2f-248a-6818-edf0-afe6c35269f9@ideasonboard.com>","date":"2020-06-30T14:06:52","subject":"Re: [libcamera-devel] [PATCH 3/4] android: camera_device: Provide a\n\ttoPixelFormat helper","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 29/06/2020 21:20, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Mon, Jun 29, 2020 at 05:39:15PM +0100, Kieran Bingham wrote:\n>> Rather than converting pixelformats through the map, and then\n>> dereferencing the iterator later, create a helper to explicitly return a\n>> PixelFormat type.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> src/android/camera_device.cpp | 29 +++++++++++++++++++++--------\n>> src/android/camera_device.h | 1 +\n>> 2 files changed, 22 insertions(+), 8 deletions(-)\n>>\n>> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n>> index f788c11e7254..a6410f42fee8 100644\n>> --- a/src/android/camera_device.cpp\n>> +++ b/src/android/camera_device.cpp\n>> @@ -923,6 +923,20 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n>> \treturn requestTemplate->get();\n>> }\n>> \n>> +PixelFormat CameraDevice::toPixelFormat(int format)\n>> +{\n>> +\t/* Translate Android format code to libcamera pixel format. */\n>> +\tauto it = formatsMap_.find(format);\n>> +\tif (it == formatsMap_.end()) {\n>> +\t\tLOG(HAL, Error) << \"Requested format \"\n>> +\t\t\t\t<< utils::hex(format)\n>> +\t\t\t\t<< \" not supported\";\n> \n> You could reduce the number of lines with\n> \n> \t\tLOG(HAL, Error)\n> \t\t\t<< \"Requested format \" << utils::hex(format)\n> \t\t\t<< \" not supported\";\n> \n\nIndeed, that's what I get for copy-paste moving that code.\nI'll reformat.\n\n\n> \n>> +\t\treturn PixelFormat();\n>> +\t}\n>> +\n>> +\treturn it->second;\n>> +}\n>> +\n>> /*\n>> * Inspect the stream_list to produce a list of StreamConfiguration to\n>> * be use to configure the Camera.\n>> @@ -932,11 +946,14 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n>> \tfor (unsigned int i = 0; i < stream_list->num_streams; ++i) {\n>> \t\tcamera3_stream_t *stream = stream_list->streams[i];\n>> \n>> +\t\tPixelFormat format = toPixelFormat(stream->format);\n>> +\n>> \t\tLOG(HAL, Info) << \"Stream #\" << i\n>> \t\t\t << \", direction: \" << stream->stream_type\n>> \t\t\t << \", width: \" << stream->width\n>> \t\t\t << \", height: \" << stream->height\n>> -\t\t\t << \", format: \" << utils::hex(stream->format);\n>> +\t\t\t << \", format: \" << utils::hex(stream->format)\n>> +\t\t\t << \" (\" << format.toString() << \")\";\n> \n> I wonder if it's really needed here, but I suppose it doesn't hurt\n> either.\n\nThis was what caused me to make this patch in the first place ;-)\n\nPersonally I think this is indeed far more helpful, as it goes from:\n\n\n> [0:01:14.456109430] [3466] INFO HAL camera_device.cpp:956 'ov13858 8-0010': Stream #0, direction: 0, width: 320, height: 240, format: 0x00000022\n\nto\n\n> [0:01:14.456109430] [3466] INFO HAL camera_device.cpp:956 'ov13858 8-0010': Stream #0, direction: 0, width: 320, height: 240, format: 0x00000022 (NV12)\n\n\n> \n> Reviewed-by: Laurent Pinchart \n\nThanks...\n\n\n> \n>> \t}\n>> \n>> \t/* Only one stream is supported. */\n>> @@ -947,13 +964,9 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n>> \tcamera3_stream_t *camera3Stream = stream_list->streams[0];\n>> \n>> \t/* Translate Android format code to libcamera pixel format. */\n>> -\tauto it = formatsMap_.find(camera3Stream->format);\n>> -\tif (it == formatsMap_.end()) {\n>> -\t\tLOG(HAL, Error) << \"Requested format \"\n>> -\t\t\t\t<< utils::hex(camera3Stream->format)\n>> -\t\t\t\t<< \" not supported\";\n>> +\tPixelFormat format = toPixelFormat(camera3Stream->format);\n>> +\tif (!format.isValid())\n>> \t\treturn -EINVAL;\n>> -\t}\n>> \n>> \t/*\n>> \t * Hardcode viewfinder role, replacing the generated configuration\n>> @@ -969,7 +982,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n>> \tStreamConfiguration *streamConfiguration = &config_->at(0);\n>> \tstreamConfiguration->size.width = camera3Stream->width;\n>> \tstreamConfiguration->size.height = camera3Stream->height;\n>> -\tstreamConfiguration->pixelFormat = it->second;\n>> +\tstreamConfiguration->pixelFormat = format;\n>> \n>> \tswitch (config_->validate()) {\n>> \tcase CameraConfiguration::Valid:\n>> diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n>> index ed11410a5577..5bd6cf416156 100644\n>> --- a/src/android/camera_device.h\n>> +++ b/src/android/camera_device.h\n>> @@ -72,6 +72,7 @@ private:\n>> \tstd::tuple calculateStaticMetadataSize();\n>> \tvoid notifyShutter(uint32_t frameNumber, uint64_t timestamp);\n>> \tvoid notifyError(uint32_t frameNumber, camera3_stream_t *stream);\n>> +\tlibcamera::PixelFormat toPixelFormat(int format);\n>> \tstd::unique_ptr getResultMetadata(int frame_number,\n>> \t\t\t\t\t\t\t int64_t timestamp);\n>> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 96B70BF415\n\tfor ;\n\tTue, 30 Jun 2020 14:06:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0136E60C5B;\n\tTue, 30 Jun 2020 16:06:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B39E609C7\n\tfor ;\n\tTue, 30 Jun 2020 16:06:56 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8BB3229F;\n\tTue, 30 Jun 2020 16:06:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gdu/s9Pm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593526015;\n\tbh=hWxy9D73oy4LAvsp4saOPbMEoAwYzcBf5A1XtpQhBE4=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=gdu/s9Pm/7DbpBTro6kZuCOLaT1BqaN6TPts9cfcDawAoKgv3y43HvmwYyFYBacXh\n\tgW1JOw5+luSP5ZgWZ8uazPv1CXWPtcB4fiHOApfOseQfGT16MYdLTdfZy+lAv5tvom\n\titmOfNAkGL3MaxhODAufcFWQuN3RKTFRqDTJ6GWA=","To":"Laurent Pinchart ","References":"<20200629163916.1815321-1-kieran.bingham@ideasonboard.com>\n\t<20200629163916.1815321-4-kieran.bingham@ideasonboard.com>\n\t<20200629202043.GO10681@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<45442f2f-248a-6818-edf0-afe6c35269f9@ideasonboard.com>","Date":"Tue, 30 Jun 2020 15:06:52 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.8.0","MIME-Version":"1.0","In-Reply-To":"<20200629202043.GO10681@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 3/4] android: camera_device: Provide a\n\ttoPixelFormat helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]