[{"id":10981,"web_url":"https://patchwork.libcamera.org/comment/10981/","msgid":"<20200629201457.GN10681@pendragon.ideasonboard.com>","date":"2020-06-29T20:14:57","subject":"Re: [libcamera-devel] [PATCH 1/4] libcamera: camera: Allow\n\tunspecified roles for generateConfiguration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Mon, Jun 29, 2020 at 05:39:13PM +0100, Kieran Bingham wrote:\n> Providing an empty set of roles is permitted to generate an empty\n> configuration from the pipeline handlers.\n> \n> Overload the generateConfiguration() function such that not specifying a\n> roles parameter will use an empty set, and return an empty\n> configuration.\n> \n> Signed-off-by: Kieran Bingham \n\nMakes it a tiny bit easier.\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/camera.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\n> index 9c0e58f7864b..4d1a4a9f52ec 100644\n> --- a/include/libcamera/camera.h\n> +++ b/include/libcamera/camera.h\n> @@ -89,7 +89,7 @@ public:\n> \tconst ControlList &properties();\n> \n> \tconst std::set &streams() const;\n> -\tstd::unique_ptr generateConfiguration(const StreamRoles &roles);\n> +\tstd::unique_ptr generateConfiguration(const StreamRoles &roles = {});\n> \tint configure(CameraConfiguration *config);\n> \n> \tRequest *createRequest(uint64_t cookie = 0);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 763A3BF415\n\tfor ;\n\tMon, 29 Jun 2020 20:15:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F151F609DB;\n\tMon, 29 Jun 2020 22:15:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D5B9E603B2\n\tfor ;\n\tMon, 29 Jun 2020 22:15:00 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 48306299;\n\tMon, 29 Jun 2020 22:15:00 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fs0Bp3Lq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593461700;\n\tbh=8/n0Q8+MfOPBidB3fNHtZye2uxdU3ih58RXqSEawuTw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fs0Bp3Lq1UBDnSmV7B3C4ohkMopy/0FzCTYy1SLVG80KZR6YFQOyLtI8h9CwwSmDU\n\taEQNmj/ckSX/rDLI6b4zNPOEmLKVlbK46Ea2tZ1GqBiz8LHTMHz7C/eR28t++/ZR+E\n\txh8c7/SPLRIx8h6ULPSGtLIW0AQCv2KHL2TghCuw=","Date":"Mon, 29 Jun 2020 23:14:57 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200629201457.GN10681@pendragon.ideasonboard.com>","References":"<20200629163916.1815321-1-kieran.bingham@ideasonboard.com>\n\t<20200629163916.1815321-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200629163916.1815321-2-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/4] libcamera: camera: Allow\n\tunspecified roles for generateConfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]