[{"id":10984,"web_url":"https://patchwork.libcamera.org/comment/10984/","msgid":"<20200629203136.GQ10681@pendragon.ideasonboard.com>","date":"2020-06-29T20:31:36","subject":"Re: [libcamera-devel] [PATCH] libcamera: raspberrypi: Document\n\tvc_sm_cma pointer sharing with IPA","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Mon, Jun 29, 2020 at 06:33:47PM +0200, Niklas Söderlund wrote:\n> Sharing a pointer with the IPA is fragile as it will not work with all\n> IPC mechanisms. Document that it's a temporary workaround that should be\n> reworked.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 9d887b706c3f9670..6d7143162f0645bb 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -1014,6 +1014,10 @@ int PipelineHandlerRPi::configureIPA(Camera *camera)\n> \t\t/*\n> \t\t * The vcsm allocation will always be in the memory region\n> \t\t * < 32-bits to allow Videocore to access the memory.\n> +\t\t *\n> +\t\t * \\todo Sending a pointer to the IPA is a workaround for\n> +\t\t * vc_sm_cma not yet supporting dmabuf. This is fragile and\n> +\t\t * should be reworked as soon as vc_sm_cma permits.\n\nI'd say s/This is fragile/This will not work with IPA module isolation/\nand maybe s/as soon as vc_sm_cma permits/when vc_sma_cma will permit/ as\nwe don't have to make it sound like it's the end of the world :-)\n\nReviewed-by: Laurent Pinchart \n\n> \t\t */\n> \t\tIPAOperationData op;\n> \t\top.operation = RPI_IPA_EVENT_LS_TABLE_ALLOCATION;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F0CD6BF415\n\tfor ;\n\tMon, 29 Jun 2020 20:31:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8BABB609DF;\n\tMon, 29 Jun 2020 22:31:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 020CB603B2\n\tfor ;\n\tMon, 29 Jun 2020 22:31:39 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6FC0A299;\n\tMon, 29 Jun 2020 22:31:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iVx+2wo6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593462699;\n\tbh=L8AIwLuIHu0aKDUengeqp2JvqyQO0gvSLBKpNSRRbF4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=iVx+2wo61nuY0y8bwdq9aezaAWA0XSSUz2VYtGssOAYS8e1gLpwlImmvsxepNeLDc\n\trw/lyRxr2Tjt4FMj/hfgMszv/5TcewtXotIXNQe+7PJxy7Xd2vQLhFiulhayui9wp0\n\tKUqPtfVfXjNPBFCW52KUvSVCClit+gR3e8wEPyKc=","Date":"Mon, 29 Jun 2020 23:31:36 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200629203136.GQ10681@pendragon.ideasonboard.com>","References":"<20200629163347.3760354-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200629163347.3760354-1-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: raspberrypi: Document\n\tvc_sm_cma pointer sharing with IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]