[{"id":10994,"web_url":"https://patchwork.libcamera.org/comment/10994/","msgid":"<20200629215624.GA21860@pendragon.ideasonboard.com>","date":"2020-06-29T21:56:24","subject":"Re: [libcamera-devel] [PATCH 5/6] libcamera: pipeline: raspberrypi:\n\tSimplify format fetching","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Tue, Jun 30, 2020 at 12:14:10AM +0900, Paul Elder wrote:\n> Simplify code for fetching PixelFormatInfo using a V4L2 format by\n\ns/fetching/looking up/ ?\n\n> using the new PixelFormatInfo constructor based on V4L2 format.\n\ns/constructor/lookup function/ :-)\n\n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 9d887b7..4d9ec9c 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -81,8 +81,7 @@ V4L2DeviceFormat findBestMode(V4L2PixFmtMap &formatsMap, const Size &req)\n> \t/* Calculate the closest/best mode from the user requested size. */\n> \tfor (const auto &iter : formatsMap) {\n> \t\tV4L2PixelFormat v4l2Format = iter.first;\n> -\t\tPixelFormat pixelFormat = v4l2Format.toPixelFormat();\n> -\t\tconst PixelFormatInfo &info = PixelFormatInfo::info(pixelFormat);\n> +\t\tconst PixelFormatInfo &info = PixelFormatInfo::info(v4l2Format);\n> \n> \t\tfor (const SizeRange &sz : iter.second) {\n> \t\t\tdouble modeWidth = sz.contains(req) ? req.width : sz.max.width;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CD282BFFE2\n\tfor ;\n\tMon, 29 Jun 2020 21:56:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6510F609D6;\n\tMon, 29 Jun 2020 23:56:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 628E0603B2\n\tfor ;\n\tMon, 29 Jun 2020 23:56:28 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CFED0299;\n\tMon, 29 Jun 2020 23:56:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HxRUa+Km\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593467788;\n\tbh=Mb/GMob+GeOBUbTguYBfAwKRJu1jCq8Q+vICDR0dmyY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HxRUa+Kmhwc8JQWo8HC5CTzveC8xFUoK4D+P4++KWQNbqTJE4QG4AfU1zcPIEPpa4\n\tQtU7S6x9oQjaMcoL3QvTSFE3weqY+ao8JsNUq5+gIX2rV1OFDD4c8CqXO6MuSdBETe\n\t5yxjFzSlBqdNWzv+pINB/Unwvs5kfP4vseCf4lHo=","Date":"Tue, 30 Jun 2020 00:56:24 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"<20200629215624.GA21860@pendragon.ideasonboard.com>","References":"<20200629151411.216477-1-paul.elder@ideasonboard.com>\n\t<20200629151411.216477-6-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200629151411.216477-6-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 5/6] libcamera: pipeline: raspberrypi:\n\tSimplify format fetching","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]