{"id":8502,"url":"https://patchwork.libcamera.org/api/patches/8502/?format=json","web_url":"https://patchwork.libcamera.org/patch/8502/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200629151411.216477-4-paul.elder@ideasonboard.com>","date":"2020-06-29T15:14:08","name":"[libcamera-devel,3/6] libcamera: formats: PixelFormatInfo: Add v4l2 constructor","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"0d2f72a5583b50c9355e7c172db57e81f6447e6a","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8502/mbox/","series":[{"id":1056,"url":"https://patchwork.libcamera.org/api/series/1056/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1056","date":"2020-06-29T15:14:05","name":"Move formats from v4l2-compat into libcamera","version":1,"mbox":"https://patchwork.libcamera.org/series/1056/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8502/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8502/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 22428BFFE2\n\tfor ;\n\tMon, 29 Jun 2020 15:14:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E3E8A60AF6;\n\tMon, 29 Jun 2020 17:14:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5EB66609C2\n\tfor ;\n\tMon, 29 Jun 2020 17:14:28 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E664A299;\n\tMon, 29 Jun 2020 17:14:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cDkY9qGr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593443668;\n\tbh=lvaWxNC2vBsXG/kCDkB+qXNaNGTuoiq6AmY/yu/RqsY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=cDkY9qGrg6qb2DNZRxaMkkgdM6C8oqJLRuCFzPWQOradiAzmWdA8TrNLXPLmyg7lT\n\tsh3PE+KKpY00+umqH3vVEdBCYDLKL6xlurbdmcXINjbcDs6BPlin1Ut5kg6+v+EYhC\n\tQkkg8zV9zqaH+5VhUwG5YSQEgL9eop+2Bbt2ued4=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 30 Jun 2020 00:14:08 +0900","Message-Id":"<20200629151411.216477-4-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200629151411.216477-1-paul.elder@ideasonboard.com>","References":"<20200629151411.216477-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 3/6] libcamera: formats: PixelFormatInfo:\n\tAdd v4l2 constructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a constructor for PixelFormatInfo that takes a V4L2PixelFormat.\n\nSigned-off-by: Paul Elder \n---\n include/libcamera/internal/formats.h | 1 +\n src/libcamera/formats.cpp | 16 ++++++++++++++--\n 2 files changed, 15 insertions(+), 2 deletions(-)","diff":"diff --git a/include/libcamera/internal/formats.h b/include/libcamera/internal/formats.h\nindex dc19492..3c7440a 100644\n--- a/include/libcamera/internal/formats.h\n+++ b/include/libcamera/internal/formats.h\n@@ -44,6 +44,7 @@ public:\n \tbool isValid() const { return format.isValid(); }\n \n \tstatic const PixelFormatInfo &info(const PixelFormat &format);\n+\tstatic const PixelFormatInfo &info(const V4L2PixelFormat &format);\n \n \tconst char *name;\n \tPixelFormat format;\ndiff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 88b5168..7029a94 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -631,6 +631,8 @@ const std::map pixelFormatInfo{\n \n } /* namespace */\n \n+static const PixelFormatInfo invalid{};\n+\n /**\n * \\fn bool PixelFormatInfo::isValid() const\n * \\brief Check if the pixel format info is valid\n@@ -645,8 +647,6 @@ const std::map pixelFormatInfo{\n */\n const PixelFormatInfo &PixelFormatInfo::info(const PixelFormat &format)\n {\n-\tstatic const PixelFormatInfo invalid{};\n-\n \tconst auto iter = pixelFormatInfo.find(format);\n \tif (iter == pixelFormatInfo.end()) {\n \t\tLOG(Formats, Warning)\n@@ -658,4 +658,16 @@ const PixelFormatInfo &PixelFormatInfo::info(const PixelFormat &format)\n \treturn iter->second;\n }\n \n+const PixelFormatInfo &PixelFormatInfo::info(const V4L2PixelFormat &format)\n+{\n+\tauto info = std::find_if(pixelFormatInfo.begin(), pixelFormatInfo.end(),\n+\t\t\t\t [format](auto pair) {\n+\t\t\t\t\t return pair.second.v4l2Format == format;\n+\t\t\t\t });\n+\tif (info == pixelFormatInfo.end())\n+\t\treturn invalid;\n+\n+\treturn info->second;\n+}\n+\n } /* namespace libcamera */\n","prefixes":["libcamera-devel","3/6"]}